From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D95F4C43381 for ; Fri, 22 Mar 2019 12:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A983B2054F for ; Fri, 22 Mar 2019 12:24:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553257447; bh=YdzP6Wk6BkgApZlGBh3Ogp0U/Cs6zz/3vN0+YzCeh/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qO8N+cVRfpctJ9IFFzAINz/3+6UJVEx+DS757CFj3D6LbalOReOBlGD+BZNRqW+pO AqDI2Kc6Qrlb9UPc4foDu1ZPIgL5kOlP0W+4EKnhwlq3txK58BmHt6BOB/SLPfqqDa +kp3DgDQRoJp2CwhTgdDZ2e8O3U+eARBw4lbZSkc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390962AbfCVMYG (ORCPT ); Fri, 22 Mar 2019 08:24:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:35756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390701AbfCVMYD (ORCPT ); Fri, 22 Mar 2019 08:24:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 518622075D; Fri, 22 Mar 2019 12:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553257442; bh=YdzP6Wk6BkgApZlGBh3Ogp0U/Cs6zz/3vN0+YzCeh/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cAVVpheZ2LvbxBUUkVbgF6g6cpa3nW3V6PCU4nzzILNt4/ijh4mx1/gWY/eFSq1cR blGa9ohCn2DEuQ7LhLHCDFyp561PyxH+xTWtN/ts7v3NQ5cTDF8pRs9v5hrBhQSsqp hP+x+FFpaDGyUBAT1bME/9BsJ2pXjXmAb9nggWfs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adrian Hunter , Jiri Olsa , Arnaldo Carvalho de Melo Subject: [PATCH 5.0 200/238] perf intel-pt: Fix CYC timestamp calculation after OVF Date: Fri, 22 Mar 2019 12:16:59 +0100 Message-Id: <20190322111310.000327021@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111258.383569278@linuxfoundation.org> References: <20190322111258.383569278@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Adrian Hunter commit 03997612904866abe7cdcc992784ef65cb3a4b81 upstream. CYC packet timestamp calculation depends upon CBR which was being cleared upon overflow (OVF). That can cause errors due to failing to synchronize with sideband events. Even if a CBR change has been lost, the old CBR is still a better estimate than zero. So remove the clearing of CBR. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20190206103947.15750-4-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 1 - 1 file changed, 1 deletion(-) --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c @@ -1394,7 +1394,6 @@ static int intel_pt_overflow(struct inte { intel_pt_log("ERROR: Buffer overflow\n"); intel_pt_clear_tx_flags(decoder); - decoder->cbr = 0; decoder->timestamp_insn_cnt = 0; decoder->pkt_state = INTEL_PT_STATE_ERR_RESYNC; decoder->overflow = true;