From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CD63C43381 for ; Fri, 22 Mar 2019 12:07:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF95A21939 for ; Fri, 22 Mar 2019 12:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256478; bh=jRIHKxbdO79B2qiVU9zmbXQKVtwRF4vRRP2QRiRuWHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BNXNU/wl0bPsSi0BwE9sbZJ8i5BWvncs7XGnHVZ1YLyoowW3yFFsH7y3Tix1eY4jD Odp4vO33NyxSylCrjgIAHX1axUM+chhOLGiAZvDZZklRM7nS4PLYNwkQVHdByEFisZ 5Q5qblfcD++S6Y/7g9WWEWDAs3jmNx1kancsk8yY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389107AbfCVMH5 (ORCPT ); Fri, 22 Mar 2019 08:07:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389094AbfCVMH4 (ORCPT ); Fri, 22 Mar 2019 08:07:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 17D6F2082C; Fri, 22 Mar 2019 12:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256475; bh=jRIHKxbdO79B2qiVU9zmbXQKVtwRF4vRRP2QRiRuWHQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MCE20JUCTIp7EomxpjKKtFP3IcVOH+KN9QM+fELcAYxjzLDkfs8Nee7onKJxY8nGO STnHqgtAX3uxLLHXxsSsAZ/E3ktCdt5mqHvrSvWGXwioRkjX0M30wyJNsw2e2B7s8l GkBRyX6BTrFz3U8lY/LwHNJVldOFfxDDlY15VnMo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jordan Niethe , Stewart Smith , Andrew Donnellan , Michael Ellerman Subject: [PATCH 4.19 223/280] powerpc/powernv: Make opal log only readable by root Date: Fri, 22 Mar 2019 12:16:16 +0100 Message-Id: <20190322111335.399249553@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111306.356185024@linuxfoundation.org> References: <20190322111306.356185024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jordan Niethe commit 7b62f9bd2246b7d3d086e571397c14ba52645ef1 upstream. Currently the opal log is globally readable. It is kernel policy to limit the visibility of physical addresses / kernel pointers to root. Given this and the fact the opal log may contain this information it would be better to limit the readability to root. Fixes: bfc36894a48b ("powerpc/powernv: Add OPAL message log interface") Cc: stable@vger.kernel.org # v3.15+ Signed-off-by: Jordan Niethe Reviewed-by: Stewart Smith Reviewed-by: Andrew Donnellan Signed-off-by: Michael Ellerman Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/platforms/powernv/opal-msglog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/powerpc/platforms/powernv/opal-msglog.c +++ b/arch/powerpc/platforms/powernv/opal-msglog.c @@ -98,7 +98,7 @@ static ssize_t opal_msglog_read(struct f } static struct bin_attribute opal_msglog_attr = { - .attr = {.name = "msglog", .mode = 0444}, + .attr = {.name = "msglog", .mode = 0400}, .read = opal_msglog_read };