From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCFBC43381 for ; Fri, 22 Mar 2019 12:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FD7E2082C for ; Fri, 22 Mar 2019 12:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256617; bh=h2+t/1/JcXNw+Oc+PopxsgZhwQaeiWr5i5HGMBK4tAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KRQiY6VzdFdh93OPhOqDwRmfx7WoR3dQ6t8v3RkkrGudeFcPOaPBGYDV8RhRHrrO9 3cXmundMzcYVancSg+776nqdCWt2KdL/fd0NrQASP3kvo3w2lwJxcQZBiSzkYqzEfW YGcpPxLd0NGL58gQ/IcmYUMVG65krf4IMLsIjcII= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389402AbfCVMKQ (ORCPT ); Fri, 22 Mar 2019 08:10:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:48612 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388044AbfCVMKK (ORCPT ); Fri, 22 Mar 2019 08:10:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFCE220830; Fri, 22 Mar 2019 12:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256610; bh=h2+t/1/JcXNw+Oc+PopxsgZhwQaeiWr5i5HGMBK4tAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qpdygp2DJ+nI5kwvjUv7F1r68hrza0AbsYIu6CsxCmBbjBV+8Qm23ZDw/ZYJ0pysJ O+aVvJ4tePi24+/K3jjFZ2NUiQO7AcpuyYYXoB61KIGDEwsJ1XDJj1g0Ih43veh3y8 MeltweeztVpReK0j7PlDczYXCLpMH6WqeLIWdP1M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Trond Myklebust Subject: [PATCH 4.19 241/280] NFS: Fix an I/O request leakage in nfs_do_recoalesce Date: Fri, 22 Mar 2019 12:16:34 +0100 Message-Id: <20190322111339.454217698@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111306.356185024@linuxfoundation.org> References: <20190322111306.356185024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Trond Myklebust commit 4d91969ed4dbcefd0e78f77494f0cb8fada9048a upstream. Whether we need to exit early, or just reprocess the list, we must not lost track of the request which failed to get recoalesced. Fixes: 03d5eb65b538 ("NFS: Fix a memory leak in nfs_do_recoalesce") Signed-off-by: Trond Myklebust Cc: stable@vger.kernel.org # v4.0+ Signed-off-by: Greg Kroah-Hartman --- fs/nfs/pagelist.c | 1 - 1 file changed, 1 deletion(-) --- a/fs/nfs/pagelist.c +++ b/fs/nfs/pagelist.c @@ -1093,7 +1093,6 @@ static int nfs_do_recoalesce(struct nfs_ struct nfs_page *req; req = list_first_entry(&head, struct nfs_page, wb_list); - nfs_list_remove_request(req); if (__nfs_pageio_add_request(desc, req)) continue; if (desc->pg_error < 0) {