From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8708CC10F03 for ; Fri, 22 Mar 2019 13:13:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 562C12183E for ; Fri, 22 Mar 2019 13:13:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553260418; bh=QfgSXICcLsFHX48Dgu7Qo1L94TeNrwxP0FWO3ynu8kg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=OFDpEEajtz3DIUVMaNiCSqWPNI7+JsvUhtQ4R00Cg2acH/vtG4RSUQzaRlWiJwy7G I+HHouvffLNl/uptV9RaqHTCiyDSQeNc4RCrYqSBe2wOS6i4qd9CHOWEaa5mj5Bj4t jTX7rZQEI0U+uGi9kvyQI9FFWhCwxYL6movdPN+c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729865AbfCVNNb (ORCPT ); Fri, 22 Mar 2019 09:13:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:58280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729092AbfCVLaT (ORCPT ); Fri, 22 Mar 2019 07:30:19 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 366B4218B0; Fri, 22 Mar 2019 11:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553254218; bh=QfgSXICcLsFHX48Dgu7Qo1L94TeNrwxP0FWO3ynu8kg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PQJwk2sfMYmur9IF3CR9A+iiTwjFZtsPtbsqaneMPXkBwTYfTOcaukWvMaVHWk3Zc AwviV5/VXCw3nu5Av9YTPT+q8gI3UtWhOr2YfEsosJ+iHdiaDTsViWb7Y7VqOzlKyI dZGSgpx8GKgwC3J+b73mOl+cFq4G2XzyVd65oOLg= Date: Fri, 22 Mar 2019 06:30:15 -0500 From: Bjorn Helgaas To: Lyude Paul Cc: David Ober , linux-pci@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Karol Herbst , Ben Skeggs , stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH] pci/quirks: Add quirk to reset nvgpu at boot for the Lenovo ThinkPad P50 Message-ID: <20190322113015.GM251185@google.com> References: <20190212220230.1568-1-lyude@redhat.com> <20190215004329.GR96272@google.com> <2fca9a9feafcd17b27bc71994a71ebc241a93e9a.camel@redhat.com> <52b17f8cb24e179e9661d75548d193843ae87b4c.camel@redhat.com> <20190321224819.GK251185@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321224819.GK251185@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Mar 21, 2019 at 05:48:19PM -0500, Bjorn Helgaas wrote: > On Wed, Mar 13, 2019 at 06:25:02PM -0400, Lyude Paul wrote: > > On Fri, 2019-02-15 at 16:17 -0500, Lyude Paul wrote: > > > On Thu, 2019-02-14 at 18:43 -0600, Bjorn Helgaas wrote: > > > > On Tue, Feb 12, 2019 at 05:02:30PM -0500, Lyude Paul wrote: > > > > > On a very specific subset of ThinkPad P50 SKUs, particularly > > > > > ones that come with a Quadro M1000M chip instead of the M2000M > > > > > variant, the BIOS seems to have a very nasty habit of not > > > > > always resetting the secondary Nvidia GPU between full reboots > > > > > if the laptop is configured in Hybrid Graphics mode. The > > > > > reason for this happening is unknown, but the following steps > > > > > and possibly a good bit of patience will reproduce the issue: > > > > > > > > > > 1. Boot up the laptop normally in Hybrid graphics mode > > > > > 2. Make sure nouveau is loaded and that the GPU is awake > > > > > 2. Allow the nvidia GPU to runtime suspend itself after being idle > > > > > 3. Reboot the machine, the more sudden the better (e.g sysrq-b may help) > > > > > 4. If nouveau loads up properly, reboot the machine again and go back to > > > > > step 2 until you reproduce the issue > > > > > > > > > > This results in some very strange behavior: the GPU will quite > > > > > literally be left in exactly the same state it was in when the > > > > > previously booted kernel started the reboot. This has all > > > > > sorts of bad sideaffects: for starters, this completely breaks > > > > > nouveau starting with a mysterious EVO channel failure that > > > > > happens well before we've actually used the EVO channel for > > > > > anything: > > Thanks for the hybrid tutorial (snipped from this response). IIUC, > what you said was that in hybrid mode, the Intel GPU drives the > built-in display and the Nvidia GPU drives any external displays and > may be used for DRI PRIME rendering (whatever that is). But since you > say the Nvidia device gets runtime suspended, I assume there's no > external display here and you're not using DRI PRIME. > > I wonder if it's related to the fact that the Nvidia GPU has been > runtime suspended before you do the reboot. Can you try turning of > runtime power management for the GPU by setting the runpm module > parameter to 0? I *think* this would be booting with > "nouveau.runpm=0". Sorry, I wasn't really thinking here. You already *said* this is related to runtime suspend. It only happens when the Nvidia GPU has been suspended. I don't know that much about suspend, but ISTR seeing comments about resuming devices before we shutdown. If we do that, maybe there's some kind of race between that resume and the reboot? Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Subject: Re: [PATCH] pci/quirks: Add quirk to reset nvgpu at boot for the Lenovo ThinkPad P50 Date: Fri, 22 Mar 2019 06:30:15 -0500 Message-ID: <20190322113015.GM251185@google.com> References: <20190212220230.1568-1-lyude@redhat.com> <20190215004329.GR96272@google.com> <2fca9a9feafcd17b27bc71994a71ebc241a93e9a.camel@redhat.com> <52b17f8cb24e179e9661d75548d193843ae87b4c.camel@redhat.com> <20190321224819.GK251185@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190321224819.GK251185-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Lyude Paul Cc: linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Ober , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org T24gVGh1LCBNYXIgMjEsIDIwMTkgYXQgMDU6NDg6MTlQTSAtMDUwMCwgQmpvcm4gSGVsZ2FhcyB3 cm90ZToKPiBPbiBXZWQsIE1hciAxMywgMjAxOSBhdCAwNjoyNTowMlBNIC0wNDAwLCBMeXVkZSBQ YXVsIHdyb3RlOgo+ID4gT24gRnJpLCAyMDE5LTAyLTE1IGF0IDE2OjE3IC0wNTAwLCBMeXVkZSBQ YXVsIHdyb3RlOgo+ID4gPiBPbiBUaHUsIDIwMTktMDItMTQgYXQgMTg6NDMgLTA2MDAsIEJqb3Ju IEhlbGdhYXMgd3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBGZWIgMTIsIDIwMTkgYXQgMDU6MDI6MzBQ TSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90ZToKPiA+ID4gPiA+IE9uIGEgdmVyeSBzcGVjaWZpYyBz dWJzZXQgb2YgVGhpbmtQYWQgUDUwIFNLVXMsIHBhcnRpY3VsYXJseQo+ID4gPiA+ID4gb25lcyB0 aGF0IGNvbWUgd2l0aCBhIFF1YWRybyBNMTAwME0gY2hpcCBpbnN0ZWFkIG9mIHRoZSBNMjAwME0K PiA+ID4gPiA+IHZhcmlhbnQsIHRoZSBCSU9TIHNlZW1zIHRvIGhhdmUgYSB2ZXJ5IG5hc3R5IGhh Yml0IG9mIG5vdAo+ID4gPiA+ID4gYWx3YXlzIHJlc2V0dGluZyB0aGUgc2Vjb25kYXJ5IE52aWRp YSBHUFUgYmV0d2VlbiBmdWxsIHJlYm9vdHMKPiA+ID4gPiA+IGlmIHRoZSBsYXB0b3AgaXMgY29u ZmlndXJlZCBpbiBIeWJyaWQgR3JhcGhpY3MgbW9kZS4gVGhlCj4gPiA+ID4gPiByZWFzb24gZm9y IHRoaXMgaGFwcGVuaW5nIGlzIHVua25vd24sIGJ1dCB0aGUgZm9sbG93aW5nIHN0ZXBzCj4gPiA+ ID4gPiBhbmQgcG9zc2libHkgYSBnb29kIGJpdCBvZiBwYXRpZW5jZSB3aWxsIHJlcHJvZHVjZSB0 aGUgaXNzdWU6Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IDEuIEJvb3QgdXAgdGhlIGxhcHRvcCBub3Jt YWxseSBpbiBIeWJyaWQgZ3JhcGhpY3MgbW9kZQo+ID4gPiA+ID4gMi4gTWFrZSBzdXJlIG5vdXZl YXUgaXMgbG9hZGVkIGFuZCB0aGF0IHRoZSBHUFUgaXMgYXdha2UKPiA+ID4gPiA+IDIuIEFsbG93 IHRoZSBudmlkaWEgR1BVIHRvIHJ1bnRpbWUgc3VzcGVuZCBpdHNlbGYgYWZ0ZXIgYmVpbmcgaWRs ZQo+ID4gPiA+ID4gMy4gUmVib290IHRoZSBtYWNoaW5lLCB0aGUgbW9yZSBzdWRkZW4gdGhlIGJl dHRlciAoZS5nIHN5c3JxLWIgbWF5IGhlbHApCj4gPiA+ID4gPiA0LiBJZiBub3V2ZWF1IGxvYWRz IHVwIHByb3Blcmx5LCByZWJvb3QgdGhlIG1hY2hpbmUgYWdhaW4gYW5kIGdvIGJhY2sgdG8KPiA+ ID4gPiA+IHN0ZXAgMiB1bnRpbCB5b3UgcmVwcm9kdWNlIHRoZSBpc3N1ZQo+ID4gPiA+ID4gCj4g PiA+ID4gPiBUaGlzIHJlc3VsdHMgaW4gc29tZSB2ZXJ5IHN0cmFuZ2UgYmVoYXZpb3I6IHRoZSBH UFUgd2lsbCBxdWl0ZQo+ID4gPiA+ID4gbGl0ZXJhbGx5IGJlIGxlZnQgaW4gZXhhY3RseSB0aGUg c2FtZSBzdGF0ZSBpdCB3YXMgaW4gd2hlbiB0aGUKPiA+ID4gPiA+IHByZXZpb3VzbHkgYm9vdGVk IGtlcm5lbCBzdGFydGVkIHRoZSByZWJvb3QuIFRoaXMgaGFzIGFsbAo+ID4gPiA+ID4gc29ydHMg b2YgYmFkIHNpZGVhZmZlY3RzOiBmb3Igc3RhcnRlcnMsIHRoaXMgY29tcGxldGVseSBicmVha3MK PiA+ID4gPiA+IG5vdXZlYXUgc3RhcnRpbmcgd2l0aCBhIG15c3RlcmlvdXMgRVZPIGNoYW5uZWwg ZmFpbHVyZSB0aGF0Cj4gPiA+ID4gPiBoYXBwZW5zIHdlbGwgYmVmb3JlIHdlJ3ZlIGFjdHVhbGx5 IHVzZWQgdGhlIEVWTyBjaGFubmVsIGZvcgo+ID4gPiA+ID4gYW55dGhpbmc6Cj4gCj4gVGhhbmtz IGZvciB0aGUgaHlicmlkIHR1dG9yaWFsIChzbmlwcGVkIGZyb20gdGhpcyByZXNwb25zZSkuICBJ SVVDLAo+IHdoYXQgeW91IHNhaWQgd2FzIHRoYXQgaW4gaHlicmlkIG1vZGUsIHRoZSBJbnRlbCBH UFUgZHJpdmVzIHRoZQo+IGJ1aWx0LWluIGRpc3BsYXkgYW5kIHRoZSBOdmlkaWEgR1BVIGRyaXZl cyBhbnkgZXh0ZXJuYWwgZGlzcGxheXMgYW5kCj4gbWF5IGJlIHVzZWQgZm9yIERSSSBQUklNRSBy ZW5kZXJpbmcgKHdoYXRldmVyIHRoYXQgaXMpLiAgQnV0IHNpbmNlIHlvdQo+IHNheSB0aGUgTnZp ZGlhIGRldmljZSBnZXRzIHJ1bnRpbWUgc3VzcGVuZGVkLCBJIGFzc3VtZSB0aGVyZSdzIG5vCj4g ZXh0ZXJuYWwgZGlzcGxheSBoZXJlIGFuZCB5b3UncmUgbm90IHVzaW5nIERSSSBQUklNRS4KPiAK PiBJIHdvbmRlciBpZiBpdCdzIHJlbGF0ZWQgdG8gdGhlIGZhY3QgdGhhdCB0aGUgTnZpZGlhIEdQ VSBoYXMgYmVlbgo+IHJ1bnRpbWUgc3VzcGVuZGVkIGJlZm9yZSB5b3UgZG8gdGhlIHJlYm9vdC4g IENhbiB5b3UgdHJ5IHR1cm5pbmcgb2YKPiBydW50aW1lIHBvd2VyIG1hbmFnZW1lbnQgZm9yIHRo ZSBHUFUgYnkgc2V0dGluZyB0aGUgcnVucG0gbW9kdWxlCj4gcGFyYW1ldGVyIHRvIDA/ICBJICp0 aGluayogdGhpcyB3b3VsZCBiZSBib290aW5nIHdpdGgKPiAibm91dmVhdS5ydW5wbT0wIi4KClNv cnJ5LCBJIHdhc24ndCByZWFsbHkgdGhpbmtpbmcgaGVyZS4gIFlvdSBhbHJlYWR5ICpzYWlkKiB0 aGlzIGlzCnJlbGF0ZWQgdG8gcnVudGltZSBzdXNwZW5kLiAgSXQgb25seSBoYXBwZW5zIHdoZW4g dGhlIE52aWRpYSBHUFUgaGFzCmJlZW4gc3VzcGVuZGVkLgoKSSBkb24ndCBrbm93IHRoYXQgbXVj aCBhYm91dCBzdXNwZW5kLCBidXQgSVNUUiBzZWVpbmcgY29tbWVudHMgYWJvdXQKcmVzdW1pbmcg ZGV2aWNlcyBiZWZvcmUgd2Ugc2h1dGRvd24uICBJZiB3ZSBkbyB0aGF0LCBtYXliZSB0aGVyZSdz CnNvbWUga2luZCBvZiByYWNlIGJldHdlZW4gdGhhdCByZXN1bWUgYW5kIHRoZSByZWJvb3Q/CgpC am9ybgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2 ZWF1IG1haWxpbmcgbGlzdApOb3V2ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL25vdXZlYXU=