From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: musb: Support gadget mode when the port is set to dual role From: Bin Liu Message-Id: <20190322133608.GE25852@uda0271908> Date: Fri, 22 Mar 2019 08:36:08 -0500 To: Paul Kocialkowski Cc: Greg Kroah-Hartman , Maxime Ripard , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Chen-Yu Tsai List-ID: T24gRnJpLCBNYXIgMjIsIDIwMTkgYXQgMDI6MTA6MDFQTSArMDEwMCwgUGF1bCBLb2NpYWxrb3dz a2kgd3JvdGU6Cj4gSGksCj4gCj4gTGUgdmVuZHJlZGkgMjIgbWFycyAyMDE5IMOgIDA3OjQ2IC0w NTAwLCBCaW4gTGl1IGEgw6ljcml0IDoKPiA+IE9uIFRodSwgTWFyIDIxLCAyMDE5IGF0IDA1OjQx OjM4UE0gKzAxMDAsIEdyZWcgS3JvYWgtSGFydG1hbiB3cm90ZToKPiA+ID4gT24gVGh1LCBNYXIg MjEsIDIwMTkgYXQgMDI6MDE6MzNQTSArMDEwMCwgTWF4aW1lIFJpcGFyZCB3cm90ZToKPiA+ID4g PiBIaSwKPiA+ID4gPiAKPiA+ID4gPiBJJ20gcmV2aXZpbmcgdGhpcyB0aHJlYWQgYSBiaXQsIGJl Y2F1c2UgSSBlbmNvdW50ZXJlZCB0aGlzIGJ1ZyB0b2RheS4KPiA+ID4gPiAKPiA+ID4gPiBPbiBU aHUsIE1hciAyMSwgMjAxOSBhdCAxMTowMjoxMEFNICswMTAwLCBCaW4gTGl1IHdyb3RlOgo+ID4g PiA+ID4gT24gU2F0LCBBcHIgMjEsIDIwMTggYXQgMTI6NTk6MjNQTSArMDIwMCwgUGF1bCBLb2Np YWxrb3dza2kgd3JvdGU6Cj4gPiA+ID4gPiA+IEhpLAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g TGUgdmVuZHJlZGkgMjAgYXZyaWwgMjAxOCDDoCAwOToyNSAtMDUwMCwgQmluIExpdSBhIMOpY3Jp dCA6Cj4gPiA+ID4gPiA+ID4gT24gVGh1LCBNYXIgMjksIDIwMTggYXQgMDE6NTc6MjRQTSArMDIw MCwgUGF1bCBLb2NpYWxrb3dza2kgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gPiBIaSwKPiA+ID4gPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gT24gVGh1LCAyMDE4LTAzLTI5IGF0IDExOjIzICswMjAw LCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gPiBPbiBXZWQsIE1hciAyOCwg MjAxOCBhdCAxMTo1MjoxM1BNICswMjAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90ZToKPiA+ID4g PiA+ID4gPiA+ID4gPiBUaGlzIGFsbG93cyBkdWFsLXJvbGUgcG9ydHMgdG8gYmUgcmVwb3J0ZWQg YXMgaGF2aW5nIGdhZGdldCBtb2RlCj4gPiA+ID4gPiA+ID4gPiA+ID4gYnkKPiA+ID4gPiA+ID4g PiA+ID4gPiB0aGUKPiA+ID4gPiA+ID4gPiA+ID4gPiBtdXNiX2hhc19nYWRnZXQgaGVscGVyLiBU aGlzIGlzIHJlcXVpcmVkIHRvIGVuYWJsZSBNVVNCIGF0IGFsbAo+ID4gPiA+ID4gPiA+ID4gPiA+ IHdpdGgKPiA+ID4gPiA+ID4gPiA+ID4gPiBNVVNCCj4gPiA+ID4gPiA+ID4gPiA+ID4gZ2x1ZSBs YXllcnMgdGhhdCBzZXQgdGhlIHBvcnQgbW9kZSB0byBNVVNCX1BPUlRfTU9ERV9EVUFMX1JPTEUK PiA+ID4gPiA+ID4gPiA+ID4gPiBhdAo+ID4gPiA+ID4gPiA+ID4gPiA+IGluaXQuCj4gPiA+ID4g PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gPiA+ID4gTW9zdCBub3RhYmx5LCB0aGlzIGFsbG93 cyBjYWxsaW5nIG11c2Jfc3RhcnQgd2hlbiBuZWVkZWQgaW4gdGhlCj4gPiA+ID4gPiA+ID4gPiA+ ID4gdmlydHVhbAo+ID4gPiA+ID4gPiA+ID4gPiA+IE1VU0Igcm9vdCBIVUIsIHJlZ2FyZGxlc3Mg b2Ygd2hldGhlciB0aGUgY3VycmVudCBtb2RlIHNob3VsZCBiZQo+ID4gPiA+ID4gPiA+ID4gPiA+ IGdhZGdldAo+ID4gPiA+ID4gPiA+ID4gPiA+IG9yIGhvc3QuCj4gPiA+ID4gPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+ID4gPiA+ID4gVGhpcyBmaXhlcyBVU0IgT1RHIG9uIEFsbHdpbm5lciBkZXZp Y2VzIHRoYXQgSSBjb3VsZCB0ZXN0IGl0Cj4gPiA+ID4gPiA+ID4gPiA+ID4gd2l0aCwKPiA+ID4g PiA+ID4gPiA+ID4gPiBtYWlubHkgQTIwIGRldmljZXMuCj4gPiA+ID4gPiA+ID4gPiA+ID4gCj4g PiA+ID4gPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBLb2NpYWxrb3dza2kgPGNvbnRh Y3RAcGF1bGsuZnI+Cj4gPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gPiBTdXJlbHkg dGhlcmUncyBtb3JlIHRvIGl0IHRoYW4gdGhhdC4gVGhlIGdhZGdldCBtb2RlIG9mIEEyMCBib2Fy ZHMKPiA+ID4gPiA+ID4gPiA+ID4gaGF2ZSBiZWVuIHdvcmtpbmcgaW4gdGhlIHBhc3QsIGluY2x1 ZGluZyB3aGVuIGNvbXBpbGluZyB3aXRoIG1VU0IKPiA+ID4gPiA+ID4gPiA+ID4gc2V0dXAgYXMg ZHVhbCByb2xlLgo+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4gSXMgdGhpcyBh IHJlZ3Jlc3Npb24gc2luY2UgYSBwYXJ0aWN1bGFyIGNvbW1pdD8gT3IgaXMgdGhlcmUKPiA+ID4g PiA+ID4gPiA+ID4gYW5vdGhlciwKPiA+ID4gPiA+ID4gPiA+ID4gZGVlcGVyIGlzc3VlIG92ZXJs b29rZWQgaW4gdGhlIGNvbW1pdCBsb2c/Cj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ IFRoZSByb290IG9mIHRoZSBpc3N1ZSBoZXJlIGlzIHRoYXQgbXVzYl9zdGFydCBpcyBub3QgY2Fs bGVkIGF0IGFueQo+ID4gPiA+ID4gPiA+ID4gcG9pbnQKPiA+ID4gPiA+ID4gPiA+IHdpdGhvdXQg dGhpcyBwYXRjaC4gTXkgdW5kZXJzdGFuZGluZyBvZiB0aGUgZmxvdyBpcyB0aGUgZm9sbG93aW5n Ogo+ID4gPiA+ID4gPiA+ID4gd2hlbgo+ID4gPiA+ID4gPiA+ID4gdGhlIFBIWSBkZXRlY3RzIHRo YXQgdGhlcmUgd2FzIGEgVkJVUy9JRCBjaGFuZ2UsIGl0IHdpbGwgbm90aWZ5IGl0cwo+ID4gPiA+ ID4gPiA+ID4gbGlzdGVuZXJzIChtYWlubHkgdGhlIG11c2Igc3VueGkgZ2x1ZSBsYXllcikuIFRo aXMgd2lsbCB0aGVuCj4gPiA+ID4gPiA+ID4gPiBzY2hlZHVsZQo+ID4gPiA+ID4gPiA+ID4gdGhl IGRyaXZlcidzIHdvcmsgKHN1bnhpX211c2Jfd29yayksIHdoaWNoIGRvZXMgbm90aGluZyBzaW5j ZSB0aGUKPiA+ID4gPiA+ID4gPiA+IFNVTlhJX01VU0JfRkxfRU5BQkxFRCBiaXQgd2FzIG5ldmVy IHNldC4gVGhpcyBiaXQgaXMgb25seSBzZXQgYWZ0ZXIKPiA+ID4gPiA+ID4gPiA+IGNhbGxpbmcg c3VueGlfbXVzYl9lbmFibGUsIHdoaWNoIGlzIGNhbGxlZCBmcm9tCj4gPiA+ID4gPiA+ID4gPiBt dXNiX3BsYXRmb3JtX2VuYWJsZSwKPiA+ID4gPiA+ID4gPiA+IHRoYXQgb3JpZ2luYXRlcyBmcm9t IG11c2Jfc3RhcnQuCj4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+IEN1cnJlbnRseSBJ IHNlZSB0d28gcGxhY2VzIHdoZXJlIG11c2Jfc3RhcnQgaXMgY2FsbGVkOgo+ID4gPiA+ID4gPiA+ ID4gKiBtdXNiX3ZpcnRodWIKPiA+ID4gPiA+ID4gPiA+ICogbXVzYl9nYWRnZXQKPiA+ID4gPiA+ ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gSW4gdGhlIGxhdHRlciBjYXNlLCBpdCBpcyBpbiB0dXJu IGNhbGxlZCBmcm9tIHVkY19zdGFydCwgd2hpY2gKPiA+ID4gPiA+ID4gPiA+IHNob3VsZAo+ID4g PiA+ID4gPiA+ID4gcHJvYmFibHkgKGNvcnJlY3QgbWUgaWYgSSdtIHdyb25nKSBoYXBwZW4gbGF0 ZXIgaW4gdGhlIGNhbGwgY2hhaW4KPiA+ID4gPiA+ID4gPiA+IHRoYW4KPiA+ID4gPiA+ID4gPiA+ IElEL1ZCVVMgY2hhbmdlIG5vdGlmaWNhdGlvbiB0aW1lLgo+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ ID4gPiA+IEkgZG9uJ3QgdGhpbmsgaXQgaXMgY29ycmVjdCB0aGF0IHVkY19zdGFydCgpIGlzIHRy aWdnZXJlZCBieSBJRC9WQlVTCj4gPiA+ID4gPiA+ID4gZXZlbnRzLCBidXQgSSBkb24ndCBoYXZl IGFuIEFsbHdpbm5lciBwbGF0Zm9ybSB0byB2ZXJpZnkgdGhlIGNhbGxmbG93Lgo+ID4gPiA+ID4g PiAKPiA+ID4gPiA+ID4gWWVzIHlvdSdyZSByaWdodCwgSSBkaWRuJ3QgbWFrZSBteXNlbGYgdmVy eSBjbGVhciBoZXJlLiBJIGRpZG4ndAo+ID4gPiA+ID4gPiBpbnZlc3RpZ2F0ZSB0aGUgdWRjX3N0 YXJ0IGNhbGwgcGF0aCBtdWNoIHNpbmNlIGl0IHdhcyBhcHBhcmVudGx5IG5vdCB0aGUKPiA+ID4g PiA+ID4gY3VscHJpdC4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4gSGF2ZSB5b3UgdHJpZWQg dG8gbG9hZCB3aXRoIGEgZ2FkZ2V0IGRyaXZlcj8gV2hlbiBhIGdhZGdldCBmdW5jdGlvbiBpcwo+ ID4gPiA+ID4gPiA+IGJvdW5kIHRvIFVEQywgdWRjX3N0YXJ0KCkgaXMgdHJpZ2dlcmVkLCB3aGlj aCBpbiB0dXJuIGNhbGxzCj4gPiA+ID4gPiA+ID4gbXVzYl9zdGFydCgpLgo+ID4gPiA+ID4gPiAK PiA+ID4gPiA+ID4gSXQgZG9lcyB3b3JrIHVuZGVyIHRoYXQgc2NlbmFyaW8sIGFsdGhvdWdoIG15 IHVzZWQgY2FzZSBoZXJlIGlzIHVzaW5nCj4gPiA+ID4gPiA+IG11c2Igd2l0aCBEVUFMX1JPTEUg YnV0IG5vIGdhZGdldCBkcml2ZXIgbG9hZGVkLiBUaGF0IGl0LCBJIHdhbnQgdGhlCj4gPiA+ID4g PiA+IG11c2Jfc3RhcnQgY2FsbCB0byBvcmlnaW5hdGUgZnJvbSB0aGUgdmlydHVhbCBodWIsIG5v dCBmcm9tIHRoZSBnYWRnZXQKPiA+ID4gPiA+ID4gc2lkZS4KPiA+ID4gPiA+ID4gCj4gPiA+ID4g PiA+ID4gPiBJbiB0aGUgZm9ybWVyIGNhc2UsIG11c2Jfc3RhcnQgaXMgY2FsbGVkIGluIHRoZSBy b290IGNvbnRyb2xsZXIgaHViCj4gPiA+ID4gPiA+ID4gPiBjb250cm9sLCB3aGVuIHNldHRpbmcg dGhlIFVTQl9QT1JUX0ZFQVRfUE9XRVIgZmVhdHVyZS4gVGhpcyBsb29rcwo+ID4gPiA+ID4gPiA+ ID4gcGVyZmVjdGx5IGxlZ2l0IGFuZCBJTU8gdGhpcyBpcyB3aGVyZSBpdCBzaG91bGQgYmUgaW5p dGlhbGx5IGNhbGxpbmcKPiA+ID4gPiA+ID4gPiA+IG11c2Jfc3RhcnQgaW4gdGhlIGR1YWwgcm9s ZSBjYXNlLiBUaGUga2VybmVsIGlzIGluZGVlZCBzZXR0aW5nIHRoZQo+ID4gPiA+ID4gPiA+IAo+ ID4gPiA+ID4gPiA+IE5vIGFjdHVhbGx5LiBBIGR1YWwtcm9sZSBwb3J0IHNob3VsZCBiZSBpbiBi X2lkbGUgc3RhdGUgYnkgZGVmYXVsdCwgc28KPiA+ID4gPiA+ID4gPiBsb2dpY2FsbHkgYWxsIGFj dGlvbnMgc2hvdWxkIGdvIHRvIHRoZSBnYWRnZXQgcGF0aCB1bnRpbCB0aGUgcG9ydAo+ID4gPiA+ ID4gPiA+IHN3aXRjaGVzIHRvIGhvc3QgbW9kZS4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IEl0 IG1ha2VzIHNlbnNlIHRoYXQgdGhlIHBvcnQgc2hvdWxkIGJlIGluIGJfaWRsZSBzdGF0ZSBieSBk ZWZhdWx0LCBidXQKPiA+ID4gPiA+ID4gaGVyZSBpdCBmYWlscyB0byBzd2l0Y2ggdG8gaG9zdCBt b2RlIHdoZW4gdGhlIElEIHBpbiBkZXRlY3RzIHRoYXQgaXQKPiA+ID4gPiA+ID4gc2hvdWxkLiBP ciBkb2VzIGJfaWRsZSBzdGF0ZSBlbnRhaWwgdGhhdCBhIGdhZGdldCBtdXN0IGJlIGxvYWRlZCAo cGVyCj4gPiA+ID4gPiA+IHRoZSBVU0Igc3BlYyksIGFuZCB0aHVzIG5vdGhpbmcgc2hvdWxkIChl dmVyKSBoYXBwZW4gdW50aWwgdGhhdCBoYXBwZW5zPwo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g SSBmaW5kIGl0IHJlYWxseSBvZGQgdG8gbmVlZCBhIGdhZGdldCBkZXZpY2UgdG8gdHJpZ2dlciBo b3N0IG1vZGUuCj4gPiA+ID4gPiA+IFRoaXMgcGF0Y2ggZG9lcyBmaXggdGhlIGlzc3VlLCBidXQg SSBhbSBwdXp6bGVkIGFzIHRvIHdoeSBpdCBpcyBuZWVkZWQKPiA+ID4gPiA+ID4gaW4gdGhlIGZp cnN0IHBsYWNlLiBUaGUgY29tbWVudCBhYm92ZSBpdCBtZW50aW9ucyB0aGF0ICJJbiBPVEcgbW9k ZSB3ZQo+ID4gPiA+ID4gPiBoYXZlIHRvIHdhaXQgdW50aWwgd2UgbG9hZGVkIGEgZ2FkZ2V0LiBX ZSBkb24ndCByZWFsbHkgbmVlZCBhIGdhZGdldCBpZgo+ID4gPiA+ID4gPiB3ZSBvcGVyYXRlIGFz IGEgaG9zdCBidXQgd2Ugc2hvdWxkIG5vdCBzdGFydCBhIHNlc3Npb24gYXMgYSBkZXZpY2UKPiA+ ID4gPiA+ID4gd2l0aG91dCBhIGdhZGdldCBvciBlbHNlIHdlIGV4cGxvZGUuIiwgd2hpY2ggaXMg YXBwYXJlbnRseSBjb21wYXRpYmxlCj4gPiA+ID4gPiA+IHdpdGggbXkgdXNlIGNhc2U6IGEgZ2Fk Z2V0IGlzIG5vdCByZWFsbHkgbmVlZGVkIGFuZCBJJ20gbm90IHRyeWluZyB0bwo+ID4gPiA+ID4g PiBzdGFydCBhIHNlc3Npb24gYXMgYSBkZXZpY2Ugd2l0aG91dCBhIGdhZGdldCBsb2FkZWQuCj4g PiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBXaGF0IGRvIHlvdSB0aGluaz8KPiA+ID4gPiA+IAo+ID4g PiA+ID4gT2theSwgdGhpcyBjYW1lIGRvd24gdG8gYW4gYXJndW1lbnQgdGhhdCB3aGV0aGVyIHdl IHNob3VsZCByZXF1aXJlCj4gPiA+ID4gPiBsb2FkaW5nIGEgZ2FkZ2V0IGRyaXZlciBvbiBhIGR1 YWwtcm9sZSBwb3J0IHRvIHdvcmsgaW4gaG9zdCBtb2RlLAo+ID4gPiA+ID4gd2hpY2ggaXMgY3Vy cmVudGx5IHJlcXVpcmVkIG9uIG11c2Igc2luY2UgYSBsb25nIGxvbmcgdGltZSBhZ28uCj4gPiA+ ID4gPiAKPiA+ID4gPiA+IEkgdW5kZXJzdGFuZCB0aGUgcmVxdWlyZW1lbnQgaXMga2luZGEgdW5u ZWNlc3NhcnksIGJ1dCBzaW5jZSBpdCBhbHJlYWR5Cj4gPiA+ID4gPiBleGlzdHMgb24gbXVzYiBz dGFjayBmb3IgYSBsb25nIHRpbWUsIEkgZG9uJ3QgcGxhbiB0byBjaGFuZ2UgaXQuIEJlY2F1c2Ug SQo+ID4gPiA+ID4gY2Fubm90IHRoaW5rIG9mIGEgdXNlIGNhc2UgaW4gcmVhbCBwcm9kdWN0cyB0 aGF0IGRvZXNuJ3QgYXV0b21hdGljYWxseQo+ID4gPiA+ID4gbG9hZCBhIGdhZGdldCBmdW5jdGlv biBvbiB0aGUgZHVhbC1yb2xlIHBvcnQuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IElmIHlvdSBjYW4g ZXhwbGFpbiBhIHVzZSBjYXNlIGluIHJlYWwgd29ybGQgKG5vdCBhIGVuZ2luZWVyaW5nIGxhYikg dGhhdAo+ID4gPiA+ID4gdGhlIGdhZGdldCBkcml2ZXIgd2lsbCBub3QgYmUgbG9hZGVkIGF0IGxp bnV4IGJvb3RpbmcgdXAsIGJ1dCBsYXRlcgo+ID4gPiA+ID4gYmFzZWQgb24gdXNlcidzIGlucHV0 LCBJIHdpbGwgcmVjb25zaWRlciBteSBkZWNpc2lvbi4gVG8gcmVtb3ZlIHRoaXMKPiA+ID4gPiA+ IHJlcXVpcmVtZW50IGZyb20gbXVzYiBzdGFjaywgdGhlIHdvcmsgaXMgbW9yZSB0aGFuIHRoaXMg cGF0Y2guCj4gPiA+ID4gCj4gPiA+ID4gSSBoYXZlIG9uZSBmb3IgeW91OiB3ZSdyZSB3b3JraW5n IG9uIGEgZGV2aWNlIHRoYXQgYm9vdHMgcHJldHR5IGZhc3QsCj4gPiA+ID4gYW5kIHRoZXJlZm9y ZSBhcmUgcHVzaGluZyBhcyBtdWNoIHRoaW5ncyBhcyB3ZSBjYW4gdG8gbW9kdWxlcy4gSXQKPiA+ ID4gPiBpbmNsdWRlcyBnYWRnZXRzLCB0aGUgbXVzYiBkcml2ZXIgYW5kIGdsdWUsIGV0Yy4gVGhh dCBkb2Vzbid0IHNvdW5kCj4gPiA+ID4gd2F5IHZlcnkgZGlmZmVyZW50IGZyb20gd2hhdCBhIGdl bmVyaWMgZGlzdHJvIHdvdWxkIGRvIGFzIHdlbGwuCj4gPiA+ID4gCj4gPiA+ID4gQXQgYm9vdCwg dGhlIHZhcmlvdXMgbW9kdWxlcyBmb3IgdGhlIGhhcmR3YXJlIGFyZSBsb2FkZWQKPiA+ID4gPiBh dXRvbWF0aWNhbGx5OiB0aGUgbXVzYiBnbHVlLCB0aGUgbXVzYiBjb3JlLCBvdXIgVVNCIFBIWSwg ZXRjLiBXZSBlbmQKPiA+ID4gPiB1cCBpbiBhIHNpdHVhdGlvbiB3aGVyZSB0aGUgbXVzYiBkcml2 ZXIgaXMgbG9hZGVkIGFuZCByZXBvcnRlZCB0byB3b3JrCj4gPiA+ID4gcHJvcGVybHkuIFRoZSBV U0IgY2FibGUgdG8gdGhlIE9URyBwb3J0IChpbiBwZXJpcGhlcmFsKSBtaWdodCBvciBtaWdodAo+ ID4gPiA+IG5vdCBiZSBjb25uZWN0ZWQsIGl0J3Mga2luZCBvZiBpcnJlbGV2YW50Lgo+ID4gPiA+ IAo+ID4gPiA+IFRoZSBnYWRnZXRzLCBob3dldmVyLCBhcmUgbm90IGxvYWRlZCBhdXRvbWF0aWNh bGx5Lgo+ID4gPiA+IAo+ID4gPiA+IE5vdyBjb21lcyBhIHVzZXIgdGhhdCB3YW50cyB0byB1c2Ug bXVzYiBhcyBhIGhvc3QsIGFuZCBjb25uZWN0IGEKPiA+ID4gPiBwcm9wZXIgVVNCIGFkYXB0ZXIs IHRoYXQgd2lyZXMgdGhlIElEIHBpbiBwcm9wZXJseS4gSW4gb3VyIGNhc2UsIHRoZQo+ID4gPiA+ IHBoeSBkZXRlY3RzIGl0LCByZXBvcnRzIHRoZSBtb2RlIGNoYW5nZSwgYW5kIC4uLi4gbm90aGlu Zy4KPiA+ID4gPiAKPiA+ID4gPiBUaGF0IGRvZXNuJ3QgcmVhbGx5IGxvb2sgbGlrZSBhbiBlbmdp bmVlcmluZyBsYWIgc2V0dXAgdG8gbWUuCj4gPiA+IAo+ID4gPiBJIGFncmVlLCB0aGF0IHNvdW5k cyBsaWtlIGEgdmFsaWQgc2V0dXAuCj4gPiA+IAo+ID4gPiBBbHNvIHJlYWxpemUgdGhhdCBBbmRy b2lkIGlzIHB1c2hpbmcgdG8gaGF2ZSBhbGwgZHJpdmVycyBhcyBtb2R1bGVzLCBzbwo+ID4gPiB5 b3Ugd2lsbCBzdGFydCB0byBzZWUgYSB3aG9sZSBsb3QgbW9yZSBkZXZpY2VzIG91dCB0aGVyZSBi ZSBtb2R1bGFyCj4gPiA+IGluc3RlYWQgb2Ygc3RhdGljYWxseSBidWlsdCBrZXJuZWxzLiAgU28g aXNzdWVzIGxpa2UgdGhpcyBhcmUgZ29vZCB0bwo+ID4gPiByZXNvbHZlIDopCj4gPiAKPiA+IFRo aXMgaXNzdWUgaGVyZSBpcyBub3QgcmVsYXRlZCB0byBidWlsZGluZyBhbGwgZHJpdmVycyBhcyBt b2R1bGVzLiBUb2RheQo+ID4gd2UgYWxyZWFkeSBoYXZlIGFsbCBtdXNiIHJlbGF0ZWQgZHJpdmVy cyBpbmNsdWRpbmcgZ2FkZ2V0IGRyaXZlcnMgaW4KPiA+IG1vZHVsZXMuCj4gPiAKPiA+IFRoZSBp c3N1ZSBkaXNjdXNzZWQgaGVyZSBpcyB0aGF0IHdoZW4gbXVzYiBpcyBjb25maWd1cmVkIGluIGR1 YWwtcm9sZQo+ID4gbW9kZSAoZHJfbW9kZSA9ICdvdGcnIGluIGR0cyksIGEgZ2FkZ2V0IGRyaXZl ciBoYXMgdG8gYmUgYm91bmQgdG8gdGhlCj4gPiB1ZGMgdG8gbWFrZSBtdXNiIHdvcmtpbmcgaW4g aG9zdCBtb2RlLgo+ID4gCj4gPiBJIG5ldmVyIGRpc2FncmVlIGl0IGlzIG5vdCBpZGVhbCwgYnV0 IEkgY29uc2lkZXIgaXQgaXMgbWlub3IgLSBzaW5jZSB0aGUKPiA+IHBvcnQgaXMgY29uZmlndXJl ZCB0byBkdWFsLXJvbGUgbW9kZSwgaXQgaXMgaW50ZW5kZWQgdG8gd29yayBpbgo+ID4gcGVyaXBo ZXJhbCBtb2RlLCB0aGVuIHdoeSBub3QgYXV0b21hdGljYWxseSBsb2FkIHRoZSBnYWRnZXQgZHJp dmVyIHdoZW4KPiA+IGxpbnV4IGJvb3RzIHVwLgo+IAo+IEkgc3RpbGwgaGF2ZSBhIGZ1bmRhbWVu dGFsIGRpc2FncmVlbWVudCBoZXJlLCBhbmQgSSB0aGluayBpdCB3b3VsZCBiZQo+IGludGVyZXN0 aW5nIHRvIGRpc2N1c3MgaXQgd2l0aCBHcmVnIGluIHRoZSBsb29wLiBJIHRoaW5rIHRoYXQgd2hl dGhlcgo+IG9yIG5vdCB3ZSBsb2FkIGEgZ2FkZ2V0IGRyaXZlciB3aGVuIHRoZSBwb3J0IGlzIGRl Y2xhcmVkIGFzIE9URyBpcwo+IHBvbGljeSwgd2hpY2ggaXMgc2hvdWxkIGJlIGxlZnQgdG8gY29u ZmlnIG9yIHVzZXJzcGFjZSBhbmQgc2hvdWxkIG5vdAo+IGJlIGEgcHJlcmVxdWlzaXRlIGZvciB0 aGUgZHJpdmVyIHRvIHdvcmsuCj4gCj4gVG8gbWUsIE9URyBpbXBsaWVzIHRoYXQgaG9zdCBhbmQg cGVyaXBoZXJhbCBhcmUgc3VwcG9ydGVkIGVxdWFsbHksIGFuZAo+IG9uZSBzaG91bGQgbm90IHBy ZXZhaWwgb3ZlciB0aGUgb3RoZXIuCj4gCj4gSSdtIHdvbmRlcmluZyBpZiB0aGVyZSBhcmUgZ2Vu ZXJhbCBrZXJuZWwgcnVsZXMgdGhhdCBzaG91bGQgYXBwbHkgaGVyZSwKPiBpbmRlcGVuZGVudGx5 IGZyb20gdGhlIHRlY2huaWNhbCBhcmd1bWVudCByZWxhdGVkIHRvIHVzaW5nIGdhZGdldAo+IG1v ZHVsZXM/Cj4gCj4gPiBUbyBzdW1tYXJpZXMgbXkgY29tbWVudHMgb24gdGhpcyBhZ2Fpbiwgc2lu Y2UgaXQgaXMgbWlub3IgaW4gbXkgb3BpbmlvbiwKPiA+IEkgd29uJ3Qgc3BlbmQgdGltZSB0byBz b2x2ZSBpdCBteXNlbGYgKGluIGEgbmVhciBmdXR1cmUpLCBidXQgSSBhbSBtb3JlCj4gPiB0aGFu IGhhcHB5IHRvIHJldmlldyBhbmQgdGFrZSBhbnkgcGF0Y2ggd2hpY2ggc29sdmUgaXQuIAo+IAo+ IEl0IGlzIGRlZmluaXRlbHkgdmVyeSBtdWNoIGFwcHJlY2lhdGVkIHRoYXQgeW91IGFyZSBvcGVu IHRvIGFjY2VwdGluZyBhCj4gZml4IGZvciB0aGlzIGlzc3VlIGV2ZW4gdGhvdWdoIHlvdSBjb25z aWRlciBpdCBhIG5vbi1pc3N1ZSA6KQoKSSBiZWxpZXZlIGluIHByZXZpb3VzIGRpc2N1c3Npb24g SSBoYXZlIGV4cHJlc3NlZCBJIGFtIG9wZW4gdG8gYQpzb2x1dGlvbiA7KQoKYnV0IEkgZG9uJ3Qg Y29uc2lkZXIgIml0IGlzIGEgbm9uLWlzc3VlIiwgaXQgaXMgbWlub3IgaW4gbXkgb3BpbmlvbiwK dGhlbiBJIGRvbid0IGhhdmUgdGltZSB0byBzb2x2ZSBpdCBteXNlbGYuCgpSZWdhcmRzLAotQmlu Lgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A13D1C43381 for ; Fri, 22 Mar 2019 13:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 580BC20693 for ; Fri, 22 Mar 2019 13:36:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="sYRZgQ9R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728463AbfCVNgR (ORCPT ); Fri, 22 Mar 2019 09:36:17 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:35156 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728140AbfCVNgQ (ORCPT ); Fri, 22 Mar 2019 09:36:16 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2MDa9Pj000591; Fri, 22 Mar 2019 08:36:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1553261769; bh=y+px3sPCobbqYRiqgECaY9e4wgmkcmlJz90nxKoMnjQ=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=sYRZgQ9RJIgF9tRyBo2y3T19HnULZExvp1eXVNpn1XbWeWHfMZu4l+XkDIC5F4W3h D0QIVih27ei2J1ExU5gbTGiyp7+KDnz8G9j1ql8T819MYlNVKCem/ohebH6FRdr/YH y7RcLBPD0jI6y2RUjzNN3Z8PysU+SjIWCF3B9NYM= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2MDa9cT130584 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 22 Mar 2019 08:36:09 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 22 Mar 2019 08:36:08 -0500 Received: from dlep32.itg.ti.com (157.170.170.100) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5 via Frontend Transport; Fri, 22 Mar 2019 08:36:08 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x2MDa8uQ005444; Fri, 22 Mar 2019 08:36:08 -0500 Date: Fri, 22 Mar 2019 08:36:08 -0500 From: Bin Liu To: Paul Kocialkowski CC: Greg Kroah-Hartman , Maxime Ripard , , , Chen-Yu Tsai Subject: Re: [PATCH] usb: musb: Support gadget mode when the port is set to dual role Message-ID: <20190322133608.GE25852@uda0271908> Mail-Followup-To: Bin Liu , Paul Kocialkowski , Greg Kroah-Hartman , Maxime Ripard , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Chen-Yu Tsai References: <20180328215213.29538-1-contact@paulk.fr> <20180329092326.dayuccomq5zrywqo@flea> <1522324644.1746.19.camel@bootlin.com> <20180420142524.GB29011@uda0271908> <2db056d6f65ecbcdc4f31a37fe2e1b1ddfb93c87.camel@paulk.fr> <20180421143426.GA10632@LTA0271908.dhcp.ti.com> <20190321130133.zllt5pqbrhiecoch@flea> <20190321164138.GB11121@kroah.com> <20190322124622.GB25852@uda0271908> <8a5e34c5f24d63a7735ae86ccd340f6b5f66959d.camel@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8a5e34c5f24d63a7735ae86ccd340f6b5f66959d.camel@bootlin.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 02:10:01PM +0100, Paul Kocialkowski wrote: > Hi, > > Le vendredi 22 mars 2019 à 07:46 -0500, Bin Liu a écrit : > > On Thu, Mar 21, 2019 at 05:41:38PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 21, 2019 at 02:01:33PM +0100, Maxime Ripard wrote: > > > > Hi, > > > > > > > > I'm reviving this thread a bit, because I encountered this bug today. > > > > > > > > On Thu, Mar 21, 2019 at 11:02:10AM +0100, Bin Liu wrote: > > > > > On Sat, Apr 21, 2018 at 12:59:23PM +0200, Paul Kocialkowski wrote: > > > > > > Hi, > > > > > > > > > > > > Le vendredi 20 avril 2018 à 09:25 -0500, Bin Liu a écrit : > > > > > > > On Thu, Mar 29, 2018 at 01:57:24PM +0200, Paul Kocialkowski wrote: > > > > > > > > Hi, > > > > > > > > > > > > > > > > On Thu, 2018-03-29 at 11:23 +0200, Maxime Ripard wrote: > > > > > > > > > On Wed, Mar 28, 2018 at 11:52:13PM +0200, Paul Kocialkowski wrote: > > > > > > > > > > This allows dual-role ports to be reported as having gadget mode > > > > > > > > > > by > > > > > > > > > > the > > > > > > > > > > musb_has_gadget helper. This is required to enable MUSB at all > > > > > > > > > > with > > > > > > > > > > MUSB > > > > > > > > > > glue layers that set the port mode to MUSB_PORT_MODE_DUAL_ROLE > > > > > > > > > > at > > > > > > > > > > init. > > > > > > > > > > > > > > > > > > > > Most notably, this allows calling musb_start when needed in the > > > > > > > > > > virtual > > > > > > > > > > MUSB root HUB, regardless of whether the current mode should be > > > > > > > > > > gadget > > > > > > > > > > or host. > > > > > > > > > > > > > > > > > > > > This fixes USB OTG on Allwinner devices that I could test it > > > > > > > > > > with, > > > > > > > > > > mainly A20 devices. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Paul Kocialkowski > > > > > > > > > > > > > > > > > > Surely there's more to it than that. The gadget mode of A20 boards > > > > > > > > > have been working in the past, including when compiling with mUSB > > > > > > > > > setup as dual role. > > > > > > > > > > > > > > > > > > Is this a regression since a particular commit? Or is there > > > > > > > > > another, > > > > > > > > > deeper issue overlooked in the commit log? > > > > > > > > > > > > > > > > The root of the issue here is that musb_start is not called at any > > > > > > > > point > > > > > > > > without this patch. My understanding of the flow is the following: > > > > > > > > when > > > > > > > > the PHY detects that there was a VBUS/ID change, it will notify its > > > > > > > > listeners (mainly the musb sunxi glue layer). This will then > > > > > > > > schedule > > > > > > > > the driver's work (sunxi_musb_work), which does nothing since the > > > > > > > > SUNXI_MUSB_FL_ENABLED bit was never set. This bit is only set after > > > > > > > > calling sunxi_musb_enable, which is called from > > > > > > > > musb_platform_enable, > > > > > > > > that originates from musb_start. > > > > > > > > > > > > > > > > Currently I see two places where musb_start is called: > > > > > > > > * musb_virthub > > > > > > > > * musb_gadget > > > > > > > > > > > > > > > > In the latter case, it is in turn called from udc_start, which > > > > > > > > should > > > > > > > > probably (correct me if I'm wrong) happen later in the call chain > > > > > > > > than > > > > > > > > ID/VBUS change notification time. > > > > > > > > > > > > > > I don't think it is correct that udc_start() is triggered by ID/VBUS > > > > > > > events, but I don't have an Allwinner platform to verify the callflow. > > > > > > > > > > > > Yes you're right, I didn't make myself very clear here. I didn't > > > > > > investigate the udc_start call path much since it was apparently not the > > > > > > culprit. > > > > > > > > > > > > > Have you tried to load with a gadget driver? When a gadget function is > > > > > > > bound to UDC, udc_start() is triggered, which in turn calls > > > > > > > musb_start(). > > > > > > > > > > > > It does work under that scenario, although my used case here is using > > > > > > musb with DUAL_ROLE but no gadget driver loaded. That it, I want the > > > > > > musb_start call to originate from the virtual hub, not from the gadget > > > > > > side. > > > > > > > > > > > > > > In the former case, musb_start is called in the root controller hub > > > > > > > > control, when setting the USB_PORT_FEAT_POWER feature. This looks > > > > > > > > perfectly legit and IMO this is where it should be initially calling > > > > > > > > musb_start in the dual role case. The kernel is indeed setting the > > > > > > > > > > > > > > No actually. A dual-role port should be in b_idle state by default, so > > > > > > > logically all actions should go to the gadget path until the port > > > > > > > switches to host mode. > > > > > > > > > > > > It makes sense that the port should be in b_idle state by default, but > > > > > > here it fails to switch to host mode when the ID pin detects that it > > > > > > should. Or does b_idle state entail that a gadget must be loaded (per > > > > > > the USB spec), and thus nothing should (ever) happen until that happens? > > > > > > > > > > > > I find it really odd to need a gadget device to trigger host mode. > > > > > > This patch does fix the issue, but I am puzzled as to why it is needed > > > > > > in the first place. The comment above it mentions that "In OTG mode we > > > > > > have to wait until we loaded a gadget. We don't really need a gadget if > > > > > > we operate as a host but we should not start a session as a device > > > > > > without a gadget or else we explode.", which is apparently compatible > > > > > > with my use case: a gadget is not really needed and I'm not trying to > > > > > > start a session as a device without a gadget loaded. > > > > > > > > > > > > What do you think? > > > > > > > > > > Okay, this came down to an argument that whether we should require > > > > > loading a gadget driver on a dual-role port to work in host mode, > > > > > which is currently required on musb since a long long time ago. > > > > > > > > > > I understand the requirement is kinda unnecessary, but since it already > > > > > exists on musb stack for a long time, I don't plan to change it. Because I > > > > > cannot think of a use case in real products that doesn't automatically > > > > > load a gadget function on the dual-role port. > > > > > > > > > > If you can explain a use case in real world (not a engineering lab) that > > > > > the gadget driver will not be loaded at linux booting up, but later > > > > > based on user's input, I will reconsider my decision. To remove this > > > > > requirement from musb stack, the work is more than this patch. > > > > > > > > I have one for you: we're working on a device that boots pretty fast, > > > > and therefore are pushing as much things as we can to modules. It > > > > includes gadgets, the musb driver and glue, etc. That doesn't sound > > > > way very different from what a generic distro would do as well. > > > > > > > > At boot, the various modules for the hardware are loaded > > > > automatically: the musb glue, the musb core, our USB PHY, etc. We end > > > > up in a situation where the musb driver is loaded and reported to work > > > > properly. The USB cable to the OTG port (in peripheral) might or might > > > > not be connected, it's kind of irrelevant. > > > > > > > > The gadgets, however, are not loaded automatically. > > > > > > > > Now comes a user that wants to use musb as a host, and connect a > > > > proper USB adapter, that wires the ID pin properly. In our case, the > > > > phy detects it, reports the mode change, and .... nothing. > > > > > > > > That doesn't really look like an engineering lab setup to me. > > > > > > I agree, that sounds like a valid setup. > > > > > > Also realize that Android is pushing to have all drivers as modules, so > > > you will start to see a whole lot more devices out there be modular > > > instead of statically built kernels. So issues like this are good to > > > resolve :) > > > > This issue here is not related to building all drivers as modules. Today > > we already have all musb related drivers including gadget drivers in > > modules. > > > > The issue discussed here is that when musb is configured in dual-role > > mode (dr_mode = 'otg' in dts), a gadget driver has to be bound to the > > udc to make musb working in host mode. > > > > I never disagree it is not ideal, but I consider it is minor - since the > > port is configured to dual-role mode, it is intended to work in > > peripheral mode, then why not automatically load the gadget driver when > > linux boots up. > > I still have a fundamental disagreement here, and I think it would be > interesting to discuss it with Greg in the loop. I think that whether > or not we load a gadget driver when the port is declared as OTG is > policy, which is should be left to config or userspace and should not > be a prerequisite for the driver to work. > > To me, OTG implies that host and peripheral are supported equally, and > one should not prevail over the other. > > I'm wondering if there are general kernel rules that should apply here, > independently from the technical argument related to using gadget > modules? > > > To summaries my comments on this again, since it is minor in my opinion, > > I won't spend time to solve it myself (in a near future), but I am more > > than happy to review and take any patch which solve it. > > It is definitely very much appreciated that you are open to accepting a > fix for this issue even though you consider it a non-issue :) I believe in previous discussion I have expressed I am open to a solution ;) but I don't consider "it is a non-issue", it is minor in my opinion, then I don't have time to solve it myself. Regards, -Bin.