All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kumar Valsan, Prathap" <prathap.kumar.valsan@intel.com>
To: chris@chris-wilson.co.uk
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation
Date: Fri, 22 Mar 2019 09:58:52 -0400	[thread overview]
Message-ID: <20190322135852.GH30702@intel.com> (raw)
In-Reply-To: <155323914179.26447.9281931190004143408@skylake-alporthouse-com>

On Fri, Mar 22, 2019 at 07:19:01AM +0000, Chris Wilson wrote:
> Quoting Prathap Kumar Valsan (2019-03-21 23:06:13)
> > Basic test don't take long to complete, so allow basic test to
> > run on simulation.
> > ---
> >  tests/i915/gem_exec_gttfill.c | 13 ++++++++-----
> >  1 file changed, 8 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tests/i915/gem_exec_gttfill.c b/tests/i915/gem_exec_gttfill.c
> > index efd612bb..92c3cf62 100644
> > --- a/tests/i915/gem_exec_gttfill.c
> > +++ b/tests/i915/gem_exec_gttfill.c
> > @@ -144,7 +144,8 @@ static void fillgtt(int fd, unsigned ring, int timeout)
> >         count = size / BATCH_SIZE + 1;
> >         igt_debug("Using %'d batches to fill %'llu aperture on %d engines\n",
> >                   count, (long long)size, nengine);
> > -       intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> > +       if (!igt_run_in_simulation())
> > +               intel_require_memory(count, BATCH_SIZE, CHECK_RAM);
> 
> No. That is too ugly. You are basically saying that memory limits don't
> matter for simulation -- unless the reader is aware of the convoluted
> story in the setup and that we've previously marked as anything that
> requires to check memory is not suitable for the slow simulator.
> 
Chris,
gem_exec_gtfill@basic has been marked as a test that we need to run on
simulation. https://jira.devtools.intel.com/browse/VLK-1649
This is the intention behind trying to enable this test.

Will follow-up in the Jira to understand what we need to run for this
test.
> Why do you want to run this on the simulator? Write that test.
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-03-22 13:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 23:06 [igt-dev] [PATCH i-g-t] i915/gem_exec_gttfill: Run basic test on simulation Prathap Kumar Valsan
2019-03-21 23:23 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-22  7:19 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-03-22 13:58   ` Kumar Valsan, Prathap [this message]
2019-03-22 13:51     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322135852.GH30702@intel.com \
    --to=prathap.kumar.valsan@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.