All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: josh@joshtriplett.org, rostedt@goodmis.org,
	mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
	joel@joelfernandes.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] rcu/tree: Make rcu_check_gp_start_stall static
Date: Fri, 22 Mar 2019 09:20:52 -0700	[thread overview]
Message-ID: <20190322162052.GN4102@linux.ibm.com> (raw)
In-Reply-To: <20190322142659.12368-1-yuehaibing@huawei.com>

On Fri, Mar 22, 2019 at 10:26:59PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> 
> Fix sparse warning:
> 
> kernel/rcu/tree.c:2643:1: warning:
>  symbol 'rcu_check_gp_start_stall' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Good eyes!

But someone beat you to this.  Please see branch "dev" of -rcu:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git

							Thanx, Paul

> ---
>  kernel/rcu/tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index acd6ccf..ed3ef40 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2639,7 +2639,7 @@ EXPORT_SYMBOL_GPL(rcu_force_quiescent_state);
>   * This function checks for grace-period requests that fail to motivate
>   * RCU to come out of its idle mode.
>   */
> -void
> +static void
>  rcu_check_gp_start_stall(struct rcu_node *rnp, struct rcu_data *rdp,
>  			 const unsigned long gpssdelay)
>  {
> -- 
> 2.7.0
> 
> 


      reply	other threads:[~2019-03-22 16:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 14:26 [PATCH -next] rcu/tree: Make rcu_check_gp_start_stall static Yue Haibing
2019-03-22 16:20 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322162052.GN4102@linux.ibm.com \
    --to=paulmck@linux.ibm.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=rostedt@goodmis.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.