From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Disable C3 when enabling vblank interrupts on i945gm Date: Sat, 23 Mar 2019 01:55:34 +0200 Message-ID: <20190322235534.GM3888@intel.com> References: <20190322180804.3300-1-ville.syrjala@linux.intel.com> <155328891458.15930.7846778955426270611@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A23A891EB for ; Fri, 22 Mar 2019 23:55:38 +0000 (UTC) Content-Disposition: inline In-Reply-To: <155328891458.15930.7846778955426270611@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMjIsIDIwMTkgYXQgMDk6MDg6MzVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOS0wMy0yMiAxODowODowMykKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IFRoZSBBR1BCVVNZIHRoaW5nIGRvZXNuJ3Qgd29yayBvbiBpOTQ1Z20gYW55bW9yZS4gVGhp cyBtZWFucwo+ID4gdGhlIGdtY2ggaXMgaW5jYXBhYmxlIG9mIHdha2luZyB0aGUgQ1BVIGZyb20g QzMgd2hlbiBhbiBpbnRlcnJ1cHQKPiA+IGlzIGdlbmVyYXRlZC4gVGhlIGludGVycnVwdHMganVz dCBnZXQgcG9zdHBvbmVkIGluZGVmaW5pdGVseSB1bnRpbAo+ID4gc29tZXRoaW5nIHdha2VzIHVw IHRoZSBDUFUuIFRoaXMgaXMgcmF0aGVyIGFubm95aW5nIGZvciB2YmxhbmsKPiA+IGludGVycnVw dHMgYXMgd2UgYXJlIHVuYWJsZSB0byBtYWludGFpbiBhIHN0ZWFkeSBmcmFtZXJhdGUKPiA+IHVu bGVzcyB0aGUgbWFjaGluZSBpcyBzdWZmaWNpZW50bHkgbG9hZGVkIHRvIHN0YXkgb3V0IG9mIEMz Lgo+ID4gCj4gPiBUbyBjb21iYXQgdGhpcyBsZXQncyB1c2UgcG1fcW9zIHRvIHByZXZlbnQgQzMg d2hlbmV2ZXIgdmJsYW5rCj4gPiBpbnRlcnJ1cHRzIGFyZSBlbmFibGVkLiBUbyBtYWludGFpbiBy ZWFzb25hYmxlIGFtb3VudCBvZiBwb3dlcnNhdmluZwo+ID4gd2Ugd2lsbCBhdHRlbXB0IHRvIGxp bWl0IHRoaXMgdG8gQzMgb25seSB3aGlsZSBsZWF2aW5nIEMxIGFuZCBDMgo+ID4gZW5hYmxlZC4K PiAKPiBJbnRlcmVzdGluZyBjb21wcm9taXNlLiBGcmFua2x5LCBJIGhhZCBjb25zaWRlcmVkIHBt X3FvcyBpbiBhbgo+IGFsbC1vci1ub3RoaW5nIGFwcHJvYWNoLCBwYXJ0bHkgYmVjYXVzZSBmaW5k aW5nIHRoZSBDIHRyYW5zaXRpb25zIGlzIGEKPiBiaXQgb3BhcXVlLgo+ICAKPiA+IEJ1Z3ppbGxh OiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDM2NAo+ID4g U2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAgOCAr KysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIHwgODggKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCA5NiBpbnNlcnRpb25z KCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gaW5kZXggZjcyM2IxNTUyN2Y4 Li4wYzczNmY4Y2ExYjIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBAQCAt MjA0Miw2ICsyMDQyLDE0IEBAIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlIHsKPiA+ICAgICAgICAg ICAgICAgICBzdHJ1Y3QgaTkxNV92bWEgKnNjcmF0Y2g7Cj4gPiAgICAgICAgIH0gZ3Q7Cj4gPiAg Cj4gPiArICAgICAgIC8qIEZvciBpOTQ1Z20gdmJsYW5rIGlycSB2cy4gQzMgd29ya2Fyb3VuZCAq Lwo+ID4gKyAgICAgICBzdHJ1Y3Qgewo+ID4gKyAgICAgICAgICAgICAgIHN0cnVjdCB3b3JrX3N0 cnVjdCB3b3JrOwo+ID4gKyAgICAgICAgICAgICAgIHN0cnVjdCBwbV9xb3NfcmVxdWVzdCBwbV9x b3M7Cj4gPiArICAgICAgICAgICAgICAgdTggYzNfZGlzYWJsZV9sYXRlbmN5Owo+IAo+IE9rLCBs b29rcyBhIGJpdCB0aWdodCwgYnV0IGNoZWNrcyBvdXQuCj4gCj4gPiArICAgICAgICAgICAgICAg dTggZW5hYmxlZDsKPiA+ICsgICAgICAgfSBpOTQ1Z21fdmJsYW5rOwo+ID4gKwo+ID4gICAgICAg ICAvKiBwZXJmb3JtIFBIWSBzdGF0ZSBzYW5pdHkgY2hlY2tzPyAqLwo+ID4gICAgICAgICBib29s IGNodl9waHlfYXNzZXJ0WzJdOwo+ID4gIAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiBp bmRleCAyZjc4ODI5MWNmZTAuLjMzMzg2ZjBhY2FiMyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfaXJxLmMKPiA+IEBAIC0zMCw2ICszMCw3IEBACj4gPiAgCj4gPiAgI2luY2x1ZGUgPGxpbnV4 L3N5c3JxLmg+Cj4gPiAgI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4KPiA+ICsjaW5jbHVkZSA8bGlu dXgvY3B1aWRsZS5oPgo+ID4gICNpbmNsdWRlIDxsaW51eC9jaXJjX2J1Zi5oPgo+ID4gICNpbmNs dWRlIDxkcm0vZHJtX2lycS5oPgo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX2Rydi5oPgo+ID4gQEAg LTMxMzEsNiArMzEzMiwxNiBAQCBzdGF0aWMgaW50IGk4eHhfZW5hYmxlX3ZibGFuayhzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiA+ICAgICAgICAgcmV0dXJuIDA7 Cj4gPiAgfQo+ID4gIAo+ID4gK3N0YXRpYyBpbnQgaTk0NWdtX2VuYWJsZV92Ymxhbmsoc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gPiArewo+ID4gKyAgICAgICBz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gPiArCj4g PiArICAgICAgIGlmIChkZXZfcHJpdi0+aTk0NWdtX3ZibGFuay5lbmFibGVkKysgPT0gMCkKPiA+ ICsgICAgICAgICAgICAgICBzY2hlZHVsZV93b3JrKCZkZXZfcHJpdi0+aTk0NWdtX3ZibGFuay53 b3JrKTsKPiAKPiBJIHdhcyB0aGlua2luZyB1OCwgaXNuJ3QgdGhhdCBhIGJpdCBkYW5nZXJvdXMu IEJ1dCB0aGUgbWF4IGNvdW50ZXIgaGVyZQo+IHNob3VsZCBiZSBudW1fcGlwZXMuIEhtbSwgaXMg dGhlIHZibGFuayBzcGlubG9jayBsb2NhbCB0byBhIHBpcGU/IE5vcGUsCj4gZGV2LT52YmxfbG9j ay4KPiAKPiA+ICsKPiA+ICsgICAgICAgcmV0dXJuIGk4eHhfZW5hYmxlX3ZibGFuayhkZXYsIHBp cGUpOwo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgaW50IGk5NjVfZW5hYmxlX3ZibGFuayhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiA+ICB7Cj4gPiAgICAgICAg IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+IEBA IC0zMTk1LDYgKzMyMDYsMTYgQEAgc3RhdGljIHZvaWQgaTh4eF9kaXNhYmxlX3ZibGFuayhzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiA+ICAgICAgICAgc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYtPmlycV9sb2NrLCBpcnFmbGFncyk7Cj4gPiAgfQo+ ID4gIAo+ID4gK3N0YXRpYyB2b2lkIGk5NDVnbV9kaXNhYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiA+ICt7Cj4gPiArICAgICAgIHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiA+ICsKPiA+ICsgICAg ICAgaTh4eF9kaXNhYmxlX3ZibGFuayhkZXYsIHBpcGUpOwo+ID4gKwo+ID4gKyAgICAgICBpZiAo LS1kZXZfcHJpdi0+aTk0NWdtX3ZibGFuay5lbmFibGVkID09IDApCj4gPiArICAgICAgICAgICAg ICAgc2NoZWR1bGVfd29yaygmZGV2X3ByaXYtPmk5NDVnbV92Ymxhbmsud29yayk7Cj4gPiArfQo+ ID4gKwo+ID4gIHN0YXRpYyB2b2lkIGk5NjVfZGlzYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gPiAgewo+ID4gICAgICAgICBzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRldik7Cj4gPiBAQCAtMzIyOCw2ICsz MjQ5LDYwIEBAIHN0YXRpYyB2b2lkIGdlbjhfZGlzYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZp Y2UgKmRldiwgdW5zaWduZWQgaW50IHBpcGUpCj4gPiAgICAgICAgIHNwaW5fdW5sb2NrX2lycXJl c3RvcmUoJmRldl9wcml2LT5pcnFfbG9jaywgaXJxZmxhZ3MpOwo+ID4gIH0KPiA+ICAKPiA+ICtz dGF0aWMgdm9pZCBpOTQ1Z21fdmJsYW5rX3dvcmtfZnVuYyhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndv cmspCj4gPiArewo+ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PQo+ID4gKyAgICAgICAgICAgICAgIGNvbnRhaW5lcl9vZih3b3JrLCBzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSwgaTk0NWdtX3ZibGFuay53b3JrKTsKPiA+ICsKPiA+ICsgICAgICAgLyoKPiA+ICsg ICAgICAgICogVmJsYW5rIGludGVycnVwdHMgZmFpbCB0byB3YWtlIHVwIHRoZSBkZXZpY2UgZnJv bSBDMywKPiA+ICsgICAgICAgICogaGVuY2Ugd2Ugd2FudCB0byBwcmV2ZW50IEMzIHVzYWdlIHdo aWxlIHZibGFuayBpbnRlcnJ1cHRzCj4gPiArICAgICAgICAqIGFyZSBlbmFibGVkLgo+ID4gKyAg ICAgICAgKi8KPiA+ICsgICAgICAgcG1fcW9zX3VwZGF0ZV9yZXF1ZXN0KCZkZXZfcHJpdi0+aTk0 NWdtX3ZibGFuay5wbV9xb3MsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXZf cHJpdi0+aTk0NWdtX3ZibGFuay5lbmFibGVkID8KPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGRldl9wcml2LT5pOTQ1Z21fdmJsYW5rLmMzX2Rpc2FibGVfbGF0ZW5jeSA6Cj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQTV9RT1NfREVGQVVMVF9WQUxVRSk7Cj4gCj4g V29ya2VyIGlzIHJlcXVpcmVkIGFzIHRoZSB1cGRhdGUgbWF5IGJsb2NrLgo+IAo+IEknZCBwcmVm ZXIgdGhhdCBhcyBSRUFEX09OQ0UoZGV2X3ByaXYtPmk5NDVnbV92YmxhbmsuZW5hYmxlZCkKClll YWgsIHRoYXQgZG9lcyBzZWVtIGFwcHJvcHJpYXRlLgoKPiAKPiA+ICt9Cj4gPiArCj4gPiArc3Rh dGljIGludCBjc3RhdGVfZGlzYWJsZV9sYXRlbmN5KGNvbnN0IGNoYXIgKm5hbWUpCj4gPiArewo+ ID4gKyAgICAgICBjb25zdCBzdHJ1Y3QgY3B1aWRsZV9kcml2ZXIgKmRydjsKPiA+ICsgICAgICAg aW50IGk7Cj4gPiArCj4gPiArICAgICAgIGRydiA9IGNwdWlkbGVfZ2V0X2RyaXZlcigpOwo+ID4g KyAgICAgICBpZiAoIWRydikKPiA+ICsgICAgICAgICAgICAgICByZXR1cm4gMDsKPiA+ICsKPiA+ ICsgICAgICAgZm9yIChpID0gMDsgaSA8IGRydi0+c3RhdGVfY291bnQ7IGkrKykgewo+ID4gKyAg ICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBjcHVpZGxlX3N0YXRlICpzdGF0ZSA9ICZkcnYtPnN0 YXRlc1tpXTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICBpZiAoIXN0cmNtcChzdGF0ZS0+bmFt ZSwgbmFtZSkpCj4gPiArICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gc3RhdGUtPmV4aXRf bGF0ZW5jeSA/Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5leGl0 X2xhdGVuY3kgLSAxIDogMDsKPiA+ICsgICAgICAgfQo+IAo+IE1pbmQgaWYgSSBzYXkgeXVjaz8K CkdvIHJpZ2h0IGFoZWFkLgoKPiAKPiBXaWxsIG9ubHkgd29yayB3aXRoIHRoZSBpbnRlbF9pZGxl IGRyaXZlci4KCmFjcGlfaWRsZSBoZXJlLiBJIGRvdWJ0IHRoZXJlIGFyZSA5NDVnbSBzeXN0ZW1z IHdpdGggYSBDUFUgZmFuY3kgZW5vdWdoCmZvciBpbnRlbF9pZGxlIHRvIHBpY2sgdXAuIEknZCBs aWtlIHRoYXQgZm9yIG15IGk5NjVnbSBhY3R1YWxseSB3aGVyZQp0aGUgc2lsbHkgYWNwaSB0YWJs ZXMgZG9uJ3QgbGV0IG1lIGhhdmUgQzQgdW5sZXNzIGl0J3MgcnVubmluZyBvbgpiYXR0ZXJ5LgoK PiBBbmQgaWYgbm90IHByZXNlbnQsIHdlIGZvcmNlCj4gdGhlIHN5c3RlbSB0byBub3Qgc2xlZXAg d2hpbGUgdmJsYW5rcyBhcmUgdGlja2luZyBvdmVyLgoKSSBndWVzcyB3ZSBjb3VsZCBqdXN0IHNr aXAgaXQgYWxsIGlmIHRoZSBpZGxlIGRyaXZlciBpcyBmdW5reSwKYnV0IEkgd291bGRuJ3QgZXhw ZWN0IG11Y2ggcG93ZXIgc2F2aW5ncyBpbiB0aGF0IGNhc2UgYW55d2F5LgoKPiAKPiBBbmQgaXQg aXMgZXhpdF9sYXRlbmN5IHRoYXQgaXMgY29tcGFyZWQgYWdhaW5zdCB0aGUgcW9zIHJlcXVlc3Qu Cj4gCj4gT2suIEl0IGRvZXMgd2hhdCBpdCBzYXlzIG9uIHRoZSB0aW4uCj4gCj4gT25lIG9mIHRo ZSByZWFzb25zIEkndmUgaGVzaXRhdGVkIGluIHRoZSBwYXN0IHdhcyB0aGF0IEkgY29uc2lkZXJl ZAo+IHZibGFua3MgYXMgYSBiYWNrZ3JvdW5kIGhlYXJ0YmVhdCB3aGlsZSB0aGUgc3lzdGVtIGlz IGFjdGl2ZSBhbmQgcHJldHR5Cj4gbXVjaCBjb25zdGFudGx5IG9uIHdoaWxlIHRoZSBzY3JlZW4g aXMuIEhvd2V2ZXIsIEkgc3VwcG9zZSB0aGF0IGlzIHRydWUKPiAoYW5kIGlzIGV2aWRlbmNlZCBi eSByZWNlbnQgc3lzdGVtcyB0aGF0IGRvIG5vdCBzbGVlcCB3aGlsZSB0aGUgc2NyZWVucwo+IGFy ZSBvbiwgYXQgbGVhc3Qgbm90IHdpdGggYW4gYWN0aXZlIGxpbmspLgo+IAo+IFRoZSB3b3JzdCB0 aGF0IGNhbiBoYXBwZW4gaXMgc29tZW9uZSBjb21wbGFpbnMgYWJvdXQgYSBob3QgbGFwdG9wLCBh bmQKPiB0aGUgcmVtZWR5IGlzIHNpbXBsZSBpZiB3ZSBkb24ndCBzdWNjZWVkIGluIGtpbGxpbmcg aXQgZmlyc3QsCgpOb3cgeW91IG1hZGUgbWUgZG91YnQgaG93IGNvc3RseSBkaXNhYmxpbmcgQzMg YWN0dWFsbHkgaXMuClNvIEkgaGFkIHRvIG1lYXN1cmUgaXQuIFRoZSBjcHUgaXMgYSBjb3JlIGR1 byBzb21ldGhpbmcgb3IKYW5vdGhlci4KCklkbGUgc3lzdGVtIHdpdGggdGhlIGRpc3BsYXkgb2Zm IHNob3dzIGEgZGlmZmVyZW5jZSBvZiB+MlcsIHdoaWNoCmlzIHF1aXRlIGEgYml0IG1vcmUgdGhh biBJIHdhcyBleHBlY3RpbmcgdGJoLiBUaGF0J3MgaW4gdGhlIGJhbGxwYXJrCm9mICsyNSUuIEZv cnR1bmF0ZWx5IHdlIHdvdWxkbid0IGhpdCB0aGlzIHNpbmNlIG5vIHZibGFua3Mgd2l0aCBkaXNw bGF5Cm9mZi4KCldpdGggdGhlIGRpc3BsYXkgb24gdGhlIGRpZmZlcmVuY2UgZHJvcHMgdG8gfjAu N1csIG9yIHBlcmhhcHMgYXJvdW5kCis1JSB3aXRoIG1pbmltdW0gYmFja2xpZ2h0IGxldmVsLiBO b3QgZ3JlYXQgYnV0IG1heWJlIG5vdCBhIHRvdGFsCmRpc2FzdGVyLgoKQWN0dWFsbHkgaGF2aW5n IHZibGFuayBpbnRlcnJ1cHRzIHRpY2tpbmcgZGlkbid0IG1ha2UgYSBzaWduaWZpY2FudApkaWZm ZXJlbmNlIHRvIHRoZSBDMiBvciBDMyBudW1iZXJzLCBidXQgb2YgY291cnNlIHdlIGNhbid0IGVu dGlyZWx5CnRydXN0IHRoZSBDMyBudW1iZXJzIG9yIGVsc2Ugd2Ugd291bGRuJ3QgYmUgaGVyZS4K Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4