From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc3: Softdep for GBit Ethernet on Odroid XU4 From: Greg Kroah-Hartman Message-Id: <20190323060541.GA28292@kroah.com> Date: Sat, 23 Mar 2019 07:05:41 +0100 To: Jochen Sprickerhof Cc: Marek Szyprowski , Roger Quadros , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I List-ID: T24gRnJpLCBNYXIgMjIsIDIwMTkgYXQgMDk6NDE6NTdQTSArMDEwMCwgSm9jaGVuIFNwcmlja2Vy aG9mIHdyb3RlOgo+IEhpIEdyZWcsCj4gCj4gKiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBs aW51eGZvdW5kYXRpb24ub3JnPiBbMjAxOS0wMy0yMiAwNjozN106Cj4gPiBPbiBUaHUsIE1hciAy MSwgMjAxOSBhdCAwOToyMzowM1BNICswMTAwLCBKb2NoZW4gU3ByaWNrZXJob2Ygd3JvdGU6Cj4g PiA+IFRoaXMgYWRkcyBhIHNvZnQgZGVwZW5kZW5jeSB0byB0aGUgZHdjMyBtb2R1bGUgdG8gbG9h ZCBpdCBhZnRlcgo+ID4gPiB4aGNpLXBsYXQgYXMgcHJvcG9zZWQgaW46Cj4gPiA+IAo+ID4gPiBo dHRwczovL21hcmMuaW5mby8/bD1saW51eC11c2ImbT0xNTUyMzAyNzIwMjI2MDMmdz0yCj4gPiA+ IAo+ID4gPiBPbGQgYmVoYXZpb3VyOgo+ID4gPiAKPiA+ID4gJCBsc3VzYiAtdAo+ID4gPiAvOiAg QnVzIDA2LlBvcnQgMTogRGV2IDEsIENsYXNzPXJvb3RfaHViLCBEcml2ZXI9eGhjaS1oY2QvMXAs IDUwMDBNCj4gPiA+IC86ICBCdXMgMDUuUG9ydCAxOiBEZXYgMSwgQ2xhc3M9cm9vdF9odWIsIERy aXZlcj14aGNpLWhjZC8xcCwgNDgwTQo+ID4gPiAgIHxfXyBQb3J0IDE6IERldiAyLCBJZiAwLCBD bGFzcz1WZW5kb3IgU3BlY2lmaWMgQ2xhc3MsIERyaXZlcj1yODE1MiwgNDgwTQo+ID4gPiAKPiA+ ID4gTmV3IGJlaGF2aW91cjoKPiA+ID4gCj4gPiA+ICQgbHN1c2IgLXQKPiA+ID4gLzogIEJ1cyAw Ni5Qb3J0IDE6IERldiAxLCBDbGFzcz1yb290X2h1YiwgRHJpdmVyPXhoY2ktaGNkLzFwLCA1MDAw TQo+ID4gPiAgIHxfXyBQb3J0IDE6IERldiAyLCBJZiAwLCBDbGFzcz1WZW5kb3IgU3BlY2lmaWMg Q2xhc3MsIERyaXZlcj1yODE1MiwgNTAwME0KPiA+ID4gCj4gPiA+IFRlc3RlZCBvbiBEZWJpYW4g dW5zdGFibGUgdXNpbmcgTGludXggNC4xOS4yOS4KPiA+ID4gCj4gPiA+IE5vdGUsIHRoaXMgbmVl ZHMgYSBoYXJkIHJlc2V0IHdoZW4gY29taW5nIGZyb20gYW4gdW5wYXRjaGVkIGtlcm5lbC4KPiA+ ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEpvY2hlbiBTcHJpY2tlcmhvZiA8Z2l0QGpvY2hlbi5z cHJpY2tlcmhvZi5kZT4KPiA+ID4gLS0tCj4gPiA+IGRyaXZlcnMvdXNiL2R3YzMvY29yZS5jIHwg MSArCj4gPiA+IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+ID4gPiAKPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2R3YzMvY29yZS5jIGIvZHJpdmVycy91c2IvZHdjMy9jb3Jl LmMKPiA+ID4gaW5kZXggMTAzODA3NTg3ZGM2Li45MDE3ZTRlZDlkOTkgMTAwNjQ0Cj4gPiA+IC0t LSBhL2RyaXZlcnMvdXNiL2R3YzMvY29yZS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvdXNiL2R3YzMv Y29yZS5jCj4gPiA+IEBAIC0xNzQ2LDMgKzE3NDYsNCBAQCBNT0RVTEVfQUxJQVMoInBsYXRmb3Jt OmR3YzMiKTsKPiA+ID4gTU9EVUxFX0FVVEhPUigiRmVsaXBlIEJhbGJpIDxiYWxiaUB0aS5jb20+ Iik7Cj4gPiA+IE1PRFVMRV9MSUNFTlNFKCJHUEwgdjIiKTsKPiA+ID4gTU9EVUxFX0RFU0NSSVBU SU9OKCJEZXNpZ25XYXJlIFVTQjMgRFJEIENvbnRyb2xsZXIgRHJpdmVyIik7Cj4gPiA+ICtNT0RV TEVfU09GVERFUCgicHJlOiB4aGNpX3BsYXRfaGNkIik7Cj4gPiAKPiA+IAo+ID4gWW91ciBwYXRj aCBpcyBjb3JydXB0ZWQgYW5kIGNhbiBub3QgYmUgYXBwbGllZCA6KAo+IAo+IAo+IEknbSBzb3Jy eSB0byBoZWFyIHRoYXQuIEZvciBtZSB0aGlzIHdvcmtzOgo+IAo+IGdpdCBjbG9uZSBnaXQ6Ly9n aXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0 Cj4gY2QgbGludXgKPiBjdXJsICJodHRwczovL2xvcmUua2VybmVsLm9yZy9sa21sLzIwMTkwMzIx MjAyMzAzLkdBMTM5OUB2aXMvcmF3IiB8IGdpdCBhbSAtCj4gCj4gQnV0IEkgZm91bmQgc29tZSBh cmNoaXZlcyB0aGF0IHNlZW1zIHRvIGhhdmUgZmlkZGxlZCB3aXRoIHRoZSBDb250ZW50LVR5cGUK PiBvZiBteSBzaWduZWQgbWFpbCwgbWFraW5nIGl0IGZhaWwuIENhbiB5b3Ugc2VuZCBtb3JlIGlu Zm9ybWF0aW9uIGFib3V0IHRoZQo+IGNvcnJ1cHRpb24/CgpNYXliZSBpdCB3b3JrcyBpZiBJIGxv b2sgYXQgdGhlIHJhdyBlbWFpbCwgYnV0IGp1c3QgZnJvbSB0aGUgYWJvdmUgdGV4dCwKeW91ciBs ZWFkaW5nICcgJyBjaGFyYWN0ZXJzIGFyZSBkcm9wcGVkLCBzbyB0aGF0J3Mgd2h5IEkgZW1haWxl ZCB5b3UKdGhpcy4KCkxldCBtZSBnbyBsb29rIGF0IHRoZSBtZXNzYWdlIEkgcmVjZWl2ZWQuLi4K CkFoLCB5ZWFoLCB0aGUgcmF3IG1lc3NhZ2UgaXMgY29ycmVjdCwgaXQganVzdCBoYXMgYSBncGcg c2lnbmF0dXJlIHdoaWNoCm1lc3NlZCB3aXRoIG15IGVtYWlsIGNsaWVudCdzIGRpc3BsYXkgc29t ZWhvdyBhbmQgZHJvcHBlZCB0aG9zZSBsZWFkaW5nCnNwYWNlcy4KClNvcnJ5IGZvciB0aGUgbm9p c2UsIGFsbCBpcyBnb29kLgoKZ3JlZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 668D0C43381 for ; Sat, 23 Mar 2019 06:05:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1972F21900 for ; Sat, 23 Mar 2019 06:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553321147; bh=ois9Ll/iXGB9ZZtF3PYqXWCudQUHzRJ/sHoSH3rgl+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GU2cOfjvNE/3ckKbrpILUtFGo3rqMwj3XGSokx2hbBWx+ZBbHrJqhFon2x3g/MaUU TNWw0sSxYklQv13nF3HTXwXry7nweRxg13kwKkaD7hwJNM0r7TySLsqUBxHjVqLlff 2jWn6hSbVlrlozrzABG+Z1lhZYdDzP5G6D4K11dA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726118AbfCWGFp (ORCPT ); Sat, 23 Mar 2019 02:05:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:55722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbfCWGFp (ORCPT ); Sat, 23 Mar 2019 02:05:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6D8D218E2; Sat, 23 Mar 2019 06:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553321144; bh=ois9Ll/iXGB9ZZtF3PYqXWCudQUHzRJ/sHoSH3rgl+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jPOLMAgkAQAqIYBUNIo7SeLkV9/d+e2mpTk1nyHv+LWHjH8ElTPGoTYcExN6gRbJ7 iuEYSn5zb6/63zY6+vnoOfpXzTtkTMOWVELtKvXJRFtnVQkb4MwnLx6LiXL8xqjlVh 1PYGTgX018bA8nv3mWszXkDUo0gvovehdR3wKPuw= Date: Sat, 23 Mar 2019 07:05:41 +0100 From: Greg Kroah-Hartman To: Jochen Sprickerhof Cc: Marek Szyprowski , Roger Quadros , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I Subject: Re: [PATCH] usb: dwc3: Softdep for GBit Ethernet on Odroid XU4 Message-ID: <20190323060541.GA28292@kroah.com> References: <20190321202303.GA1399@vis> <20190322053742.GB31708@kroah.com> <20190322204157.GB474@vis> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190322204157.GB474@vis> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 22, 2019 at 09:41:57PM +0100, Jochen Sprickerhof wrote: > Hi Greg, > > * Greg Kroah-Hartman [2019-03-22 06:37]: > > On Thu, Mar 21, 2019 at 09:23:03PM +0100, Jochen Sprickerhof wrote: > > > This adds a soft dependency to the dwc3 module to load it after > > > xhci-plat as proposed in: > > > > > > https://marc.info/?l=linux-usb&m=155230272022603&w=2 > > > > > > Old behaviour: > > > > > > $ lsusb -t > > > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M > > > /: Bus 05.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 480M > > > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 480M > > > > > > New behaviour: > > > > > > $ lsusb -t > > > /: Bus 06.Port 1: Dev 1, Class=root_hub, Driver=xhci-hcd/1p, 5000M > > > |__ Port 1: Dev 2, If 0, Class=Vendor Specific Class, Driver=r8152, 5000M > > > > > > Tested on Debian unstable using Linux 4.19.29. > > > > > > Note, this needs a hard reset when coming from an unpatched kernel. > > > > > > Signed-off-by: Jochen Sprickerhof > > > --- > > > drivers/usb/dwc3/core.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > > > index 103807587dc6..9017e4ed9d99 100644 > > > --- a/drivers/usb/dwc3/core.c > > > +++ b/drivers/usb/dwc3/core.c > > > @@ -1746,3 +1746,4 @@ MODULE_ALIAS("platform:dwc3"); > > > MODULE_AUTHOR("Felipe Balbi "); > > > MODULE_LICENSE("GPL v2"); > > > MODULE_DESCRIPTION("DesignWare USB3 DRD Controller Driver"); > > > +MODULE_SOFTDEP("pre: xhci_plat_hcd"); > > > > > > Your patch is corrupted and can not be applied :( > > > I'm sorry to hear that. For me this works: > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > cd linux > curl "https://lore.kernel.org/lkml/20190321202303.GA1399@vis/raw" | git am - > > But I found some archives that seems to have fiddled with the Content-Type > of my signed mail, making it fail. Can you send more information about the > corruption? Maybe it works if I look at the raw email, but just from the above text, your leading ' ' characters are dropped, so that's why I emailed you this. Let me go look at the message I received... Ah, yeah, the raw message is correct, it just has a gpg signature which messed with my email client's display somehow and dropped those leading spaces. Sorry for the noise, all is good. greg k-h