From: Pavel Machek <pavel@ucw.cz>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] leds: lt3593: remove set but not used variable 'flags'
Date: Sat, 23 Mar 2019 10:51:52 +0000 [thread overview]
Message-ID: <20190323105151.GD24127@amd> (raw)
In-Reply-To: <20190323024523.162210-1-yuehaibing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
On Sat 2019-03-23 11:38:04, Daniel Mack wrote:
> On 23/3/2019 11:34 AM, YueHaibing wrote:
> > On 2019/3/23 18:25, Daniel Mack wrote:
> >> On 23/3/2019 11:15 AM, Pavel Machek wrote:
>
> >>> If I look at code below, there's no difference between DEFSTATE_KEEP
> >>> and DEFSTATE_ON, right? I can't see how it works.
> >>
> >> Ah, you're right. Yes, the "keep" branch needs to go away entirely.
> >>
> >> As the chip can't be queried for it's current state, the "keep" option
> >> doesn't make sense. The only option in DT should be turn the LED on or
> >> off at probe time. YueHaibing, can you add that to your patch?
> >
> > Ok. I will send v2 with this.
>
> Note that Jacek just applied a patch of mine that removes all pdata
> handling from this driver. In order to avoid merge conflicts, you might
> want to base your patch on top of that.
>
Actually, Daniel, at this point I'd prefer you to take over this
patch. You have the hardware and you are already working on the
code...
Pavel
>
> https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git/commit/?h=for-next&id=bd7a59173aea
>
>
> Thanks,
> Daniel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-03-23 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 2:45 [PATCH -next] leds: lt3593: remove set but not used variable 'flags' YueHaibing
2019-03-23 9:29 ` Pavel Machek
2019-03-23 9:55 ` YueHaibing
2019-03-23 9:59 ` Pavel Machek
2019-03-23 10:10 ` Daniel Mack
2019-03-23 10:13 ` Daniel Mack
2019-03-23 10:15 ` Pavel Machek
2019-03-23 10:25 ` Daniel Mack
2019-03-23 10:34 ` YueHaibing
2019-03-23 10:38 ` Daniel Mack
2019-03-23 10:44 ` YueHaibing
2019-03-23 10:51 ` Pavel Machek [this message]
2019-03-23 10:57 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323105151.GD24127@amd \
--to=pavel@ucw.cz \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.