All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: linux-ext4@vger.kernel.org, jack@suse.cz,
	adilger.kernel@dilger.ca, miaoxie@huawei.com
Subject: Re: [PATCH v2 2/2] ext4: cleanup bh release code in ext4_ind_remove_space()
Date: Sat, 23 Mar 2019 11:58:50 -0400	[thread overview]
Message-ID: <20190323155850.GD5675@mit.edu> (raw)
In-Reply-To: <1552633813-42832-3-git-send-email-yi.zhang@huawei.com>

On Fri, Mar 15, 2019 at 03:10:13PM +0800, zhangyi (F) wrote:
> Currently, we are releasing the indirect buffer where we are done with
> it in ext4_ind_remove_space(), so we can see the brelse() and
> BUFFER_TRACE() everywhere. It seems fragile and hard to read, and we
> may probably forget to release the buffer some day. This patch do some
> cleanup stuff, put all the releasing code together to the end of this
> function.
> 
> Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>

Thanks, applied.

					- Ted

      parent reply	other threads:[~2019-03-23 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15  7:10 [PATCH v2 0/2] ext4: fix buffer references leak problem zhangyi (F)
2019-03-15  7:10 ` [PATCH v2 1/2] ext4: brelse all indirect buffer in ext4_ind_remove_space() zhangyi (F)
2019-03-18 11:08   ` Jan Kara
2019-03-23 15:53   ` Theodore Ts'o
2019-03-15  7:10 ` [PATCH v2 2/2] ext4: cleanup bh release code " zhangyi (F)
2019-03-18 11:10   ` Jan Kara
2019-03-23 15:58   ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190323155850.GD5675@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.