From: Greg KH <gregkh@linuxfoundation.org>
To: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 5/5] staging: rtl8723bs: core: Remove return variable in rtw_io.c
Date: Sun, 24 Mar 2019 09:49:46 +0100 [thread overview]
Message-ID: <20190324084946.GA17494@kroah.com> (raw)
In-Reply-To: <20190322143827.24480-6-nishka.dasgupta@yahoo.com>
On Fri, Mar 22, 2019 at 08:08:27PM +0530, Nishka Dasgupta wrote:
> Remove unnecessary local return variable in rtw_io.c. Issue found with
> Coccinelle using ret.cocci.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
> Changes in v2:
> - Remove trailing whitespace.
>
> drivers/staging/rtl8723bs/core/rtw_io.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c
> index d341069097e2..985eaa49ad3c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_io.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_io.c
> @@ -45,8 +45,7 @@ u8 _rtw_read8(struct adapter *adapter, u32 addr)
>
> _read8 = pintfhdl->io_ops._read8;
>
> - r_val = _read8(pintfhdl, addr);
> - return r_val;
> + return _read8(pintfhdl, addr);
This did not give you a build warning when you applied it? Odd, let me
check...
next prev parent reply other threads:[~2019-03-24 8:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:38 [PATCH v2 0/5] Remove unnecessary functions and return Nishka Dasgupta
2019-03-22 14:38 ` [PATCH v2 1/5] staging; rtl8723bs: Remove unnecessary function rtw_init_mlme_priv() Nishka Dasgupta
2019-03-22 14:38 ` [PATCH v2 2/5] staging: rtl8723bs: core: Change datatype from sint to int Nishka Dasgupta
2019-03-22 14:38 ` [PATCH v2 3/5] staging: rtl8723bs: core: Remove parentheses Nishka Dasgupta
2019-03-22 14:38 ` [PATCH v2 4/5] staging: rtl8723bs: Remove function rtw_alloc_network() Nishka Dasgupta
2019-03-22 14:38 ` [PATCH v2 5/5] staging: rtl8723bs: core: Remove return variable in rtw_io.c Nishka Dasgupta
2019-03-24 8:49 ` Greg KH [this message]
2019-03-24 8:53 ` Greg KH
2019-03-24 17:48 ` [Outreachy kernel] " Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324084946.GA17494@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=nishka.dasgupta@yahoo.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.