From: Jonathan Cameron <jic23@kernel.org>
To: Cristian Sicilia <sicilia.cristian@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] staging: iio: adc: Avoid precedence issues in macro
Date: Sun, 24 Mar 2019 12:37:23 +0000 [thread overview]
Message-ID: <20190324123723.0f78bfd8@archlinux> (raw)
In-Reply-To: <e57e377b86436d4c15ee7c1e6142acd0fded703d.1553366098.git.sicilia.cristian@gmail.com>
On Sat, 23 Mar 2019 20:21:42 +0100
Cristian Sicilia <sicilia.cristian@gmail.com> wrote:
> Enclosing parameter with parenthesis due to avoid
> possible precedence issue.
>
> Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com>
Applied to the togreg branch of iio.git which will get first
pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/staging/iio/adc/ad7280a.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 55b5879..d81a5bd 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -97,9 +97,10 @@
> #define AD7280A_NUM_CH (AD7280A_AUX_ADC_6 - \
> AD7280A_CELL_VOLTAGE_1 + 1)
>
> -#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + c)
> -#define AD7280A_CALC_TEMP_CHAN_NUM(d, c) ((d * AD7280A_CELLS_PER_DEV) + \
> - c - AD7280A_CELLS_PER_DEV)
> +#define AD7280A_CALC_VOLTAGE_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + \
> + (c))
> +#define AD7280A_CALC_TEMP_CHAN_NUM(d, c) (((d) * AD7280A_CELLS_PER_DEV) + \
> + (c) - AD7280A_CELLS_PER_DEV)
>
> #define AD7280A_DEVADDR_MASTER 0
> #define AD7280A_DEVADDR_ALL 0x1F
next prev parent reply other threads:[~2019-03-24 12:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 12:53 [PATCH 0/5] *** SUBJECT HERE *** Cristian Sicilia
2019-03-23 12:53 ` [PATCH 3/5] staging: iio: adc: Avoid precedence issues in macro Cristian Sicilia
2019-03-23 12:53 ` [PATCH 4/5] staging: iio: adc: Adding temp var to improve readability Cristian Sicilia
2019-03-23 12:54 ` [PATCH 2/5] staging: iio: adc: Converted bool to bitfield format Cristian Sicilia
2019-03-23 12:54 ` [PATCH 5/5] staging: iio: adc: Remove CamelCase notation Cristian Sicilia
2019-03-23 12:58 ` [PATCH 1/5] staging: iio: adc: Tab alignment Cristian Sicilia
2019-03-23 19:21 ` [PATCH v2 0/5] staging: iio: adc: Code refactoring and bool to bitfield change Cristian Sicilia
2019-03-23 19:21 ` [PATCH v2 1/5] staging: iio: adc: Tab alignment Cristian Sicilia
2019-03-24 12:35 ` Jonathan Cameron
2019-03-24 16:34 ` Cristian Sicilia
2019-03-23 19:21 ` [PATCH v2 2/5] staging: iio: adc: Converted bool to bitfield format Cristian Sicilia
2019-03-24 12:34 ` Jonathan Cameron
2019-03-24 16:33 ` Sicilia Cristian
2019-03-23 19:21 ` [PATCH v2 3/5] staging: iio: adc: Avoid precedence issues in macro Cristian Sicilia
2019-03-24 12:37 ` Jonathan Cameron [this message]
2019-03-23 19:21 ` [PATCH v2 4/5] staging: iio: adc: Adding temp var to improve readability Cristian Sicilia
2019-03-24 12:41 ` Jonathan Cameron
2019-03-23 19:21 ` [PATCH v2 5/5] staging: iio: adc: Remove CamelCase notation Cristian Sicilia
2019-03-24 14:56 ` Jonathan Cameron
2019-03-24 17:23 ` [PATCH v2 0/5] staging: iio: adc: Code refactoring and bool to bitfield change Cristian Sicilia
2019-03-24 17:27 ` [PATCH v3 " Cristian Sicilia
2019-03-24 17:23 ` [PATCH v3 1/5] staging: iio: adc: ad7280a: Tab alignment Cristian Sicilia
2019-03-31 9:29 ` Jonathan Cameron
2019-03-24 17:23 ` [PATCH v3 2/5] staging: iio: adc: ad7192: Converted bool to bitfield format Cristian Sicilia
2019-03-31 9:32 ` Jonathan Cameron
2019-03-24 17:23 ` [PATCH v3 3/5] staging: iio: adc: ad7280a: Avoid precedence issues in macro Cristian Sicilia
2019-03-31 9:34 ` Jonathan Cameron
2019-03-24 17:23 ` [PATCH v3 4/5] staging: iio: adc: ad7280a: Adding temp var to improve readability Cristian Sicilia
2019-03-31 9:35 ` Jonathan Cameron
2019-03-31 9:35 ` Jonathan Cameron
2019-03-24 17:23 ` [PATCH v3 5/5] staging: iio: adc: ad7280a: Remove CamelCase notation Cristian Sicilia
2019-03-31 9:37 ` Jonathan Cameron
2019-03-23 19:24 ` [PATCH 0/5] *** SUBJECT HERE *** Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324123723.0f78bfd8@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sicilia.cristian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.