From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] drm/i915: Sanity check mmap length against
 object size
Date: Mon, 25 Mar 2019 00:38:34 +0000
Message-ID: <20190325003835.5C0E0213F2@mail.kernel.org>
References: <20190314075829.16838-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by gabe.freedesktop.org (Postfix) with ESMTPS id AB1586E634
 for <intel-gfx@lists.freedesktop.org>; Mon, 25 Mar 2019 00:38:35 +0000 (UTC)
In-Reply-To: <20190314075829.16838-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Sasha Levin <sashal@kernel.org>, Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
List-Id: intel-gfx@lists.freedesktop.org

SGksCgpbVGhpcyBpcyBhbiBhdXRvbWF0ZWQgZW1haWxdCgpUaGlzIGNvbW1pdCBoYXMgYmVlbiBw
cm9jZXNzZWQgYmVjYXVzZSBpdCBjb250YWlucyBhIC1zdGFibGUgdGFnLgpUaGUgc3RhYmxlIHRh
ZyBpbmRpY2F0ZXMgdGhhdCBpdCdzIHJlbGV2YW50IGZvciB0aGUgZm9sbG93aW5nIHRyZWVzOiBh
bGwKClRoZSBib3QgaGFzIHRlc3RlZCB0aGUgZm9sbG93aW5nIHRyZWVzOiB2NS4wLjMsIHY0LjE5
LjMwLCB2NC4xNC4xMDcsIHY0LjkuMTY0LCB2NC40LjE3NiwgdjMuMTguMTM2LgoKdjUuMC4zOiBG
YWlsZWQgdG8gYXBwbHkhIFBvc3NpYmxlIGRlcGVuZGVuY2llczoKICAgIDczOWYzYWJkYmZjZiAo
ImRybS9pOTE1OiBzbWFsbCBpc29sYXRlZCBjOTkgdHlwZXMgdG8ga2VybmVsIHR5cGVzIHN3aXRj
aCIpCiAgICBlYmZiNjk3NzgwMWQgKCJkcm0vaTkxNTogSGFuZGxlIHZtX21tYXAgZXJyb3IgZHVy
aW5nIEk5MTVfR0VNX01NQVAgaW9jdGwgd2l0aCBXQyBzZXQiKQoKdjQuMTkuMzA6IEZhaWxlZCB0
byBhcHBseSEgUG9zc2libGUgZGVwZW5kZW5jaWVzOgogICAgNzM5ZjNhYmRiZmNmICgiZHJtL2k5
MTU6IHNtYWxsIGlzb2xhdGVkIGM5OSB0eXBlcyB0byBrZXJuZWwgdHlwZXMgc3dpdGNoIikKICAg
IGViZmI2OTc3ODAxZCAoImRybS9pOTE1OiBIYW5kbGUgdm1fbW1hcCBlcnJvciBkdXJpbmcgSTkx
NV9HRU1fTU1BUCBpb2N0bCB3aXRoIFdDIHNldCIpCiAgICBmMjhlYzZmNGVhNDggKCJkcm0vaTkx
NTogQ29uc3RpZnkgcG93ZXIgd2VsbCBkZXNjcmlwdG9ycyIpCgp2NC4xNC4xMDc6IEZhaWxlZCB0
byBhcHBseSEgUG9zc2libGUgZGVwZW5kZW5jaWVzOgogICAgMGQ2ZmM5MmE3M2UwICgiZHJtL2k5
MTU6IFNlcGFyYXRlIFJQUyBhbmQgUkM2IGhhbmRsaW5nIGZvciBWTFYiKQogICAgMjc0YjI0NjJh
MDQ5ICgiZHJtL2k5MTU6IE9iamVjdCB3L28gYmFja2luZyBzdG9yYWdlIGlzIGJhbm5lZCBieSAt
RU5YSU8iKQogICAgM2U4ZGRkOWU1MDcxICgiZHJtL2k5MTU6IE51a2Ugc29tZSBib2d1cyB0YWJz
IGZyb20gdGhlIHBjb2RlIGRlZmluZXMiKQogICAgNDg0NjllY2VkMjgyICgiZHJtL2k5MTU6IFVz
ZSBjZGNsa19zdGF0ZS0+dm9sdGFnZSBvbiBDTkwiKQogICAgNTE2MWQwNThkZmY0ICgiZHJtL2k5
MTU6IEZpeCBCWFQgbGFuZSBsYXRlbmN5IG9wdGltYWwgc2V0dGluZyB3aXRoIE1TVCIpCiAgICA1
M2U5YmY1ZTgxNTkgKCJkcm0vaTkxNTogQWRqdXN0IHN5c3RlbSBhZ2VudCB2b2x0YWdlIG9uIENO
TCBpZiByZXF1aXJlZCBieSBEREkgcG9ydHMiKQogICAgNjE4NDNmMGU2MjEyICgiZHJtL2k5MTU6
IE5hbWUgdGhlIElQU19QQ09ERV9DT05UUk9MIGJpdCIpCiAgICA3MzlmM2FiZGJmY2YgKCJkcm0v
aTkxNTogc21hbGwgaXNvbGF0ZWQgYzk5IHR5cGVzIHRvIGtlcm5lbCB0eXBlcyBzd2l0Y2giKQog
ICAgOTYwZTU0NjUyY2VlICgiZHJtL2k5MTU6IFNlcGFyYXRlIFJQUyBhbmQgUkM2IGhhbmRsaW5n
IGZvciBnZW42KyIpCiAgICA5ZjgxNzUwMWJkN2YgKCJkcm0vaTkxNTogTW92ZSBycHMuaHdfbG9j
ayB0byBkZXZfcHJpdiBhbmQgcy9od19sb2NrL3BjdV9sb2NrIikKICAgIGQzMDVlMDYxNDYwMSAo
ImRybS9pOTE1OiBUcmFjayBtaW5pbXVtIGFjY2VwdGFibGUgY2RjbGsgaW5zdGVhZCBvZiAibWlu
aW11bSBkb3RjbG9jayIiKQogICAgZDQ2YjAwZGMzOGM4ICgiZHJtL2k5MTU6IFNlcGFyYXRlIFJQ
UyBhbmQgUkM2IGhhbmRsaW5nIGZvciBDSFYiKQoKdjQuOS4xNjQ6IEZhaWxlZCB0byBhcHBseSEg
UG9zc2libGUgZGVwZW5kZW5jaWVzOgogICAgMGU3MDQ0NzYwNWY0ICgiZHJtL2k5MTU6IE1vdmUg
Y29tbW9uIGNvZGUgb3V0IG9mIGk5MTVfZ3B1X2Vycm9yLmMiKQogICAgMWIzNjU5NWZmYjM1ICgi
ZHJtL2k5MTU6IFNob3cgUklORyByZWdpc3RlcnMgdGhyb3VnaCBkZWJ1Z2ZzIikKICAgIDNiM2Yx
NjUwYjFjYSAoImRybS9pOTE1OiBBbGxvY2F0ZSBpbnRlbF9lbmdpbmVfY3Mgc3RydWN0dXJlIG9u
bHkgZm9yIHRoZSBlbmFibGVkIGVuZ2luZXMiKQogICAgOWM4NzBkMDM2NzRmICgiZHJtL2k5MTU6
IFVzZSBSUE0gYXMgdGhlIGJhcnJpZXIgZm9yIGNvbnRyb2xsaW5nIHVzZXIgbW1hcCBhY2Nlc3Mi
KQogICAgYmI2ZGM4ZDk2YjY4ICgiZHJtL2k5MTU6IEltcGxlbWVudCBwcmVhZCB3aXRob3V0IHN0
cnVjdC1tdXRleCIpCiAgICBkNjM2OTUxZWMwMWIgKCJkcm0vaTkxNTogQ2xlYW51cCBpbnN0ZG9u
ZSBjb2xsZWN0aW9uIikKICAgIGYwY2Q1MTgyMDZlMSAoImRybS9pOTE1OiBVc2UgbG9ja2xlc3Mg
b2JqZWN0IGZyZWUiKQogICAgZjllNjEzNzI4MDkwICgiZHJtL2k5MTU6IFRyeSB0byBwcmludCBJ
TlNURE9ORSBiaXRzIGZvciBhbGwgc2xpY2Uvc3Vic2xpY2UiKQoKdjQuNC4xNzY6IEZhaWxlZCB0
byBhcHBseSEgUG9zc2libGUgZGVwZW5kZW5jaWVzOgogICAgMDNhYzA2NDJmNjdhICgiZHJtL2k5
MTU6IFdyYXAgZHJtX2dlbV9vYmplY3RfbG9va3VwIGluIGk5MTVfZ2VtX29iamVjdF9sb29rdXAi
KQogICAgMWI1NzA4ZmZiMTAzICgiZHJtL2FtZGdwdTogZXhwb3J0IGFtZF9wb3dlcnBsYXlfZnVu
YyB0byBhbWRncHUgYW5kIG90aGVyIGlwIGJsb2NrIikKICAgIDFlYTg2M2ZkNzM2ZSAoImRybS9h
bWRncHU6IGtlZXAgdGhlIHByZWZlcmVkL2FsbG93ZWQgZG9tYWlucyBpbiB0aGUgQk8iKQogICAg
MWY3MzcxYjJhNWZhICgiZHJtL2FtZC9wb3dlcnBsYXk6IGFkZCBiYXNpYyBwb3dlcnBsYXkgZnJh
bWV3b3JrIikKICAgIDI4ODkxMmNiOTVkMSAoImRybS9hbWRncHU6IHVzZSAkKHNyYykgaW4gTWFr
ZWZpbGUgKHYyKSIpCiAgICAyYTdkOWJkYWJlYzIgKCJkcm0vYW1kZ3B1OiBjbGVhbnVwIGFtZGdw
dV9jc19wYXJzZXJfcmVsb2NzIikKICAgIDJmNGI5NDAwMzM2ZSAoImRybS9hbWRncHU6IGNsZWFu
IHVwIGh3IHNlbWFwaG9yZSBzdXBwb3J0IGluIGRyaXZlciIpCiAgICAzNjQwOWQxMjJjYjggKCJk
cm0vYW1kZ3B1OiBjbGVhbnVwIGFtZGdwdV9jc19saXN0X3ZhbGlkYXRlIikKICAgIDNhMmM3ODhk
OTVhMiAoImRybS9hbWRncHU6IHNoYXJlIHN0cnVjdCBhbWRncHVfcG1fc3RhdGVfdHlwZSB3aXRo
IHBvd2VycGxheSBtb2R1bGUiKQogICAgM2FmNzZmMjNhNDViICgiZHJtL2FtZGdwdTogZXhwb3J0
IGZhbiBjb250cm9sIGZ1bmN0aW9ucyB0byBhbWRncHUiKQogICAgM2MwZWVhNmMzNWQ5ICgiZHJt
L2FtZGdwdTogcHV0IFZNIHBhZ2UgdGFibGVzIGRpcmVjdGx5IGludG8gZHVwbGljYXRlcyBsaXN0
IikKICAgIDRmZjM3YTgzZjE5ZCAoImRybS9hbWRncHU6IGZpeCBWTSBmYXVsdHMgY2F1c2VkIGJ5
IHZtX2dyYWJfaWQoKSB2NCIpCiAgICA1NjQ2N2ViZmIyNTQgKCJkcm0vYW1kZ3B1OiBzcGxpdCBW
TSBQRCBhbmQgUFQgaGFuZGxpbmcgZHVyaW5nIENTIikKICAgIDYzNmNlMjVjMzAwMSAoImRybS9h
bWRncHU6IGNsZWFudXAgYm8gbGlzdCBidWNrZXQgaGFuZGxpbmciKQogICAgNzU4YWMxN2Y5NjNm
ICgiZHJtL2FtZGdwdTogZml4IGFuZCBjbGVhbnVwIHVzZXIgZmVuY2UgaGFuZGxpbmcgdjIiKQog
ICAgOGQwYTdjZWE4MjRhICgiZHJtL2FtZGdwdTogZ3JhYiBWTUlEIGJlZm9yZSBzdWJtaXR0aW5n
IGpvYiB2NSIpCiAgICBhOGFkMGJkODRmOTggKCJkcm06IFJlbW92ZSB1bnVzZWQgZHJtX2Rldmlj
ZSBmcm9tIGRybV9nZW1fb2JqZWN0X2xvb2t1cCgpIikKICAgIGJlODZjNjA2YjUwYSAoImRybS9h
bWRncHU6IGNsZWFudXAgYW1kZ3B1X3N5bmNfcmluZ3MgVjIiKQogICAgYzU2Mzc4MzdiYTVkICgi
ZHJtL2FtZGdwdToga2VlcCB2bSBpbiBqb2IgaW5zdGVhZCBvZiBpYiAodjIpIikKICAgIGNjMzI1
ZDE5MTM0NyAoImRybS9hbWRncHU6IGNoZWNrIHVzZXJwdHJzIG1tIGVhcmxpZXIiKQogICAgZDhl
MGNhZTY0NTUwICgiZHJtL2FtZGdwdTogdmFsaWRhdGUgZHVwbGljYXRlcyBmaXJzdCIpCiAgICBl
NjE3MTBjNTlkZDIgKCJkcm0vYW1kZ3B1OiBzdXBwb3J0IHBlciBkZXZpY2UgcG93ZXJwbGF5IGVu
YWJsZW1lbnQgKHYyKSIpCiAgICBlZGY2MDBkYWM2NWUgKCJkcm0vYW1kOiBjbGVhbnVwIHJlbWFp
bmluZyBzcGFjZXMgYW5kIHRhYnMgdjIiKQogICAgZWUxNzgyYzNmMjdmICgiZHJtL2FtZGdwdTog
a2VlcCB0aGUgUFRzIHZhbGlkYXRpb24gbGlzdCBpbiB0aGUgVk0gdjIiKQogICAgZjY5ZjkwYTEx
M2YyICgiZHJtL2FtZGdwdTogZml4IGFtZGdwdV9jc19nZXRfdGhyZXNob2xkX2Zvcl9tb3ZlcyBo
YW5kbGluZyIpCgp2My4xOC4xMzY6IEZhaWxlZCB0byBhcHBseSEgUG9zc2libGUgZGVwZW5kZW5j
aWVzOgogICAgMDNhYzA2NDJmNjdhICgiZHJtL2k5MTU6IFdyYXAgZHJtX2dlbV9vYmplY3RfbG9v
a3VwIGluIGk5MTVfZ2VtX29iamVjdF9sb29rdXAiKQogICAgMDQ5ZmM1MjdiNDY0ICgiZHJtL2Ft
ZGdwdTogZGlzcGF0Y2ggam9icyBpbiBjcyIpCiAgICAxZDI2MzQ3NGM0NDEgKCJkcm0vYW1kZ3B1
OiB1bndpbmQgcHJvcGVybHkgaW4gYW1kZ3B1X2NzX3BhcnNlcl9pbml0KCkiKQogICAgMmE3ZDli
ZGFiZWMyICgiZHJtL2FtZGdwdTogY2xlYW51cCBhbWRncHVfY3NfcGFyc2VyX3JlbG9jcyIpCiAg
ICAzY2I0ODVmMzQwNDkgKCJkcm0vYW1kZ3B1OiBmaXggY29udGV4dCBzd2l0Y2giKQogICAgNDY2
NTFjYzVkYmVlICgiZHJtL2FtZGdwdSBmaXggYW1kZ3B1LmRwbT0wICh2MikiKQogICAgNTY0ZWE3
OTAwY2ZmICgiZHJtL2FtZGdwdTogZW5hYmxlIHV2ZCBkcG0gYW5kIHBvd2VyZ2F0aW5nIikKICAg
IDVmYzNhZWViOWU1NSAoImRybS9hbWRncHU6IHJlbmFtZSBhbWRncHVfaXBfZnVuY3MgdG8gYW1k
X2lwX2Z1bmNzICh2MikiKQogICAgNjM2Y2UyNWMzMDAxICgiZHJtL2FtZGdwdTogY2xlYW51cCBi
byBsaXN0IGJ1Y2tldCBoYW5kbGluZyIpCiAgICA3MmVmYTdlYmRlYTAgKCJkcm0vYW1kZ3B1OiBj
aGVjayBjb250ZXh0IGlkIGZvciBjb250ZXh0IHN3aXRjaGluZyAodjIpIikKICAgIDgxNjI5Y2Jh
MWYxMiAoImRybS9hbWRncHU6IGFkZCBhbWRncHUgdWFwaSBoZWFkZXIgKHY0KSIpCiAgICA4NDBk
NTE0NDVmMTUgKCJkcm0vYW1kZ3B1OiBmaXggYnVnIG9jY3VycyB3aGVuIGJvX2xpc3QgaXMgTlVM
TCIpCiAgICA4ZTkxOThkMDY5OGEgKCJkcm0vYW1kZ3B1OiBtb3ZlIHNvbWUgYXRvbWJpb3MgZGVm
aW5pdGlvbnMgdG8gY29tbW9uIGZvbGRlciAodjIpIikKICAgIDk3YjJlMjAyZmJhMCAoImRybS9h
bWRncHU6IGFkZCBhbWRncHUuaCAodjIpIikKICAgIGEyZTczZjU2ZmE2MiAoImRybS9hbWRncHU6
IEFkZCBzdXBwb3J0IGZvciBDSUsgcGFydHMiKQogICAgYTMzNDhiYjgwMWJhICgiZHJtL2FtZGdw
dTogZG9uJ3QgbmVlZCB0byB1c2UgYm9fbGlzdF9jbG9uZSBhbnkgbW9yZSIpCiAgICBhNWI3NTA1
ODNlYjQgKCJkcm0vYW1kZ3B1OiB2YWxpZGF0ZSBkdXBsaWNhdGVzIGluIHRoZSBDUyBhcyB3ZWxs
IikKICAgIGE4YWQwYmQ4NGY5OCAoImRybTogUmVtb3ZlIHVudXNlZCBkcm1fZGV2aWNlIGZyb20g
ZHJtX2dlbV9vYmplY3RfbG9va3VwKCkiKQogICAgYTk2MWVhNzM0OWQwICgiZHJtL2FtZGdwdTog
Zml4IHVzZXJwdHIgbG9ja3VwIikKICAgIGFhMmJkYjI0NzYyMCAoImRybS9hbWRncHU6IGFkZCBD
RSBwcmVhbWJsZSBmbGFnIHYzIikKICAgIGFhYTM2YTk3NmJiYiAoImRybS9hbWRncHU6IEFkZCBp
bml0aWFsIFZJIHN1cHBvcnQiKQogICAgYjgwZDg0NzVjMWZkICgiZHJtL2FtZGdwdTogYWRkIHNj
aGVkdWxlciBpbml0aWFsaXphdGlvbiIpCiAgICBjMWI2OWVkMGM2MmYgKCJkcm0vYW1kZ3B1OiBh
ZGQgYmFja2VuZCBpbXBsZW1lbnRhdGlvbiBvZiBncHUgc2NoZWR1bGVyICh2MikiKQogICAgY2Mz
MjVkMTkxMzQ3ICgiZHJtL2FtZGdwdTogY2hlY2sgdXNlcnB0cnMgbW0gZWFybGllciIpCiAgICBk
MmVkYjA3YjEwZmMgKCJkcm0vYW1kZ3B1OiBjbGVhbnVwIEhEUCBmbHVzaCBoYW5kbGluZyIpCiAg
ICBkMzhjZWFmOTllZDAgKCJkcm0vYW1kZ3B1OiBhZGQgY29yZSBkcml2ZXIgKHY0KSIpCiAgICBk
NzAwNjk2NGQ0NmQgKCJkcm0vYW1kZ3B1OiBmaXggaXNzdWUgd2l0aCBvdmVybGFwcGluZyB1c2Vy
cHRycyIpCiAgICBkOTE5YWQ0OWFjMDQgKCJkcm0vYW1kZ3B1OiBmaXggZGVyZWZlcmVuY2UgYmVm
b3JlIGNoZWNrIikKICAgIGRlODA3ZjgxOGI5NSAoImRybS9hbWRncHU6IGFkZCBmbGFncyBmb3Ig
YW1kZ3B1X2liIHN0cnVjdHVyZSIpCgoKSG93IHNob3VsZCB3ZSBwcm9jZWVkIHdpdGggdGhpcyBw
YXRjaD8KCi0tClRoYW5rcywKU2FzaGEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl
ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vaW50ZWwtZ2Z4