From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Mon, 25 Mar 2019 14:50:32 +0000 Subject: Re: [PATCH] security/keys/trusted: Allow operation without hardware TPM Message-Id: <20190325145032.GA29989@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <155295271345.1945351.6465460744078693578.stgit@dwillia2-desk3.amr.corp.intel.com> <20190321135451.GD4603@linux.intel.com> <809e827b-fdbe-fbb8-8acf-2878ae9f7777@huawei.com> <20190322101227.GB3122@linux.intel.com> <20190325141223.GA13766@linux.intel.com> In-Reply-To: <20190325141223.GA13766@linux.intel.com> To: Dan Williams Cc: Silviu Vlasceanu , linux-nvdimm , James Bottomley , Roberto Sassu , Linux Kernel Mailing List , Mimi Zohar , David Howells , keyrings@vger.kernel.org On Mon, Mar 25, 2019 at 04:12:23PM +0200, Jarkko Sakkinen wrote: > > Robert, please feel free to re-author the proposed patch however you > > see fit, I just want whatever will get libnvdimm operational again in > > the shortest amount of time. > > I've decided go with a patch of least innovation i.e. one that simply reverts > the old behavior. Sending patch soon. I.e. https://www.lkml.org/lkml/2019/3/25/674 I think fixing the actual dependency issue would be unorthodox at this point of release cycle as adding dependencies was not the root cause for the bug even if existing somewhat unorthodox were. Better to just the problem by reverting the semantics near the same as in v5.0 and take this dependency discussion "offline" for the release work... /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD651211EABB3 for ; Mon, 25 Mar 2019 07:50:36 -0700 (PDT) Date: Mon, 25 Mar 2019 16:50:32 +0200 From: Jarkko Sakkinen Subject: Re: [PATCH] security/keys/trusted: Allow operation without hardware TPM Message-ID: <20190325145032.GA29989@linux.intel.com> References: <155295271345.1945351.6465460744078693578.stgit@dwillia2-desk3.amr.corp.intel.com> <20190321135451.GD4603@linux.intel.com> <809e827b-fdbe-fbb8-8acf-2878ae9f7777@huawei.com> <20190322101227.GB3122@linux.intel.com> <20190325141223.GA13766@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325141223.GA13766@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Silviu Vlasceanu , linux-nvdimm , James Bottomley , Roberto Sassu , Linux Kernel Mailing List , Mimi Zohar , David Howells , keyrings@vger.kernel.org List-ID: On Mon, Mar 25, 2019 at 04:12:23PM +0200, Jarkko Sakkinen wrote: > > Robert, please feel free to re-author the proposed patch however you > > see fit, I just want whatever will get libnvdimm operational again in > > the shortest amount of time. > > I've decided go with a patch of least innovation i.e. one that simply reverts > the old behavior. Sending patch soon. I.e. https://www.lkml.org/lkml/2019/3/25/674 I think fixing the actual dependency issue would be unorthodox at this point of release cycle as adding dependencies was not the root cause for the bug even if existing somewhat unorthodox were. Better to just the problem by reverting the semantics near the same as in v5.0 and take this dependency discussion "offline" for the release work... /Jarkko _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD43C43381 for ; Mon, 25 Mar 2019 14:50:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4314A20811 for ; Mon, 25 Mar 2019 14:50:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729322AbfCYOuh (ORCPT ); Mon, 25 Mar 2019 10:50:37 -0400 Received: from mga17.intel.com ([192.55.52.151]:6139 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729143AbfCYOug (ORCPT ); Mon, 25 Mar 2019 10:50:36 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2019 07:50:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,269,1549958400"; d="scan'208";a="137264325" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.97]) by fmsmga007.fm.intel.com with ESMTP; 25 Mar 2019 07:50:33 -0700 Date: Mon, 25 Mar 2019 16:50:32 +0200 From: Jarkko Sakkinen To: Dan Williams Cc: Roberto Sassu , James Bottomley , Mimi Zohar , David Howells , keyrings@vger.kernel.org, linux-nvdimm , Linux Kernel Mailing List , Silviu Vlasceanu Subject: Re: [PATCH] security/keys/trusted: Allow operation without hardware TPM Message-ID: <20190325145032.GA29989@linux.intel.com> References: <155295271345.1945351.6465460744078693578.stgit@dwillia2-desk3.amr.corp.intel.com> <20190321135451.GD4603@linux.intel.com> <809e827b-fdbe-fbb8-8acf-2878ae9f7777@huawei.com> <20190322101227.GB3122@linux.intel.com> <20190325141223.GA13766@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190325141223.GA13766@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 25, 2019 at 04:12:23PM +0200, Jarkko Sakkinen wrote: > > Robert, please feel free to re-author the proposed patch however you > > see fit, I just want whatever will get libnvdimm operational again in > > the shortest amount of time. > > I've decided go with a patch of least innovation i.e. one that simply reverts > the old behavior. Sending patch soon. I.e. https://www.lkml.org/lkml/2019/3/25/674 I think fixing the actual dependency issue would be unorthodox at this point of release cycle as adding dependencies was not the root cause for the bug even if existing somewhat unorthodox were. Better to just the problem by reverting the semantics near the same as in v5.0 and take this dependency discussion "offline" for the release work... /Jarkko