All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT"
Date: Mon, 25 Mar 2019 11:43:48 -0400	[thread overview]
Message-ID: <20190325154348.GI18421@bill-the-cat> (raw)
In-Reply-To: <20190314205743.30299-1-simon.k.r.goldschmidt@gmail.com>

On Thu, Mar 14, 2019 at 09:57:42PM +0100, Simon Goldschmidt wrote:

> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51.
> 
> The 'eeprom' command has been converted to work with DM_I2C in a patch
> submitted around the same time as this commit:
> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command")
> 
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> ---
> 
>  cmd/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

As is, nope:
make O=/home/jenkins/u-boot/build-am335x_evm -s am335x_evm_defconfig
make O=/home/jenkins/u-boot/build-am335x_evm -s -j8
../cmd/eeprom.c: In function 'eeprom_rw_block':
../cmd/eeprom.c:149:9: warning: implicit declaration of function 'i2c_read'; did you mean 'ide_read'? [-Wimplicit-function-declaration]
   ret = i2c_read(addr[0], offset, alen - 1, buffer, len);
         ^~~~~~~~
         ide_read
../cmd/eeprom.c:151:9: warning: implicit declaration of function 'i2c_write'; did you mean 'ide_write'? [-Wimplicit-function-declaration]
   ret = i2c_write(addr[0], offset, alen - 1, buffer, len);
         ^~~~~~~~~
         ide_write
cmd/built-in.o: In function `eeprom_rw_block':
/home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:149: undefined reference to `i2c_read'
/home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:151: undefined reference to `i2c_write'
/home/jenkins/u-boot/Makefile:1497: recipe for target 'u-boot' failed
make[1]: *** [u-boot] Error 1
Makefile:148: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190325/d596d293/attachment.sig>

  parent reply	other threads:[~2019-03-25 15:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 20:57 [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" Simon Goldschmidt
2019-03-15  6:44 ` Michal Simek
2019-03-15  6:51   ` Simon Goldschmidt
2019-03-15  6:57     ` Michal Simek
2019-03-15 19:02 ` Simon Goldschmidt
2019-03-18  7:23   ` Lukasz Majewski
2019-03-21 19:21     ` Simon Goldschmidt
2019-03-21 20:04       ` Simon Goldschmidt
2019-03-25 15:43 ` Tom Rini [this message]
2019-03-25 16:42   ` [U-Boot] " Simon Goldschmidt
2019-03-25 17:17     ` Tom Rini
2019-03-25 20:20       ` Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325154348.GI18421@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.