From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: CEC blocks idle on omap4 Date: Mon, 25 Mar 2019 09:21:15 -0700 Message-ID: <20190325162115.GM19425@atomide.com> References: <20190325153258.GU5717@atomide.com> <20190325155532.GB8280@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: linux-omap@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: linux-omap@vger.kernel.org KiBIYW5zIFZlcmt1aWwgPGh2ZXJrdWlsQHhzNGFsbC5ubD4gWzE5MDMyNSAxNjoxMl06Cj4gT24g My8yNS8xOSA0OjU1IFBNLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4+IFRoZSByZWFsaXR5 IGlzIHRoYXQgSERNSSBDRUMgYW5kIEhETUkgdmlkZW8gYXJlIHJlYWxseSBpbmRlcGVuZGVudCBv Zgo+ID4+IG9uZSBhbm90aGVyLiBTbyBJIHdvbmRlciBpZiBpdCBpc24ndCBiZXR0ZXIgdG8gZXhw bGFpbiB0aGUgZG93bnNpZGVzCj4gPj4gb2YgZW5hYmxpbmcgQ0VDIGZvciB0aGUgb21hcDQgaW4g dGhlIENPTkZJR19PTUFQNF9EU1NfSERNSV9DRUMKPiA+PiBkZXNjcmlwdGlvbi4gQW5kIHBlcmhh cHMgZGlzYWJsZSBpdCBieSBkZWZhdWx0Pwo+ID4gCj4gPiBUaGlzIHNob3VsZCBiZSBjb250cm9s bGFibGUgYnkgdXNlcnNwYWNlLiBGcm9tIGEgcHJvZHVjdCBwb2ludCBvZiB2aWV3LAo+ID4gaXQg c2hvdWxkIGJlIHBvc3NpYmxlIHRvIHB1dCB0aGUgc3lzdGVtIGluIGEgZGVlcCBzbGVlcCBzdGF0 ZSB3aGVyZSBDRUMKPiA+IGlzbid0IGF2YWlsYWJsZSwgb3IgaW4gYSBsb3cgc2xlZXAgc3RhdGUg d2hlcmUgQ0VDIHdvcmtzIGFzIGV4cGVjdGVkLgo+ID4gCj4gCj4gVXNlcnNwYWNlIGNhbiBhbHdh eXMgZGlzYWJsZSBDRUMuIFRoZSBoZG1pX2NlY19hZGFwX2VuYWJsZSgpIGNhbGxiYWNrIGluCj4g aGRtaTRfY2VjLmMgaXMgY2FsbGVkIHdoZW5ldmVyIHRoZSBDRUMgYWRhcHRlciBpcyBlbmFibGVk IG9yIGRpc2FibGVkLgoKT0sKCj4gSSdtIG5vdCBhY3R1YWxseSBzdXJlIHdoeSBoZG1pNF9jZWNf aW5pdCgpIHdvdWxkIGJsb2NrIGFueXRoaW5nIHNpbmNlIGl0Cj4ganVzdCByZWdpc3RlcnMgdGhl IENFQyBkZXZpY2UuIEl0IGRvZXMgbm90IGVuYWJsZSBpdCB1bnRpbCB1c2Vyc3BhY2UKPiBleHBs aWNpdGx5IGVuYWJsZXMgaXQgd2l0aCBlLmcuICdjZWMtY3RsIC0tcGxheWJhY2snLgo+IAo+IGhk bWk0X2NlY19pbml0KCkgZG9lcyBjb25maWd1cmUgYSBDRUMgY2xvY2ssIGJ1dCB0aGF0IGNhbiBi ZSBtb3ZlZCB0bwo+IGhkbWlfY2VjX2FkYXBfZW5hYmxlKCkgaWYgbmVjZXNzYXJ5LgoKSGV5IEkn bSBwcmV0dHkgc3VyZSB0aGF0J3MgdGhlIHJpZ2h0IGZpeCB0aGVuIDopCgo+IE5vdGUgdGhhdCBJ IGFtIG5vdCBzdXJlIHdoYXQgaXMgbWVhbnQgd2l0aCAnU29DIGNvcmUgcmV0ZW50aW9uIGlkbGUn LAo+IHNvIHBlcmhhcHMgSSBqdXN0IG1pc3VuZGVyc3RhbmQgdGhlIHByb2JsZW0uCgpJZiBjZXJ0 YWluIFNvQyBjbG9ja3MgYXJlIGJ1c3ksIHRoZSBTb0Mgd2lsbCBub3QgZW50ZXIgZGVlcGVyCmlk bGUgc3RhdGVzLiBUaGUgaGFyZHdhcmUgaGFzIGF1dG9pZGxlIHR5cGUgZmVhdHVyZXMgb24gb21h cHMuCgpSZWdhcmRzLAoKVG9ueQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF45EC43381 for ; Mon, 25 Mar 2019 16:21:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8F8B2083D for ; Mon, 25 Mar 2019 16:21:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729805AbfCYQVT (ORCPT ); Mon, 25 Mar 2019 12:21:19 -0400 Received: from muru.com ([72.249.23.125]:42462 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729778AbfCYQVS (ORCPT ); Mon, 25 Mar 2019 12:21:18 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F3F8C80CC; Mon, 25 Mar 2019 16:21:31 +0000 (UTC) Date: Mon, 25 Mar 2019 09:21:15 -0700 From: Tony Lindgren To: Hans Verkuil Cc: Laurent Pinchart , Tomi Valkeinen , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org Subject: Re: CEC blocks idle on omap4 Message-ID: <20190325162115.GM19425@atomide.com> References: <20190325153258.GU5717@atomide.com> <20190325155532.GB8280@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org * Hans Verkuil [190325 16:12]: > On 3/25/19 4:55 PM, Laurent Pinchart wrote: > >> The reality is that HDMI CEC and HDMI video are really independent of > >> one another. So I wonder if it isn't better to explain the downsides > >> of enabling CEC for the omap4 in the CONFIG_OMAP4_DSS_HDMI_CEC > >> description. And perhaps disable it by default? > > > > This should be controllable by userspace. From a product point of view, > > it should be possible to put the system in a deep sleep state where CEC > > isn't available, or in a low sleep state where CEC works as expected. > > > > Userspace can always disable CEC. The hdmi_cec_adap_enable() callback in > hdmi4_cec.c is called whenever the CEC adapter is enabled or disabled. OK > I'm not actually sure why hdmi4_cec_init() would block anything since it > just registers the CEC device. It does not enable it until userspace > explicitly enables it with e.g. 'cec-ctl --playback'. > > hdmi4_cec_init() does configure a CEC clock, but that can be moved to > hdmi_cec_adap_enable() if necessary. Hey I'm pretty sure that's the right fix then :) > Note that I am not sure what is meant with 'SoC core retention idle', > so perhaps I just misunderstand the problem. If certain SoC clocks are busy, the SoC will not enter deeper idle states. The hardware has autoidle type features on omaps. Regards, Tony