From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] board: rename pine64 to pine64_a64
Date: Mon, 25 Mar 2019 18:01:08 +0100 [thread overview]
Message-ID: <20190325180108.15704071@windsurf> (raw)
In-Reply-To: <CAMty3ZAodmPT6=aX3wFvwY-r6O6p5XVN3qgG5s5E-anft1Ku2Q@mail.gmail.com>
Hello,
I haven't seen the original patch. Was it sent to the Buildroot mailing
list ? It doesn't seem like it reached the mailing list.
Philip: did you register on the mailing list before sending your
patch ? If not, could you subscribe to the mailing list and resend ?
Thanks!
On Mon, 25 Mar 2019 10:43:45 +0530
Jagan Teki <jagan@amarulasolutions.com> wrote:
> > N: James Hilliard <james.hilliard1@gmail.com>
> > diff --git a/board/pine64/pine64/boot.cmd b/board/pine64/a64/boot.cmd
> > similarity index 100%
> > rename from board/pine64/pine64/boot.cmd
> > rename to board/pine64/a64/boot.cmd
> > diff --git a/board/pine64/pine64/genimage.cfg b/board/pine64/a64/genimage.cfg
> > similarity index 100%
> > rename from board/pine64/pine64/genimage.cfg
> > rename to board/pine64/a64/genimage.cfg
>
> pine64 is vendor who produced pine64 board. and same vendor producing
> sopine. so renaming to a64 doesn't valid.
What? I'm sorry I don't understand what you mean here.
The typical Buildroot folder organization is:
board/<vendor>/<boardname>/
pine64 is indeed a vendor name, and a64 is a board name, according to
https://www.pine64.org/?page_id=46823. So the change looks perfect
correct to me. It will allow to add support for other boards produced
by Pine64, in board/pine64/<boardname>/.
> > -Pine64 link:
> > +Pine A64 link:
> > https://www.pine64.org/?page_id=1194
>
> It has wiki link below, that intern routing pine64 board link. wiki
> has Mainline stuff information.
I'm not a native English speaker, so I might be wrong, but I believe
"that intern routing pine64 board link" doesn't make any sense in
English. What are you trying to say here ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-25 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190202040519.14568-1-philip.a.molloy@gmail.com>
2019-03-25 5:13 ` [Buildroot] [PATCH v2] board: rename pine64 to pine64_a64 Jagan Teki
2019-03-25 17:01 ` Thomas Petazzoni [this message]
2019-03-27 12:56 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325180108.15704071@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.