From: Borislav Petkov <bp@alien8.de>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: KVM <kvm@vger.kernel.org>, "Joerg Roedel" <joro@8bytes.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Tony Luck" <tony.luck@intel.com>,
"Yazen Ghannam" <Yazen.Ghannam@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c
Date: Mon, 25 Mar 2019 19:39:09 +0100 [thread overview]
Message-ID: <20190325183909.GQ12016@zn.tnic> (raw)
In-Reply-To: <20190325182133.GG31069@linux.intel.com>
On Mon, Mar 25, 2019 at 11:21:33AM -0700, Sean Christopherson wrote:
> Won't this prevent emulating an AMD guest on Intel hardware, e.g. due to
> injecting #GPs during boot?
I guess, but...
> Keeping support in kvm_{get,set}_msr_common
> doesn't preclude svm_{get,set}_msr() from having SVM-specific handling for
> the MSR.
... is kvm_{get,set}_msr_common() supposed to cover for all those
overlapping MSRs between AMD and Intel? svm_{get,set}_msr() have a lot
more AMD-specific MSRs just like vmx_{get,set}_msr() respectively for
Intel.
Which would mean that if you really want to support those cross-vendor
emulations, you don't need the svm* and vmx* MSR accessors... or am I
missing something?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-03-25 18:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 17:16 [PATCH v4 0/2] x86/kvm: Enable MCE injection in the guest Borislav Petkov
2019-03-25 17:16 ` [PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c Borislav Petkov
2019-03-25 18:05 ` Jim Mattson
2019-03-25 18:12 ` Borislav Petkov
2019-03-25 18:21 ` Sean Christopherson
2019-03-25 18:39 ` Borislav Petkov [this message]
2019-03-25 19:21 ` Sean Christopherson
2019-03-25 19:38 ` Borislav Petkov
2019-03-25 17:16 ` [PATCH 2/2] x86/kvm: Implement MSR_HWCR support Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-06-28 17:38 [PATCH 0/2] x86/kvm: Enable MCE injection in the guest v2 Borislav Petkov
2018-06-28 17:38 ` [PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325183909.GQ12016@zn.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.