All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: sudipm.mukherjee@gmail.com, outreachy-kernel@googlegroups.com,
	jules.octave@outlook.com
Subject: Re: [PATCH resend] staging: sm750fb: lower case to fix camelcase checkpatch warning
Date: Tue, 26 Mar 2019 04:27:30 +0900	[thread overview]
Message-ID: <20190325192730.GD14506@kroah.com> (raw)
In-Reply-To: <20190325175907.17740-1-jbi.octave@gmail.com>

On Mon, Mar 25, 2019 at 05:59:07PM +0000, Jules Irenge wrote:
> Lower case to fix CamelCase checkpatch.pl warning
> "CHECK: Avoid CamelCase: <ulActualMxClk>".
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_chip.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 6bdf643707c2..3fe4479401e5 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -56,7 +56,7 @@ static unsigned int get_mxclk_freq(void)
>  static void set_chip_clock(unsigned int frequency)
>  {
>  	struct pll_value pll;
> -	unsigned int ulActualMxClk;
> +	unsigned int ul_actual_mx_clk;

There is no need for the "ul" right?



  reply	other threads:[~2019-03-25 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 17:59 [PATCH resend] staging: sm750fb: lower case to fix camelcase checkpatch warning Jules Irenge
2019-03-25 19:27 ` Greg KH [this message]
2019-03-25 20:48   ` Jules Octave

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190325192730.GD14506@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=jules.octave@outlook.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.