From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH 3/6] mfd: da9063: remove platform_data support
Date: Mon, 25 Mar 2019 21:22:03 +0100 [thread overview]
Message-ID: <20190325202203.GA7749@kunai> (raw)
In-Reply-To: <20190319122556.7wpabcnwklv3fg3v@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
> > - if (pdata) {
> > - da9063->flags = pdata->flags;
> > - da9063->irq_base = pdata->irq_base;
> > - } else {
> > - da9063->flags = 0;
> > - da9063->irq_base = -1;
> > - }
> > + da9063->flags = 0;
> > + da9063->irq_base = -1;
>
> If the flag and irq_base fields have fixed values can
> they be removed? As a follow-up?
There is likely more simplification possible. But yes, it should be a
follow up patch, I think.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-25 20:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 15:47 [PATCH 0/6] mfd: da9063: remove platform_data Wolfram Sang
2019-03-18 15:47 ` [PATCH 1/6] regulator: da9063: remove platform_data support Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-29 10:57 ` Steve Twiss
2019-03-18 15:47 ` [PATCH 2/6] input: da9063_onkey: " Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-29 10:58 ` Steve Twiss
2019-04-03 9:24 ` Wolfram Sang
2019-03-18 15:47 ` [PATCH 3/6] mfd: da9063: " Wolfram Sang
2019-03-19 12:25 ` Simon Horman
2019-03-25 20:22 ` Wolfram Sang [this message]
2019-03-19 12:49 ` Simon Horman
2019-03-29 10:58 ` Steve Twiss
2019-04-03 8:02 ` Lee Jones
2019-03-18 15:47 ` [PATCH 4/6] regulator: da9063: move definitions out of a header into the driver Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-19 13:01 ` Mark Brown
2019-04-03 9:22 ` Wolfram Sang
2019-04-03 10:07 ` Mark Brown
2019-03-29 11:00 ` Steve Twiss
2019-03-18 15:47 ` [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions Wolfram Sang
2019-03-19 12:49 ` Simon Horman
2019-03-29 11:00 ` Steve Twiss
2019-04-03 8:07 ` Lee Jones
2019-04-03 8:50 ` Wolfram Sang
2019-04-03 9:03 ` Lee Jones
2019-03-18 15:47 ` [PATCH 6/6] regulator: da9063: platform_data is gone, depend on OF Wolfram Sang
2019-03-19 12:50 ` Simon Horman
2019-03-29 11:01 ` Steve Twiss
2019-03-18 16:34 ` [PATCH 0/6] mfd: da9063: remove platform_data Steve Twiss
2019-03-29 11:02 ` Steve Twiss
2019-03-29 11:27 ` Wolfram Sang
2019-03-29 11:28 ` Steve Twiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325202203.GA7749@kunai \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=support.opensource@diasemi.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.