From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Subject: [radeon-alex:drm-next-5.2-wip 230/300]
 drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:514
 dce_aux_transfer_with_retries() error: uninitialized symbol
 'operation_result'.
Date: Tue, 26 Mar 2019 10:17:31 +0300
Message-ID: <20190326071731.GD32613@kadam>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <kbuild-bounces@lists.01.org>
Content-Disposition: inline
List-Unsubscribe: <https://lists.01.org/mailman/options/kbuild>,
 <mailto:kbuild-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/kbuild/>
List-Post: <mailto:kbuild@lists.01.org>
List-Help: <mailto:kbuild-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/kbuild>,
 <mailto:kbuild-request@lists.01.org?subject=subscribe>
Errors-To: kbuild-bounces@lists.01.org
Sender: "kbuild" <kbuild-bounces@lists.01.org>
To: kbuild@01.org, Thomas Lim <Thomas.Lim@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>, David Francis <David.Francis@amd.com>, kbuild-all@01.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

tree:   git://people.freedesktop.org/~agd5f/linux.git drm-next-5.2-wip
head:   940d104240cd069a88f089f91299ac9bf4a154d1
commit: 2bec3b50c9c5be65ac4800d57ace6fc3b2d82136 [230/300] drm/amd/display: Respect aux return values

smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c:514 dce_aux_transfer_with_retries() error: uninitialized symbol 'operation_result'.

git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git
git remote update radeon-alex
git checkout 2bec3b50c9c5be65ac4800d57ace6fc3b2d82136
vim +/operation_result +514 drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_aux.c

eae5ffa9 David Francis 2018-11-29  493  
eae5ffa9 David Francis 2018-11-29  494  bool dce_aux_transfer_with_retries(struct ddc_service *ddc,
eae5ffa9 David Francis 2018-11-29  495  		struct aux_payload *payload)
eae5ffa9 David Francis 2018-11-29  496  {
eae5ffa9 David Francis 2018-11-29  497  	int i, ret = 0;
eae5ffa9 David Francis 2018-11-29  498  	uint8_t reply;
eae5ffa9 David Francis 2018-11-29  499  	bool payload_reply = true;
2bec3b50 Thomas Lim    2019-01-16  500  	enum aux_channel_operation_result operation_result;
2bec3b50 Thomas Lim    2019-01-16  501  	int aux_ack_retries = 0,
2bec3b50 Thomas Lim    2019-01-16  502  		aux_defer_retries = 0,
2bec3b50 Thomas Lim    2019-01-16  503  		aux_i2c_defer_retries = 0,
2bec3b50 Thomas Lim    2019-01-16  504  		aux_timeout_retries = 0,
2bec3b50 Thomas Lim    2019-01-16  505  		aux_invalid_reply_retries = 0;
eae5ffa9 David Francis 2018-11-29  506  
eae5ffa9 David Francis 2018-11-29  507  	if (!payload->reply) {
eae5ffa9 David Francis 2018-11-29  508  		payload_reply = false;
eae5ffa9 David Francis 2018-11-29  509  		payload->reply = &reply;
eae5ffa9 David Francis 2018-11-29  510  	}
eae5ffa9 David Francis 2018-11-29  511  
2bec3b50 Thomas Lim    2019-01-16  512  	for (i = 0; i < AUX_MAX_RETRIES; i++) {
2bec3b50 Thomas Lim    2019-01-16  513  		ret = dce_aux_transfer_raw(ddc, payload, &operation_result);
                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^
My guess is that this function can fail, but I haven't looked at the
code.

2bec3b50 Thomas Lim    2019-01-16 @514  		switch (operation_result) {