From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] ARM: davinci: omapl138-hawk: add a fixed regulator for ohci-da8xx From: Bartosz Golaszewski Message-Id: <20190326155728.5432-2-brgl@bgdev.pl> Date: Tue, 26 Mar 2019 16:57:26 +0100 To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bartosz Golaszewski List-ID: RnJvbTogQmFydG9zeiBHb2xhc3pld3NraSA8YmdvbGFzemV3c2tpQGJheWxpYnJlLmNvbT4KCklu c3RlYWQgb2YgZGlyZWN0bHkgdXNpbmcgdGhlIHZidXMgR1BJTyB3ZSBzaG91bGQgbW9kZWwgaXQg YXMgYSBmaXhlZApyZWd1bGF0b3IuIEFkZCBhbGwgbmVjZXNzYXJ5IGZpeC11cHMgZm9yIHRoZSBy ZWd1bGF0b3IgdG8gYmUgcmVnaXN0ZXJlZAphbmQgY29uZmlndXJlIHRoZSB2YnVzIEdQSU8gYXMg aXRzIGVuYWJsZSBwaW4uCgpTaWduZWQtb2ZmLWJ5OiBCYXJ0b3N6IEdvbGFzemV3c2tpIDxiZ29s YXN6ZXdza2lAYmF5bGlicmUuY29tPgotLS0KIGFyY2gvYXJtL21hY2gtZGF2aW5jaS9ib2FyZC1v bWFwbDEzOC1oYXdrLmMgfCA0OCArKysrKysrKysrKysrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2Vk LCA0NSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJt L21hY2gtZGF2aW5jaS9ib2FyZC1vbWFwbDEzOC1oYXdrLmMgYi9hcmNoL2FybS9tYWNoLWRhdmlu Y2kvYm9hcmQtb21hcGwxMzgtaGF3ay5jCmluZGV4IDA4OTZhZjJiZWQyNC4uZWE3MTEwZTQ3ZThh IDEwMDY0NAotLS0gYS9hcmNoL2FybS9tYWNoLWRhdmluY2kvYm9hcmQtb21hcGwxMzgtaGF3ay5j CisrKyBiL2FyY2gvYXJtL21hY2gtZGF2aW5jaS9ib2FyZC1vbWFwbDEzOC1oYXdrLmMKQEAgLTIx LDYgKzIxLDcgQEAKICNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kYXRhL210ZC1kYXZpbmNpLmg+ CiAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGF0YS9tdGQtZGF2aW5jaS1hZW1pZi5oPgogI2lu Y2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEvdGktYWVtaWYuaD4KKyNpbmNsdWRlIDxsaW51eC9y ZWd1bGF0b3IvZml4ZWQuaD4KICNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvbWFjaGluZS5oPgog CiAjaW5jbHVkZSA8YXNtL21hY2gtdHlwZXMuaD4KQEAgLTI5OCwxNCArMjk5LDQ4IEBAIHN0YXRp YyBjb25zdCBzaG9ydCBkYTg1MF9oYXdrX3VzYjExX3BpbnNbXSA9IHsKIAktMQogfTsKIAotc3Rh dGljIHN0cnVjdCBncGlvZF9sb29rdXBfdGFibGUgaGF3a191c2JfZ3Bpb19sb29rdXAgPSB7Citz dGF0aWMgc3RydWN0IHJlZ3VsYXRvcl9jb25zdW1lcl9zdXBwbHkgaGF3a191c2Jfc3VwcGxpZXNb XSA9IHsKKwlSRUdVTEFUT1JfU1VQUExZKCJ2YnVzIiwgTlVMTCksCit9OworCitzdGF0aWMgc3Ry dWN0IHJlZ3VsYXRvcl9pbml0X2RhdGEgaGF3a191c2JfdmJ1c19kYXRhID0geworCS5jb25zdW1l cl9zdXBwbGllcwk9IGhhd2tfdXNiX3N1cHBsaWVzLAorCS5udW1fY29uc3VtZXJfc3VwcGxpZXMJ PSBBUlJBWV9TSVpFKGhhd2tfdXNiX3N1cHBsaWVzKSwKK307CisKK3N0YXRpYyBzdHJ1Y3QgZml4 ZWRfdm9sdGFnZV9jb25maWcgaGF3a191c2JfdmJ1cyA9IHsKKwkuc3VwcGx5X25hbWUJCT0gInZi dXMiLAorCS5taWNyb3ZvbHRzCQk9IDMzMDAwMDAsCisJLmluaXRfZGF0YQkJPSAmaGF3a191c2Jf dmJ1c19kYXRhLAorfTsKKworc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgaGF3a191c2Jf dmJ1c19kZXZpY2UgPSB7CisJLm5hbWUJCT0gInJlZy1maXhlZC12b2x0YWdlIiwKKwkuaWQJCT0g MSwKKwkuZGV2CQk9IHsKKwkJLnBsYXRmb3JtX2RhdGEgPSAmaGF3a191c2JfdmJ1cywKKwl9LAor fTsKKworc3RhdGljIHN0cnVjdCBncGlvZF9sb29rdXBfdGFibGUgaGF3a191c2Jfb2NfZ3Bpb19s b29rdXAgPSB7CiAJLmRldl9pZAkJPSAib2hjaS1kYTh4eCIsCiAJLnRhYmxlID0gewotCQlHUElP X0xPT0tVUCgiZGF2aW5jaV9ncGlvIiwgREE4NTBfVVNCMV9WQlVTX1BJTiwgInZidXMiLCAwKSwK IAkJR1BJT19MT09LVVAoImRhdmluY2lfZ3BpbyIsIERBODUwX1VTQjFfT0NfUElOLCAib2MiLCAw KSwKIAl9LAogfTsKIAorc3RhdGljIHN0cnVjdCBncGlvZF9sb29rdXBfdGFibGUgaGF3a191c2Jf dmJ1c19ncGlvX2xvb2t1cCA9IHsKKwkuZGV2X2lkCQk9ICJyZWctZml4ZWQtdm9sdGFnZS4xIiwK KwkudGFibGUgPSB7CisJCUdQSU9fTE9PS1VQKCJkYXZpbmNpX2dwaW8iLCBEQTg1MF9VU0IxX1ZC VVNfUElOLCBOVUxMLCAwKSwKKwl9LAorfTsKKworc3RhdGljIHN0cnVjdCBncGlvZF9sb29rdXBf dGFibGUgKmhhd2tfdXNiX2dwaW9fbG9va3Vwc1tdID0geworCSZoYXdrX3VzYl9vY19ncGlvX2xv b2t1cCwKKwkmaGF3a191c2JfdmJ1c19ncGlvX2xvb2t1cCwKK307CisKIHN0YXRpYyBzdHJ1Y3Qg ZGE4eHhfb2hjaV9yb290X2h1YiBvbWFwbDEzOF9oYXdrX3VzYjExX3BkYXRhID0gewogCS8qIFRQ UzIwODcgc3dpdGNoIEAgNVYgKi8KIAkucG90cGd0ICAgICAgICAgPSAoMyArIDEpIC8gMiwgIC8q IDMgbXMgbWF4ICovCkBAIC0zMjYsMTIgKzM2MSwxOSBAQCBzdGF0aWMgX19pbml0IHZvaWQgb21h cGwxMzhfaGF3a191c2JfaW5pdCh2b2lkKQogCQlwcl93YXJuKCIlczogVVNCIFBIWSBDTEsgcmVn aXN0cmF0aW9uIGZhaWxlZDogJWRcbiIsCiAJCQlfX2Z1bmNfXywgcmV0KTsKIAorCWdwaW9kX2Fk ZF9sb29rdXBfdGFibGVzKGhhd2tfdXNiX2dwaW9fbG9va3VwcywKKwkJCQlBUlJBWV9TSVpFKGhh d2tfdXNiX2dwaW9fbG9va3VwcykpOworCiAJcmV0ID0gZGE4eHhfcmVnaXN0ZXJfdXNiX3BoeSgp OwogCWlmIChyZXQpCiAJCXByX3dhcm4oIiVzOiBVU0IgUEhZIHJlZ2lzdHJhdGlvbiBmYWlsZWQ6 ICVkXG4iLAogCQkJX19mdW5jX18sIHJldCk7CiAKLQlncGlvZF9hZGRfbG9va3VwX3RhYmxlKCZo YXdrX3VzYl9ncGlvX2xvb2t1cCk7CisJcmV0ID0gcGxhdGZvcm1fZGV2aWNlX3JlZ2lzdGVyKCZo YXdrX3VzYl92YnVzX2RldmljZSk7CisJaWYgKHJldCkgeworCQlwcl93YXJuKCIlczogVW5hYmxl IHRvIHJlZ2lzdGVyIHRoZSB2YnVzIHN1cHBseVxuIiwgX19mdW5jX18pOworCQlyZXR1cm47CisJ fQogCiAJcmV0ID0gZGE4eHhfcmVnaXN0ZXJfdXNiMTEoJm9tYXBsMTM4X2hhd2tfdXNiMTFfcGRh dGEpOwogCWlmIChyZXQpCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2898FC43381 for ; Tue, 26 Mar 2019 15:58:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED0E320863 for ; Tue, 26 Mar 2019 15:58:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JF+Fl8oq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="2AHMFk/n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED0E320863 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NzPBQLC7lpp2NYisDIWSmr+IMul+/kpGbJAVjRZBGBQ=; b=JF+Fl8oqJKd0k0 ByUAkjhlzYKcNxl5M3+sRRPBrQzCbczdZ3Ja9iqnPz4DSVLPsHklva0GfPT2V6xZ/OMhKGgC5NEW0 JJI726zW6ppuZdssMW1ecr10peGk4NxFhFF87VjygpC1nRz3zwaqHhFtkVe3E1pFBdOhUuAoPo/vd 9PwS9AJ7TVVjiuR/RhLaskdhk0Alsroivllq0rOaJHwlW+Mszh0aIN9hOK3Quab5saq4GEFd3aGRp InjzgVzdrLyhkrDZRvjYt5Wc577Vl2AY4g+jcUjA9PZsD3Q1XIf50AxegxMvFVwhiOmJ0vsTgxDrG sMmjUg8mIKui1FEOs0sA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8oSk-0000lu-3j; Tue, 26 Mar 2019 15:58:06 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8oSL-0000LI-II for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 15:57:47 +0000 Received: by mail-wr1-x444.google.com with SMTP id w1so15037506wrp.2 for ; Tue, 26 Mar 2019 08:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6RoQu7lKq5HUjsOpqb5VBB45JH3hBOA4zTqWoTxIGD0=; b=2AHMFk/nV5es0CsmlQNEAIl+UXjXuD9BY51qYWm4ehk9X8dG1QUsoNCAXpMvlhH7Yf IN5YEtJVEBJfAUOj69n6pKbfvWQKkf+zgH78/S+OXP7aL5vS+rVnXVaEAlpe22TZMwjh oIA+xxnD09PC1d7gp7X/fJzWrb1AMAtBHgtzTtdYOO0gXAX8FQv/kXiXxgHh/1LqRKSa pKd+xwZqf6SVmOt/B42PXgO/2/fVML/+pCAdpTdozi90nJxPzhlXTXaTDpI0Gauj0AEd HX6AvkpZFtqrfhzFw0K3UJPbZcZjitIKe2xPxJ6ItfyseU7XMHkqe6jjG4q/b8lBn81K KUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6RoQu7lKq5HUjsOpqb5VBB45JH3hBOA4zTqWoTxIGD0=; b=Qfc83tajHeEjiqclt6vwgwsiUwVbxj25XOHQA4vgsf4CEI7xyDoT6raDXxXbF/DCrO qqUkyzEH50DL5t3vJDODb9avAIySJYt6Q+lCdXVYcwJ/XlDN+/pMGXTKI8uVF+Y8DOyp PiF8abq5t8SHlPB3DsXUsg6ldsTpeFIFXbx2Ikat5FPWmv/1u1ymGrTL94e0bNrNLsSs 4FFOnv55Z1/Les4GufpHnHN5RQzez/oB8r9EgplFlk0rDBk2lTqEvaqg5peVuvQMTx6E 0MGkSBUfMF/9JK2DG0sSu/Kzc4v+MJhS4BNFUfLupO6tMLEFAgm3rbT+80IxmlXGBlc6 kuXQ== X-Gm-Message-State: APjAAAXhJilMf03uZSve1fR2yh8OwIjbUz3S2t1kMGwXJR496VBRrEMF sa6kQyhIskipnXwLXbDzCiG+KA== X-Google-Smtp-Source: APXvYqxMZQ2CgaEn9VNAFmSYHng/qFDULpwN5xe6U1SLeQ53mxYaRXuNmHztd/kqbirFZBDJVE2lzg== X-Received: by 2002:a5d:5190:: with SMTP id k16mr2329572wrv.10.1553615856848; Tue, 26 Mar 2019 08:57:36 -0700 (PDT) Received: from debian-brgl.home ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id 204sm28522999wmc.1.2019.03.26.08.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 08:57:36 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Subject: [PATCH 1/3] ARM: davinci: omapl138-hawk: add a fixed regulator for ohci-da8xx Date: Tue, 26 Mar 2019 16:57:26 +0100 Message-Id: <20190326155728.5432-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190326155728.5432-1-brgl@bgdev.pl> References: <20190326155728.5432-1-brgl@bgdev.pl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_085741_748794_4BC83A4F X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Instead of directly using the vbus GPIO we should model it as a fixed regulator. Add all necessary fix-ups for the regulator to be registered and configure the vbus GPIO as its enable pin. Signed-off-by: Bartosz Golaszewski --- arch/arm/mach-davinci/board-omapl138-hawk.c | 48 +++++++++++++++++++-- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c index 0896af2bed24..ea7110e47e8a 100644 --- a/arch/arm/mach-davinci/board-omapl138-hawk.c +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include @@ -298,14 +299,48 @@ static const short da850_hawk_usb11_pins[] = { -1 }; -static struct gpiod_lookup_table hawk_usb_gpio_lookup = { +static struct regulator_consumer_supply hawk_usb_supplies[] = { + REGULATOR_SUPPLY("vbus", NULL), +}; + +static struct regulator_init_data hawk_usb_vbus_data = { + .consumer_supplies = hawk_usb_supplies, + .num_consumer_supplies = ARRAY_SIZE(hawk_usb_supplies), +}; + +static struct fixed_voltage_config hawk_usb_vbus = { + .supply_name = "vbus", + .microvolts = 3300000, + .init_data = &hawk_usb_vbus_data, +}; + +static struct platform_device hawk_usb_vbus_device = { + .name = "reg-fixed-voltage", + .id = 1, + .dev = { + .platform_data = &hawk_usb_vbus, + }, +}; + +static struct gpiod_lookup_table hawk_usb_oc_gpio_lookup = { .dev_id = "ohci-da8xx", .table = { - GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, "vbus", 0), GPIO_LOOKUP("davinci_gpio", DA850_USB1_OC_PIN, "oc", 0), }, }; +static struct gpiod_lookup_table hawk_usb_vbus_gpio_lookup = { + .dev_id = "reg-fixed-voltage.1", + .table = { + GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, NULL, 0), + }, +}; + +static struct gpiod_lookup_table *hawk_usb_gpio_lookups[] = { + &hawk_usb_oc_gpio_lookup, + &hawk_usb_vbus_gpio_lookup, +}; + static struct da8xx_ohci_root_hub omapl138_hawk_usb11_pdata = { /* TPS2087 switch @ 5V */ .potpgt = (3 + 1) / 2, /* 3 ms max */ @@ -326,12 +361,19 @@ static __init void omapl138_hawk_usb_init(void) pr_warn("%s: USB PHY CLK registration failed: %d\n", __func__, ret); + gpiod_add_lookup_tables(hawk_usb_gpio_lookups, + ARRAY_SIZE(hawk_usb_gpio_lookups)); + ret = da8xx_register_usb_phy(); if (ret) pr_warn("%s: USB PHY registration failed: %d\n", __func__, ret); - gpiod_add_lookup_table(&hawk_usb_gpio_lookup); + ret = platform_device_register(&hawk_usb_vbus_device); + if (ret) { + pr_warn("%s: Unable to register the vbus supply\n", __func__); + return; + } ret = da8xx_register_usb11(&omapl138_hawk_usb11_pdata); if (ret) -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE45C43381 for ; Tue, 26 Mar 2019 15:57:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76CF22070D for ; Tue, 26 Mar 2019 15:57:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="2AHMFk/n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726277AbfCZP5l (ORCPT ); Tue, 26 Mar 2019 11:57:41 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:39700 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731489AbfCZP5i (ORCPT ); Tue, 26 Mar 2019 11:57:38 -0400 Received: by mail-wr1-f68.google.com with SMTP id j9so14984636wrn.6 for ; Tue, 26 Mar 2019 08:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6RoQu7lKq5HUjsOpqb5VBB45JH3hBOA4zTqWoTxIGD0=; b=2AHMFk/nV5es0CsmlQNEAIl+UXjXuD9BY51qYWm4ehk9X8dG1QUsoNCAXpMvlhH7Yf IN5YEtJVEBJfAUOj69n6pKbfvWQKkf+zgH78/S+OXP7aL5vS+rVnXVaEAlpe22TZMwjh oIA+xxnD09PC1d7gp7X/fJzWrb1AMAtBHgtzTtdYOO0gXAX8FQv/kXiXxgHh/1LqRKSa pKd+xwZqf6SVmOt/B42PXgO/2/fVML/+pCAdpTdozi90nJxPzhlXTXaTDpI0Gauj0AEd HX6AvkpZFtqrfhzFw0K3UJPbZcZjitIKe2xPxJ6ItfyseU7XMHkqe6jjG4q/b8lBn81K KUbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6RoQu7lKq5HUjsOpqb5VBB45JH3hBOA4zTqWoTxIGD0=; b=hGGLQamF0CRz7dmA1F8r+QRd4SEvCFaahH4i3d5kF42pnNS1wEYMct3XHdrVxoJrUx 2K2NsQUUPMJNlUISHCgNSNs3B38+h+H4104s+BbxRsj2n/K9DAzzZ+YrLb0EaRZ6zYDn RxtM8x6uUizF9gzCxlB8g6TBebcKsdj54UpGKAl+8VSS1dOtOsRhUdq3L7AKn957JNgv U8O2XvZtto1Kp2mRSgVHoP1vpFdPAkVd7qd6DudgqfrmYGu2DP2KZTfg24Y8QlY4XMOG /6Zp8c9VNNU0iEltwVbCnfvTLgjTcgKPJMvOwbARpeL4XTnCV/Hz+cp9BsV6xaJ62fY5 ymxQ== X-Gm-Message-State: APjAAAXIiBEnydTlWj63B5j14xm2pqAJSb02tlve48x+2OCq+PoxDMFm kOfQu/TiTg7CMD3ubv78AvDaGA== X-Google-Smtp-Source: APXvYqxMZQ2CgaEn9VNAFmSYHng/qFDULpwN5xe6U1SLeQ53mxYaRXuNmHztd/kqbirFZBDJVE2lzg== X-Received: by 2002:a5d:5190:: with SMTP id k16mr2329572wrv.10.1553615856848; Tue, 26 Mar 2019 08:57:36 -0700 (PDT) Received: from debian-brgl.home ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id 204sm28522999wmc.1.2019.03.26.08.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 08:57:36 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 1/3] ARM: davinci: omapl138-hawk: add a fixed regulator for ohci-da8xx Date: Tue, 26 Mar 2019 16:57:26 +0100 Message-Id: <20190326155728.5432-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190326155728.5432-1-brgl@bgdev.pl> References: <20190326155728.5432-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Instead of directly using the vbus GPIO we should model it as a fixed regulator. Add all necessary fix-ups for the regulator to be registered and configure the vbus GPIO as its enable pin. Signed-off-by: Bartosz Golaszewski --- arch/arm/mach-davinci/board-omapl138-hawk.c | 48 +++++++++++++++++++-- 1 file changed, 45 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c index 0896af2bed24..ea7110e47e8a 100644 --- a/arch/arm/mach-davinci/board-omapl138-hawk.c +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include @@ -298,14 +299,48 @@ static const short da850_hawk_usb11_pins[] = { -1 }; -static struct gpiod_lookup_table hawk_usb_gpio_lookup = { +static struct regulator_consumer_supply hawk_usb_supplies[] = { + REGULATOR_SUPPLY("vbus", NULL), +}; + +static struct regulator_init_data hawk_usb_vbus_data = { + .consumer_supplies = hawk_usb_supplies, + .num_consumer_supplies = ARRAY_SIZE(hawk_usb_supplies), +}; + +static struct fixed_voltage_config hawk_usb_vbus = { + .supply_name = "vbus", + .microvolts = 3300000, + .init_data = &hawk_usb_vbus_data, +}; + +static struct platform_device hawk_usb_vbus_device = { + .name = "reg-fixed-voltage", + .id = 1, + .dev = { + .platform_data = &hawk_usb_vbus, + }, +}; + +static struct gpiod_lookup_table hawk_usb_oc_gpio_lookup = { .dev_id = "ohci-da8xx", .table = { - GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, "vbus", 0), GPIO_LOOKUP("davinci_gpio", DA850_USB1_OC_PIN, "oc", 0), }, }; +static struct gpiod_lookup_table hawk_usb_vbus_gpio_lookup = { + .dev_id = "reg-fixed-voltage.1", + .table = { + GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, NULL, 0), + }, +}; + +static struct gpiod_lookup_table *hawk_usb_gpio_lookups[] = { + &hawk_usb_oc_gpio_lookup, + &hawk_usb_vbus_gpio_lookup, +}; + static struct da8xx_ohci_root_hub omapl138_hawk_usb11_pdata = { /* TPS2087 switch @ 5V */ .potpgt = (3 + 1) / 2, /* 3 ms max */ @@ -326,12 +361,19 @@ static __init void omapl138_hawk_usb_init(void) pr_warn("%s: USB PHY CLK registration failed: %d\n", __func__, ret); + gpiod_add_lookup_tables(hawk_usb_gpio_lookups, + ARRAY_SIZE(hawk_usb_gpio_lookups)); + ret = da8xx_register_usb_phy(); if (ret) pr_warn("%s: USB PHY registration failed: %d\n", __func__, ret); - gpiod_add_lookup_table(&hawk_usb_gpio_lookup); + ret = platform_device_register(&hawk_usb_vbus_device); + if (ret) { + pr_warn("%s: Unable to register the vbus supply\n", __func__); + return; + } ret = da8xx_register_usb11(&omapl138_hawk_usb11_pdata); if (ret) -- 2.20.1