diff for duplicates of <20190326162910.GY3888@intel.com> diff --git a/a/1.txt b/N1/1.txt index 4615641..69f5dcc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -54,18 +54,18 @@ On Tue, Mar 26, 2019 at 10:17:40AM +0100, Thomas Zimmermann wrote: > + > +static bool is_c8(const struct fb_info* fb_info) > +{ -> + return fb_info->var.bits_per_pixel = 8; +> + return fb_info->var.bits_per_pixel == 8; > +} > + > +static bool is_rgb565_be(const struct fb_info* fb_info) > +{ -> + return (fb_info->var.bits_per_pixel = 16) && -> + (fb_info->var.red.offset = 0) && -> + (fb_info->var.red.length = 5) && -> + (fb_info->var.green.offset = 5) && -> + (fb_info->var.green.length = 6) && -> + (fb_info->var.blue.offset = 11) && -> + (fb_info->var.blue.length = 5); +> + return (fb_info->var.bits_per_pixel == 16) && +> + (fb_info->var.red.offset == 0) && +> + (fb_info->var.red.length == 5) && +> + (fb_info->var.green.offset == 5) && +> + (fb_info->var.green.length == 6) && +> + (fb_info->var.blue.offset == 11) && +> + (fb_info->var.blue.length == 5); > +} You can't distinguish LE vs. BE like this. @@ -75,3 +75,7 @@ Maybe FBINFO_FOREIGN_ENDIAN is trustworthy? -- Ville Syrjälä Intel +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N1/content_digest index 23ec9b0..26122a2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020190326091744.11542-8-tzimmermann@suse.de\0" "From\0Ville Syrj\303\244l\303\244 <ville.syrjala@linux.intel.com>\0" "Subject\0Re: [PATCH 07/11] drm/fbdevdrm: Add DRM <-> fbdev pixel-format conversion\0" - "Date\0Tue, 26 Mar 2019 16:29:10 +0000\0" + "Date\0Tue, 26 Mar 2019 18:29:10 +0200\0" "To\0Thomas Zimmermann <tzimmermann@suse.de>\0" "Cc\0airlied@linux.ie" linux-fbdev@vger.kernel.org @@ -66,18 +66,18 @@ "> +\n" "> +static bool is_c8(const struct fb_info* fb_info)\n" "> +{\n" - "> +\treturn fb_info->var.bits_per_pixel = 8;\n" + "> +\treturn fb_info->var.bits_per_pixel == 8;\n" "> +}\n" "> +\n" "> +static bool is_rgb565_be(const struct fb_info* fb_info)\n" "> +{\n" - "> +\treturn (fb_info->var.bits_per_pixel = 16) &&\n" - "> +\t (fb_info->var.red.offset = 0) &&\n" - "> +\t (fb_info->var.red.length = 5) &&\n" - "> +\t (fb_info->var.green.offset = 5) &&\n" - "> +\t (fb_info->var.green.length = 6) &&\n" - "> +\t (fb_info->var.blue.offset = 11) &&\n" - "> +\t (fb_info->var.blue.length = 5);\n" + "> +\treturn (fb_info->var.bits_per_pixel == 16) &&\n" + "> +\t (fb_info->var.red.offset == 0) &&\n" + "> +\t (fb_info->var.red.length == 5) &&\n" + "> +\t (fb_info->var.green.offset == 5) &&\n" + "> +\t (fb_info->var.green.length == 6) &&\n" + "> +\t (fb_info->var.blue.offset == 11) &&\n" + "> +\t (fb_info->var.blue.length == 5);\n" "> +}\n" "\n" "You can't distinguish LE vs. BE like this.\n" @@ -86,6 +86,10 @@ "\n" "-- \n" "Ville Syrj\303\244l\303\244\n" - Intel + "Intel\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -c962b0d1527e6be13f5683543e32b6d47d6dcbf7bc856b794db54be41b809557 +6686762e91fec62e41154f223bdf44c8a04b3c804c3b7c9e67352252d8b6a744
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.