[pci:review/pci/resource 8/21] drivers/nvme/host/pci.c:2919:6: sparse: symbol 'nvme_rescan_prepare' was not declared. Should it be static?

[pci:review/pci/resource 8/21] drivers/nvme/host/pci.c:2919:6: sparse: symbol 'nvme_rescan_prepare' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git review/pci/resource
head:   4e373408d7e45cf4ae83c9448e4653388e1174bd
commit: aad30cad086923324dfc0ec32d8e34e562b9804c [8/21] nvme-pci: Handle movable BARs
reproduce:
        # apt-get install sparse
        git checkout aad30cad086923324dfc0ec32d8e34e562b9804c
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

   drivers/nvme/host/pci.c:1757:15: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:1757:15: sparse: expression using sizeof(void)
   include/linux/slab.h:664:13: sparse: undefined identifier '__builtin_mul_overflow'
   drivers/nvme/host/pci.c:1985:28: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:1984:27: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2005:21: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2005:21: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2168:18: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2292:33: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2295:48: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2295:48: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2350:24: sparse: expression using sizeof(void)
   drivers/nvme/host/pci.c:2350:24: sparse: expression using sizeof(void)
   include/linux/nodemask.h:265:16: sparse: expression using sizeof(void)
   include/linux/slab.h:699:13: sparse: undefined identifier '__builtin_mul_overflow'
>> drivers/nvme/host/pci.c:2919:6: sparse: symbol 'nvme_rescan_prepare' was not declared. Should it be static?
>> drivers/nvme/host/pci.c:2928:6: sparse: symbol 'nvme_rescan_done' was not declared. Should it be static?
   include/linux/slab.h:664:13: sparse: call with no type!
   include/linux/slab.h:699:13: sparse: call with no type!

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH pci] nvme-pci: nvme_rescan_prepare() can be static

[kbuild test robot]

Fixes: aad30cad0869 ("nvme-pci: Handle movable BARs")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 pci.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index ec1461e..6575fe6 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2916,7 +2916,7 @@ static void nvme_error_resume(struct pci_dev *pdev)
 	flush_work(&dev->ctrl.reset_work);
 }
 
-void nvme_rescan_prepare(struct pci_dev *pdev)
+static void nvme_rescan_prepare(struct pci_dev *pdev)
 {
 	struct nvme_dev *dev = pci_get_drvdata(pdev);
 
@@ -2925,7 +2925,7 @@ void nvme_rescan_prepare(struct pci_dev *pdev)
 	dev->bar = NULL;
 }
 
-void nvme_rescan_done(struct pci_dev *pdev)
+static void nvme_rescan_done(struct pci_dev *pdev)
 {
 	struct nvme_dev *dev = pci_get_drvdata(pdev);
 

Re: [pci:review/pci/resource 8/21] drivers/nvme/host/pci.c:2919:6: sparse: symbol 'nvme_rescan_prepare' was not declared. Should it be static?

[Christoph Hellwig]

Please make sure all nvme patches go by the nvme maintainers and have
an ACK, btw.  I've not even seen this patch before.

Re: [pci:review/pci/resource 8/21] drivers/nvme/host/pci.c:2919:6: sparse: symbol 'nvme_rescan_prepare' was not declared. Should it be static?

[Bjorn Helgaas]

[+cc Sergey]

On Tue, Mar 26, 2019 at 08:40:12AM -0700, Christoph Hellwig wrote:
> Please make sure all nvme patches go by the nvme maintainers and have
> an ACK, btw.  I've not even seen this patch before.

Thanks for pointing that out!  I haven't accepted any of this series
yet; I just pushed the branch to get build checking from the robot in
parallel with reviewing things.

Bjorn