From: Christoph Hellwig <hch@lst.de>
To: Yufen Yu <yuyufen@huawei.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, hch@lst.de,
osandov@fb.com, ming.lei@redhat.com
Subject: Re: [PATCH] blk-mq: add trace block plug and unplug for multiple queues
Date: Wed, 27 Mar 2019 09:13:56 +0100 [thread overview]
Message-ID: <20190327081356.GD20525@lst.de> (raw)
In-Reply-To: <20190326131925.60255-1-yuyufen@huawei.com>
On Tue, Mar 26, 2019 at 09:19:25PM +0800, Yufen Yu wrote:
> For now, we just trace plug for single queue device or drivers
> provide .commit_rqs, and have not trace plug for multiple queues
> device. But, unplug events will be recorded when call
> blk_mq_flush_plug_list(). Then, trace events will be asymmetrical,
> just have unplug and without plug.
>
> This patch add trace plug and unplug for multiple queues device in
> blk_mq_make_request(). After that, we can accurately trace plug and
> unplug for multiple queues.
>
> Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-03-27 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 13:19 [PATCH] blk-mq: add trace block plug and unplug for multiple queues Yufen Yu
2019-03-27 8:13 ` Christoph Hellwig [this message]
2019-04-02 14:34 ` yuyufen
2019-04-02 14:57 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327081356.GD20525@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.