From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Elijah Newren <newren@gmail.com>, Mooga <contact@m-mooga.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [GSoC] microporject test_path_is_*
Date: Wed, 27 Mar 2019 11:49:35 +0100 [thread overview]
Message-ID: <20190327104935.GD32732@szeder.dev> (raw)
In-Reply-To: <877eckbpdd.fsf@evledraar.gmail.com>
On Wed, Mar 27, 2019 at 11:09:18AM +0100, Ævar Arnfjörð Bjarmason wrote:
> > There are likewise several that use one of
> > ! test -e path/to/filename
> > or
> > ! test -f path/to/filename
> > or
> > test ! -f path/to/filename
> > which could be replaced by
> > test_path_is_missing path/to/filename
>
> Interesting that for some we use the 'test_is_there/test_is_not_there'
> pattern and for others 'test_is_there [!]'. E.g
> test_path_exist/test_path_is_missing v.s. test_i18ngrep.
It's unclear what the '!' should negate in case of 'test_path_is_file
! file'. What if 'file' does exists, but it's not a file but a
directory, socket, fifo, or symlink? 'test ! -f file' returns success
in these cases as well.
OTOH, it's quite clear what the negation should mean in case of
'test_i18ngrep'.
next prev parent reply other threads:[~2019-03-27 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 21:07 [GSoC] microporject test_path_is_* Mooga
2019-03-26 22:06 ` Elijah Newren
2019-03-27 10:09 ` Ævar Arnfjörð Bjarmason
2019-03-27 10:49 ` SZEDER Gábor [this message]
2019-03-27 11:21 ` Ævar Arnfjörð Bjarmason
2019-03-27 12:14 ` SZEDER Gábor
2019-03-27 14:10 ` Ævar Arnfjörð Bjarmason
2019-03-28 9:58 ` SZEDER Gábor
2019-03-27 11:28 ` Mooga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327104935.GD32732@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=avarab@gmail.com \
--cc=contact@m-mooga.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.