From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DC5C43381 for ; Wed, 27 Mar 2019 13:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83DFF2087C for ; Wed, 27 Mar 2019 13:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553695131; bh=aUmUklp7Ivv3GyGqbd0YUb6qmHm6kG8ZHeYPYC02o6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ENZckut4e4kSzXNeE4HPhGAgKGkZpuHPEFrTcSfB+yeuEEpQ6hH4LPuAIXgpV0vsx rYCgmm2UGDMlQilaLcdwbZJwEvhmeJj1hWJuA7wAtYDReP3K1YGvYG7UiQ4+C89Kcp nbZ0vEi6WLOYqzD6SSHZ5/wMzfTMvkNh97W+W+Ek= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727488AbfC0N6u (ORCPT ); Wed, 27 Mar 2019 09:58:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:55416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfC0N6u (ORCPT ); Wed, 27 Mar 2019 09:58:50 -0400 Received: from localhost (173-25-63-173.client.mchsi.com [173.25.63.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFDB22075E; Wed, 27 Mar 2019 13:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553695129; bh=aUmUklp7Ivv3GyGqbd0YUb6qmHm6kG8ZHeYPYC02o6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zT1MCNlGj9RhY8AgOj7IDCfnOiEvbUdVWCLymPQFo59Hqp/D8zjye+yy2fnIIZ64w aQnM7ANzKreDfZsb02u7JJnKUDFUYCIqE2A02wQTeh/yWUp/SC13Jv0YwV11A9CqRn ReZFuutym3gfxX4lqR+E+vsM0IyNwr3o9WB2A0qM= Date: Wed, 27 Mar 2019 08:58:48 -0500 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Michal Simek , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/2] PCI/MSI: Remove unused interfaces Message-ID: <20190327135848.GA24180@google.com> References: <20190325221229.36930-1-helgaas@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190325221229.36930-1-helgaas@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc Lorenzo, Michal, linux-arm-kernel] On Mon, Mar 25, 2019 at 05:12:27PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > pcie-xilinx-nwl.c is the only driver to use mask_msi_irq() and > unmask_msi_irq(), which are trivial wrappers around PCI-specific functions. > We obviously know we need the PCI versions in this driver, so use them > directly, as all the other PCI host controller drivers do, and remove the > unused wrappers. > > Unless there's objection, I'll merge both of these via my tree just to keep > them together. These are on pci/msi for v5.2. > Bjorn Helgaas (2): > PCI/MSI: Remove unused __write_msi_msg() and write_msi_msg() > PCI/MSI: Remove unused mask_msi_irq() and unmask_msi_irq() > > drivers/pci/controller/pcie-xilinx-nwl.c | 9 ++++----- > include/linux/msi.h | 18 ------------------ > 2 files changed, 4 insertions(+), 23 deletions(-) > > -- > 2.21.0.392.gf8f6787159e-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CC0C43381 for ; Wed, 27 Mar 2019 13:59:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 713F72075E for ; Wed, 27 Mar 2019 13:59:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HFqx/C6s"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zT1MCNlG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 713F72075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lc/aetvn6+BAPJSCmULaSghZeXq6CIf0zgYK5w1P9Jc=; b=HFqx/C6sjCEOUz Txxi3YBd7KuoOojs6q5IQoAQvkWOEJpz6p7078KhKWxLSLE5mND2qmDJJPcRRhraWo38mnB5Rl5Bj VwGciMBqYnS1mK1QmbZl9pSWHHhCZkr9xhhy3Hq3Z7r8w/7+IyVe3twBJm5CVTckTMAL8EVis8YFv XztM+Hu9mS+5u1WKEeNHM7qF6fQIP9cqKUur/mHjYcqQxFCH5KGmT1usd5un0V2e9L3iquL0aIs81 RIZrrSa5lImWp79L5C/DjV+UEFLf18KKLI5zc5HdoUTLfn3Y6JWN7p/Iv7SES3wImqgGnea7a8uZ7 0T5qkYfdddghFZx3vTGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h994y-0006B9-Gg; Wed, 27 Mar 2019 13:58:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h994t-00069z-E2 for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 13:58:53 +0000 Received: from localhost (173-25-63-173.client.mchsi.com [173.25.63.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFDB22075E; Wed, 27 Mar 2019 13:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553695129; bh=aUmUklp7Ivv3GyGqbd0YUb6qmHm6kG8ZHeYPYC02o6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zT1MCNlGj9RhY8AgOj7IDCfnOiEvbUdVWCLymPQFo59Hqp/D8zjye+yy2fnIIZ64w aQnM7ANzKreDfZsb02u7JJnKUDFUYCIqE2A02wQTeh/yWUp/SC13Jv0YwV11A9CqRn ReZFuutym3gfxX4lqR+E+vsM0IyNwr3o9WB2A0qM= Date: Wed, 27 Mar 2019 08:58:48 -0500 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Subject: Re: [PATCH 0/2] PCI/MSI: Remove unused interfaces Message-ID: <20190327135848.GA24180@google.com> References: <20190325221229.36930-1-helgaas@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190325221229.36930-1-helgaas@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190327_065851_488759_E91F1EC9 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc Lorenzo, Michal, linux-arm-kernel] On Mon, Mar 25, 2019 at 05:12:27PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > pcie-xilinx-nwl.c is the only driver to use mask_msi_irq() and > unmask_msi_irq(), which are trivial wrappers around PCI-specific functions. > We obviously know we need the PCI versions in this driver, so use them > directly, as all the other PCI host controller drivers do, and remove the > unused wrappers. > > Unless there's objection, I'll merge both of these via my tree just to keep > them together. These are on pci/msi for v5.2. > Bjorn Helgaas (2): > PCI/MSI: Remove unused __write_msi_msg() and write_msi_msg() > PCI/MSI: Remove unused mask_msi_irq() and unmask_msi_irq() > > drivers/pci/controller/pcie-xilinx-nwl.c | 9 ++++----- > include/linux/msi.h | 18 ------------------ > 2 files changed, 4 insertions(+), 23 deletions(-) > > -- > 2.21.0.392.gf8f6787159e-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel