All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Branden Bonaby <brandonbonaby94@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/3] staging: rtl8712: rename variable to avoid camelcase
Date: Wed, 27 Mar 2019 23:29:51 +0900	[thread overview]
Message-ID: <20190327142951.GA1851@kroah.com> (raw)
In-Reply-To: <2de19725be83555d1f3983bf4ff7d9925ebd4f1c.1553619382.git.brandonbonaby94@gmail.com>

On Tue, Mar 26, 2019 at 01:29:29PM -0400, Branden Bonaby wrote:
> Rename variable blnSetTxDescOffset to bln_set_tx_desc_offset
> to align with linux kernel coding style in rtl8712_xmit.c.

You can drop the "bln" prefix, it's not needed at all, this should just
be "set_tx_desc_offet".

thanks,

greg k-h


  parent reply	other threads:[~2019-03-27 18:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 17:29 [PATCH 0/3] staging: rtl8712: coding style issues Branden Bonaby
2019-03-26 17:29 ` [PATCH 1/3] staging: rtl8712: remove unnecessary parentheses Branden Bonaby
2019-03-26 17:29 ` [PATCH 2/3] staging: rtl8712: rename variable to avoid camelcase Branden Bonaby
2019-03-26 17:50   ` [Outreachy kernel] " Julia Lawall
2019-03-27 14:29   ` Greg KH [this message]
2019-03-26 17:29 ` [PATCH 3/3] staging: rtl8712: Remove comparison to true Branden Bonaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190327142951.GA1851@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=brandonbonaby94@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.