Re: [PATCH 7/8] llvm: update from 8.0.0rc2 to 8.0.0 final release

From: Martin Jansa <martin.jansa@gmail.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 7/8] llvm: update from 8.0.0rc2 to 8.0.0 final release
Date: Wed, 27 Mar 2019 15:43:35 +0100	[thread overview]
Message-ID: <20190327144335.GC1598@jama> (raw)
In-Reply-To: <20190327140922.109867-7-alex.kanavin@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2345 bytes --]

On Wed, Mar 27, 2019 at 03:09:21PM +0100, Alexander Kanavin wrote:
> Also, update PV to match the version scheme used by upstream
> to tag releases (e.g. major.minor.patch).
> 
> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>  meta/recipes-devtools/llvm/llvm_git.bb | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/recipes-devtools/llvm/llvm_git.bb b/meta/recipes-devtools/llvm/llvm_git.bb
> index d2ea927651d..d1832e03f71 100644
> --- a/meta/recipes-devtools/llvm/llvm_git.bb
> +++ b/meta/recipes-devtools/llvm/llvm_git.bb
> @@ -19,18 +19,14 @@ PROVIDES += "llvm${PV}"
>  LLVM_RELEASE = "${PV}"
>  LLVM_DIR = "llvm${LLVM_RELEASE}"
>  
> -# SRCREV is set to the revision of 8.0.0-rc2 tag, while latest release
> -# tag is 7.0.1 as of Feb 18 2019, hence the need for UPSTREAM_CHECK_UNKNOWN
> -# Remove the UPSTREAM_VERSION_UNKNOWN line once 8.0.0 final is tagged
> -UPSTREAM_VERSION_UNKNOWN = "1"
> -SRCREV = "98ebe7460199b9cd79eb562b5e8705ad28f5513f"
> +SRCREV = "d2298e74235598f15594fe2c99bbac870a507c59"

Are you intentionally using d2298e74235598f15594fe2c99bbac870a507c59
instead of the SRCREV of the annotated tag llvmorg-8.0.0?

llvm-project $ git show-ref -d llvmorg-8.0.0
8474bc915331b2b7851fcad74f510803f0989b8b refs/tags/llvmorg-8.0.0
d2298e74235598f15594fe2c99bbac870a507c59 refs/tags/llvmorg-8.0.0^{}

I know that many projects don't use annotated tags, but if there is one
it would be nice to use that (so that it's easier to verify that the
SRCREV really matches with the tag).

>  BRANCH = "release/${MAJOR_VERSION}.x"
>  MAJOR_VERSION = "8"
>  MINOR_VERSION = "0"
>  PATCH_VERSION = "0"
>  SOLIBVER = "1"
> -PV = "${MAJOR_VERSION}.${MINOR_VERSION}"
> +PV = "${MAJOR_VERSION}.${MINOR_VERSION}.${PATCH_VERSION}"
>  SRC_URI = "git://github.com/llvm/llvm-project.git;branch=${BRANCH} \
>             file://0001-llvm-TargetLibraryInfo-Undefine-libc-functions-if-th.patch \
>             file://0002-llvm-allow-env-override-of-exe-path.patch \
> -- 
> 2.17.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]