From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50A84C43381 for ; Wed, 27 Mar 2019 18:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16E59217D9 for ; Wed, 27 Mar 2019 18:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553710071; bh=WwdVZgGGO49Ql0Yky44C0CnNOZ0SpZ/J/QDO9zN7mWA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=n8dOvXSahxo5NW0oGoDkc0ZtrDait8di8zdTgHR/wghDjON8Dai0n7Bk4xW1ki7Hc NxyeHZgsM19tEpjpdhTPzK4fPFAi6VD4DpMAvsBDqGHHvfo80jS9xsrWBhEYGC0QIJ 8WDyEv4cGAKFQGYoDItP9RdOWkQybg+GxSIgk8RQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388249AbfC0SHt (ORCPT ); Wed, 27 Mar 2019 14:07:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:49656 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388241AbfC0SHq (ORCPT ); Wed, 27 Mar 2019 14:07:46 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C23F321734; Wed, 27 Mar 2019 18:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553710065; bh=WwdVZgGGO49Ql0Yky44C0CnNOZ0SpZ/J/QDO9zN7mWA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rJOiakgwmlGzMGivcHkMHiCCoa06NcbCRYYUBO+xXdg7E9no4pG2vFYJu6Qh2ix9u 10MYk3GhdPpqZl3ojEn84yB/6ORCaNrqjAMRd4ZI13ci37kUb1i+exPH6tlJIjnDHt /15lfNgOI0fkzIwjtj+O93sD/WC0nCwDinxuJyRg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stefan Roese , Mark Brown , Sankalp Negi , Chuanhong Guo , John Crispin , Greg Kroah-Hartman , Sasha Levin , devel@driverdev.osuosl.org Subject: [PATCH AUTOSEL 5.0 181/262] staging: spi: mt7621: Add return code check on device_reset() Date: Wed, 27 Mar 2019 14:00:36 -0400 Message-Id: <20190327180158.10245-181-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190327180158.10245-1-sashal@kernel.org> References: <20190327180158.10245-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stefan Roese [ Upstream commit 46c337872f34bc6387b0c29a4964f562c70139e3 ] This patch adds a return code check on device_reset() and removes the compile warning. Signed-off-by: Stefan Roese Cc: Mark Brown Cc: Sankalp Negi Cc: Chuanhong Guo Cc: John Crispin Reviewed-by: NeilBrown Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/mt7621-spi/spi-mt7621.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c index 513b6e79b985..e1f50efd0922 100644 --- a/drivers/staging/mt7621-spi/spi-mt7621.c +++ b/drivers/staging/mt7621-spi/spi-mt7621.c @@ -330,6 +330,7 @@ static int mt7621_spi_probe(struct platform_device *pdev) int status = 0; struct clk *clk; struct mt7621_spi_ops *ops; + int ret; match = of_match_device(mt7621_spi_match, &pdev->dev); if (!match) @@ -377,7 +378,11 @@ static int mt7621_spi_probe(struct platform_device *pdev) rs->pending_write = 0; dev_info(&pdev->dev, "sys_freq: %u\n", rs->sys_freq); - device_reset(&pdev->dev); + ret = device_reset(&pdev->dev); + if (ret) { + dev_err(&pdev->dev, "SPI reset failed!\n"); + return ret; + } mt7621_spi_reset(rs); -- 2.19.1