From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH AUTOSEL 5.0 220/262] drm/vkms: Fix flush_work() without INIT_WORK(). Date: Wed, 27 Mar 2019 14:01:15 -0400 Message-ID: <20190327180158.10245-220-sashal@kernel.org> References: <20190327180158.10245-1-sashal@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BC456E27F for ; Wed, 27 Mar 2019 18:09:12 +0000 (UTC) In-Reply-To: <20190327180158.10245-1-sashal@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tetsuo Handa , Daniel Vetter , dri-devel@lists.freedesktop.org, Sasha Levin List-Id: dri-devel@lists.freedesktop.org RnJvbTogVGV0c3VvIEhhbmRhIDxwZW5ndWluLWtlcm5lbEBJLWxvdmUuU0FLVVJBLm5lLmpwPgoK WyBVcHN0cmVhbSBjb21taXQgYjMwYjYxZmY2YjFkYzM3ZjI3NmNmNTZhODMyOGI4MDA4NmEzZmZj YSBdCgpzeXpib3QgaXMgaGl0dGluZyBhIGxvY2tkZXAgd2FybmluZyBbMV0gYmVjYXVzZSBmbHVz aF93b3JrKCkgaXMgY2FsbGVkCndpdGhvdXQgSU5JVF9XT1JLKCkgYWZ0ZXIga3phbGxvYygpIGF0 IHZrbXNfYXRvbWljX2NydGNfcmVzZXQoKS4KCkNvbW1pdCA2YzIzNGZlMzdjNTc2MjdhICgiZHJt L3ZrbXM6IEltcGxlbWVudCBDUkMgZGVidWdmcyBBUEkiKSBhZGRlZApJTklUX1dPUksoKSB0byBv bmx5IHZrbXNfYXRvbWljX2NydGNfZHVwbGljYXRlX3N0YXRlKCkgc2lkZS4gQXNzdW1pbmcKdGhh dCBsaWZlY3ljbGUgb2YgY3JjX3dvcmsgaXMgYXBwcm9wcmlhdGVseSBtYW5hZ2VkLCBmaXggdGhp cyBwcm9ibGVtCmJ5IGFkZGluZyBJTklUX1dPUksoKSB0byB2a21zX2F0b21pY19jcnRjX3Jlc2V0 KCkgc2lkZS4KClsxXSBodHRwczovL3N5emthbGxlci5hcHBzcG90LmNvbS9idWc/aWQ9YTU5NTQ0 NTVmY2ZhNTFjMjljYTJhYjU1YjIwMzA3NjMzN2UxYzc3MAoKUmVwb3J0ZWQtYW5kLXRlc3RlZC1i eTogc3l6Ym90IDxzeXpib3QrMTJmMWIwMzFiNmRhMDE3ZTM0ZjhAc3l6a2FsbGVyLmFwcHNwb3Rt YWlsLmNvbT4KU2lnbmVkLW9mZi1ieTogVGV0c3VvIEhhbmRhIDxwZW5ndWluLWtlcm5lbEBJLWxv dmUuU0FLVVJBLm5lLmpwPgpSZXZpZXdlZC1ieTogU2hheWVubmUgTW91cmEgPHNoYXllbm5lbHV6 bW91cmFAZ21haWwuY29tPgpTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0 dGVyQGZmd2xsLmNoPgpMaW5rOiBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0 Y2gvbXNnaWQvMTU0NzgyOTgyMy05ODc3LTEtZ2l0LXNlbmQtZW1haWwtcGVuZ3Vpbi1rZXJuZWxA SS1sb3ZlLlNBS1VSQS5uZS5qcApTaWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZpbiA8c2FzaGFsQGtl cm5lbC5vcmc+Ci0tLQogZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19jcnRjLmMgfCAxICsKIDEg ZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS92a21zL3ZrbXNfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL3ZrbXMvdmttc19jcnRjLmMKaW5k ZXggYTBiZWY3ZGU5ZGY3Li4xMDU0ZjUzNTE3OGEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS92a21zL3ZrbXNfY3J0Yy5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS92a21zL3ZrbXNfY3J0Yy5j CkBAIC05NSw2ICs5NSw3IEBAIHN0YXRpYyB2b2lkIHZrbXNfYXRvbWljX2NydGNfcmVzZXQoc3Ry dWN0IGRybV9jcnRjICpjcnRjKQogCXZrbXNfc3RhdGUgPSBremFsbG9jKHNpemVvZigqdmttc19z dGF0ZSksIEdGUF9LRVJORUwpOwogCWlmICghdmttc19zdGF0ZSkKIAkJcmV0dXJuOworCUlOSVRf V09SSygmdmttc19zdGF0ZS0+Y3JjX3dvcmssIHZrbXNfY3JjX3dvcmtfaGFuZGxlKTsKIAogCWNy dGMtPnN0YXRlID0gJnZrbXNfc3RhdGUtPmJhc2U7CiAJY3J0Yy0+c3RhdGUtPmNydGMgPSBjcnRj OwotLSAKMi4xOS4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 865EEC4360F for ; Wed, 27 Mar 2019 18:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48BAD2183F for ; Wed, 27 Mar 2019 18:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553710159; bh=6TRaSxgQjJ78zgKBLjuZr9V1KfYyKpvXETRlkqiJE+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PFYQazua4zaE7V+7Ry4eyxc3t39UQ1Mwu7PW2g6IkW7oT8XFYNhuZ8HynMMj3ThOM SIuqHwrysbk8C9mAyWdvWPowj8ERmMe9//aZwYVa3+aR3JynPE9aehfhc31n0f7L5Y 4Y4pkaGR2cQqILrf5Oh2rnhOp1/jkfSYjBikbWNM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388134AbfC0SJS (ORCPT ); Wed, 27 Mar 2019 14:09:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:51016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388514AbfC0SJM (ORCPT ); Wed, 27 Mar 2019 14:09:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58F07217F9; Wed, 27 Mar 2019 18:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553710152; bh=6TRaSxgQjJ78zgKBLjuZr9V1KfYyKpvXETRlkqiJE+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AcUHQEUFqydYTArK5WapHMSU+AqcYwfC2oxSjyWgK4azOy4MPHrST+KBerm+iSOGL lJYKymnqoUAr5SMMDqHU4gxJefJxoimIBp4Bbf10b2JRNLuaw2ODgFrAYJSUyhgdm1 3MrWxslyIu63kYDDDplf1Hmdx+pq0uQ2vMSSLNyI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tetsuo Handa , Daniel Vetter , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.0 220/262] drm/vkms: Fix flush_work() without INIT_WORK(). Date: Wed, 27 Mar 2019 14:01:15 -0400 Message-Id: <20190327180158.10245-220-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190327180158.10245-1-sashal@kernel.org> References: <20190327180158.10245-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tetsuo Handa [ Upstream commit b30b61ff6b1dc37f276cf56a8328b80086a3ffca ] syzbot is hitting a lockdep warning [1] because flush_work() is called without INIT_WORK() after kzalloc() at vkms_atomic_crtc_reset(). Commit 6c234fe37c57627a ("drm/vkms: Implement CRC debugfs API") added INIT_WORK() to only vkms_atomic_crtc_duplicate_state() side. Assuming that lifecycle of crc_work is appropriately managed, fix this problem by adding INIT_WORK() to vkms_atomic_crtc_reset() side. [1] https://syzkaller.appspot.com/bug?id=a5954455fcfa51c29ca2ab55b203076337e1c770 Reported-and-tested-by: syzbot Signed-off-by: Tetsuo Handa Reviewed-by: Shayenne Moura Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/1547829823-9877-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp Signed-off-by: Sasha Levin --- drivers/gpu/drm/vkms/vkms_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c index a0bef7de9df7..1054f535178a 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -95,6 +95,7 @@ static void vkms_atomic_crtc_reset(struct drm_crtc *crtc) vkms_state = kzalloc(sizeof(*vkms_state), GFP_KERNEL); if (!vkms_state) return; + INIT_WORK(&vkms_state->crc_work, vkms_crc_work_handle); crtc->state = &vkms_state->base; crtc->state->crtc = crtc; -- 2.19.1