From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFF6C43381 for ; Wed, 27 Mar 2019 18:19:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF98B2063F for ; Wed, 27 Mar 2019 18:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553710786; bh=kyuPe6LLAT2VYnpQrQJqfBLWMDmmenAa1jSpaUXaeeQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NpHo/5l2VfIPkwP/Wg9r54bxJrERVm5Zb5wqoZuGW6YJVr4yvkFf2yEvOxZCkzJlZ 3yCH5EvUMuiCcKfPbkWPQm3L29XPrxVJ9KCKPbuGH0KK5moILQJ8TgZyaC+lCr3oP6 On2MHN1uMsIajLcYsHjZuUwtf+BeNX9RSTeSV/1o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390758AbfC0STp (ORCPT ); Wed, 27 Mar 2019 14:19:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:37044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390743AbfC0STj (ORCPT ); Wed, 27 Mar 2019 14:19:39 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF4EB2063F; Wed, 27 Mar 2019 18:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553710778; bh=kyuPe6LLAT2VYnpQrQJqfBLWMDmmenAa1jSpaUXaeeQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ePI+v8VKASxIV7hZOA9RgcUt4LSA9vF8XTBaop78/3oGo/Dne2Bil7vOp9OrUtn72 4LULnPq5lpZpquzz6ywXyaY9RyFTV6dsG4c73pFM5pWSMszruhvaPOPqW+Eq1PclQ7 M9ukY71NfQLlBOYpKXq2QX9JZog5hhDW8rpzF/Wg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Manfred Schlaegl , Martin Kepplinger , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 097/123] tty: increase the default flip buffer limit to 2*640K Date: Wed, 27 Mar 2019 14:16:01 -0400 Message-Id: <20190327181628.15899-97-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190327181628.15899-1-sashal@kernel.org> References: <20190327181628.15899-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manfred Schlaegl [ Upstream commit 7ab57b76ebf632bf2231ccabe26bea33868118c6 ] We increase the default limit for buffer memory allocation by a factor of 10 to 640K to prevent data loss when using fast serial interfaces. For example when using RS485 without flow-control at speeds of 1Mbit/s an upwards we've run into problems such as applications being too slow to read out this buffer (on embedded devices based on imx53 or imx6). If you want to write transmitted data to a slow SD card and thus have realtime requirements, this limit can become a problem. That shouldn't be the case and 640K buffers fix such problems for us. This value is a maximum limit for allocation only. It has no effect on systems that currently run fine. When transmission is slow enough applications and hardware can keep up and increasing this limit doesn't change anything. It only _allows_ to allocate more than 2*64K in cases we currently fail to allocate memory despite having some. Signed-off-by: Manfred Schlaegl Signed-off-by: Martin Kepplinger Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/tty_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c index 217114227f8d..cf11882d2602 100644 --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty/tty_buffer.c @@ -25,7 +25,7 @@ * Byte threshold to limit memory consumption for flip buffers. * The actual memory limit is > 2x this amount. */ -#define TTYB_DEFAULT_MEM_LIMIT 65536 +#define TTYB_DEFAULT_MEM_LIMIT (640 * 1024UL) /* * We default to dicing tty buffer allocations to this many characters -- 2.19.1