From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] pinctrl: intel: save HOSTSW_OWN register over suspend/resume Date: Thu, 28 Mar 2019 10:28:24 +0200 Message-ID: <20190328082824.GU3622@lahna.fi.intel.com> References: <20171116124431.GS17200@lahna.fi.intel.com> <20171117064904.GZ17200@lahna.fi.intel.com> <20171121105205.GP22431@lahna.fi.intel.com> <20171121120422.GR22431@lahna.fi.intel.com> <20190327172940.GR3622@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190327172940.GR3622@lahna.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Drake Cc: Chris Chiu , Heikki Krogerus , Linus Walleij , "open list:PIN CONTROL SUBSYSTEM" , Linux Kernel , Linux Upstreaming Team , Andy Shevchenko List-Id: linux-gpio@vger.kernel.org On Wed, Mar 27, 2019 at 07:29:40PM +0200, Mika Westerberg wrote: > I wonder if it would be simpler to save it always and then upon resume > compare them and if changed, log this in dmesg and restore the saved > one. Actually I think better is to restore hostsw_own only for GPIOs that are already requested by us. The BIOS should have no business messing those anyway once they are owned by the GPIO driver.