From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7635AC43381 for ; Thu, 28 Mar 2019 14:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45F1A20823 for ; Thu, 28 Mar 2019 14:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="dWQHdM/B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbfC1Oeq (ORCPT ); Thu, 28 Mar 2019 10:34:46 -0400 Received: from mail.skyhub.de ([5.9.137.197]:40676 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbfC1Oep (ORCPT ); Thu, 28 Mar 2019 10:34:45 -0400 Received: from zn.tnic (p200300EC2F098000329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:8000:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8D4B01EC02C1; Thu, 28 Mar 2019 15:34:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1553783684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=QAGGfwHtYXEKN05a0z6wghw/+0YMt2AfLM0cDt8uyc8=; b=dWQHdM/Bx9ouwkWaB+xtf/hfE7WP1MwHKkvTM6/qvejJ4cZ29D0qX8rk9F9jJY1sTPVEDy 2QztCSan8CvUedvOKlMt+LPUodessxYJ9yXPjZTuszAYFkgGIk9AqUk2r/YAv/MOqWfhGu gFEaoLEMw/HvxZKmkzb4UfbFHvuaYow= Date: Thu, 28 Mar 2019 15:34:47 +0100 From: Borislav Petkov To: Andy Shevchenko Cc: "H. Peter Anvin" , x86@kernel.org, Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] x86/boot: Introduce helpers for serial I/O Message-ID: <20190328143447.GN22720@zn.tnic> References: <20190319184325.72807-1-andriy.shevchenko@linux.intel.com> <20190319184325.72807-3-andriy.shevchenko@linux.intel.com> <20190328123250.GE22720@zn.tnic> <20190328131140.GX9224@smile.fi.intel.com> <20190328132855.GH22720@zn.tnic> <20190328135226.GB9224@smile.fi.intel.com> <20190328140508.GL22720@zn.tnic> <20190328142001.GD9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190328142001.GD9224@smile.fi.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 28, 2019 at 04:20:01PM +0200, Andy Shevchenko wrote: > By name and by what it's handling (only byte accesses to I/O or MMIO). Your series does only byte accesses so you can use byte variant. > My point is, that doing branch(es) on each I/O call is not good as simple > calling the proper (pre-defined) I/O accessor. What branches? You do a branch and *then* you do an IO call. What does "not good" even mean? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.