From: Rob Herring <robh@kernel.org>
To: Carlos Menin <menin@carlosaurelio.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size
Date: Thu, 28 Mar 2019 10:19:08 -0500 [thread overview]
Message-ID: <20190328151908.GA23332@bogus> (raw)
In-Reply-To: <20190313141125.GA26062@carlosaurelio.net>
On Wed, 13 Mar 2019 11:11:26 -0300, Carlos Menin wrote:
> By default, cells in DT are 32-bit in size. The driver reads "ti,mode"
> using the function of_property_read_u8() which causes the value to be
> read incorrectly in little-endian architectures if the size is not
> specified.
>
> Make it explicit in the binding documentation that this prorperty must
> be set as a 8-bit value.
>
> Signed-off-by: Carlos Menin <menin@carlosaurelio.net>
> ---
> Documentation/devicetree/bindings/hwmon/adc128d818.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-03-28 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 14:11 [PATCH] dt-bindings: hwmon: (adc128d818) Specify ti,mode property size Carlos Menin
2019-03-28 15:19 ` Rob Herring [this message]
2019-03-29 16:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328151908.GA23332@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=menin@carlosaurelio.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.