From: Greg KH <gregkh@linuxfoundation.org>
To: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/2] staging: rtlwifi: Remove unused variable.
Date: Thu, 28 Mar 2019 17:08:14 +0100 [thread overview]
Message-ID: <20190328160814.GA30629@kroah.com> (raw)
In-Reply-To: <20190328151007.10650-1-sanjana99reddy99@gmail.com>
On Thu, Mar 28, 2019 at 08:40:07PM +0530, Sanjana Sanikommu wrote:
> Remove unused variable. This variable is
> created unnecessarily for return type whose
> use is removed using ret.cocci.
>
> Signed-off-by: Sanjana Sanikommu <sanjana99reddy99@gmail.com>
> ---
> drivers/staging/rtlwifi/rtl8822be/phy.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtlwifi/rtl8822be/phy.c b/drivers/staging/rtlwifi/rtl8822be/phy.c
> index aed315143cbb..ececfed7b35a 100644
> --- a/drivers/staging/rtlwifi/rtl8822be/phy.c
> +++ b/drivers/staging/rtlwifi/rtl8822be/phy.c
> @@ -1840,7 +1840,6 @@ static long _rtl8822be_phy_txpwr_idx_to_dbm(struct ieee80211_hw *hw,
> u8 txpwridx)
> {
> long offset;
> - long pwrout_dbm;
Did you just cause this warning to happen with patch 1/2? That's not
ok, please put this together with that patch, you can not have any
commit break the build, or add new build warnings.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-28 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 15:07 [PATCH 0/2] staging: rtlwifi: Remove return variable Sanjana Sanikommu
2019-03-28 15:09 ` [PATCH 1/2] " Sanjana Sanikommu
2019-03-28 15:10 ` [PATCH 2/2] staging: rtlwifi: Remove unused variable Sanjana Sanikommu
2019-03-28 16:08 ` Greg KH [this message]
2019-03-28 16:15 ` Sanjana Sanikommu
2019-03-28 16:35 ` [PATCH v2] staging: rtlwifi: Remove return variable Sanjana Sanikommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328160814.GA30629@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=sanjana99reddy99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.