From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [next/testing Lua modules 01/11] luarocks: add generation of test
Date: Thu, 28 Mar 2019 17:22:29 +0100 [thread overview]
Message-ID: <20190328172229.51ddf155@windsurf> (raw)
In-Reply-To: <20190219154311.22173-1-francois.perrad@gadz.org>
Hello Fran?ois,
On Tue, 19 Feb 2019 16:43:01 +0100
Francois Perrad <fperrad@gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/luarocks/buildroot.lua | 60 ++++++++++++++++++++++++++++++++++
> 1 file changed, 60 insertions(+)
I have applied this entire series, thanks! It's going in the good
direction, but I found some odd things.
The lpeg test looks like this:
+ self.module_test("lpeg", script="print(require[[lpeg]].version())")
which clearly cannot have been generated by the Luarocks "buildroot"
script, which does only:
+ f:write(' self.module_test("' .. modname .. '")\n')
Also, I've used "lpeg-upgrade" and "rings-upgrade" as tests, and
noticed some differences:
- self.module_test("lpeg", script="print(require[[lpeg]].version())")
+ self.module_test("LPeg")
So we have the difference I explained above + a difference in the
casing of the module.
We have the same casing difference with rings:
- self.module_test("rings")
+ self.module_test("Rings")
Is this expected ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-03-28 16:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 15:43 [Buildroot] [next/testing Lua modules 01/11] luarocks: add generation of test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 02/11] support/testing: add lpeg test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 03/11] support/testing: add lsqlite3 test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 04/11] support/testing: add lua-curl test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 05/11] support/testing: add lua-utf8 test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 06/11] support/testing: add luaexpat test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 07/11] support/testing: add luafilesystem test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 08/11] support/testing: add luaossl test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 09/11] support/testing: add luasec test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 10/11] support/testing: add luasocket test Francois Perrad
2019-02-19 15:43 ` [Buildroot] [next/testing Lua modules 11/11] support/testing: add rings test Francois Perrad
2019-03-28 16:22 ` Thomas Petazzoni [this message]
2019-03-28 17:13 ` [Buildroot] [next/testing Lua modules 01/11] luarocks: add generation of test François Perrad
2019-03-28 17:22 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328172229.51ddf155@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.