All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 3/3] ARM: dts: imx53: Add Menlosystems M53 board
Date: Fri, 29 Mar 2019 10:47:58 +0800	[thread overview]
Message-ID: <20190329024757.GN12513@dragon> (raw)
In-Reply-To: <7df4b7cf-7206-e7dd-11ba-2e899a33b861@denx.de>

On Tue, Mar 26, 2019 at 05:44:41PM +0100, Marek Vasut wrote:
> On 3/26/19 9:42 AM, Shawn Guo wrote:
> > On Thu, Mar 21, 2019 at 03:56:55AM +0100, Marek Vasut wrote:
> >> Add device tree for the Menlosystems board based on i.MX53 M53 SoM.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Shawn Guo <shawnguo@kernel.org>
> >> Cc: Fabio Estevam <festevam@gmail.com>
> >> Cc: NXP Linux Team <linux-imx@nxp.com>
> >> To: linux-arm-kernel@lists.infradead.org
> >> ---
> >> V2: - Rebase on latest next/master
> >> V3: - Add vendor specific compatible for the platform
> >>     - Rename ledgrp and touchscreen nodes to follow DT spec
> >>     - Update pinmux (LVDS has no pin config, so use default settings)
> >> V4: - Add fsl.yaml entry
> >>     - Pull regulator out of simple bus
> >>     - Rename touchscreen@ node
> >>     - Add reg entry to lvds-channel@0
> >>     - Fix touchscreen interrupt polarity
> >> ---
> >>  .../devicetree/bindings/arm/fsl.yaml          |   1 +
> > 
> > We need to make the bindings a separate patch and be ACK-ed by DT folks.
> 
> Sure.
> 
> >>  arch/arm/boot/dts/Makefile                    |   1 +
> >>  arch/arm/boot/dts/imx53-m53menlo.dts          | 310 ++++++++++++++++++
> >>  3 files changed, 312 insertions(+)
> >>  create mode 100644 arch/arm/boot/dts/imx53-m53menlo.dts
> >>
> 
> [...]
> 
> >> +		pinctrl_lvds0: lvds0grp {
> >> +			fsl,pins = <
> >> +				MX53_PAD_LVDS0_CLK_P__LDB_LVDS0_CLK	0x80000000
> >> +				MX53_PAD_LVDS0_TX0_P__LDB_LVDS0_TX0	0x80000000
> >> +				MX53_PAD_LVDS0_TX1_P__LDB_LVDS0_TX1	0x80000000
> >> +				MX53_PAD_LVDS0_TX2_P__LDB_LVDS0_TX2	0x80000000
> >> +				MX53_PAD_LVDS0_TX3_P__LDB_LVDS0_TX3	0x80000000
> > 
> > Please have proper pad configurations rather than relying on the
> > settings out of reset or set up by bootloader.
> 
> Do you have an example LVDS configuration for the MX53 ? I didn't find
> one, all the other boards just leave the LVDS line configuration in
> default settings.

Sorry, I do not.  If your bootloader doesn't touch the settings, you may
just need to code the reset values from reference manual here?

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-03-29  2:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  2:56 [PATCH V4 1/3] of: Add vendor prefix for Menlo Systems GmbH Marek Vasut
2019-03-21  2:56 ` Marek Vasut
2019-03-21  2:56 ` [PATCH V4 2/3] ARM: dts: imx53: Rename M53 SoM touchscreen node Marek Vasut
2019-03-21  2:56 ` [PATCH V4 3/3] ARM: dts: imx53: Add Menlosystems M53 board Marek Vasut
2019-03-26  8:42   ` Shawn Guo
2019-03-26 16:44     ` Marek Vasut
2019-03-29  2:47       ` Shawn Guo [this message]
2019-04-09 12:49         ` Marek Vasut
2019-04-11  1:49           ` Shawn Guo
2019-04-11  2:30             ` Fabio Estevam
2019-04-11  3:15               ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329024757.GN12513@dragon \
    --to=shawnguo@kernel.org \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.