From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, angus@akkea.ca,
linux-imx@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH] arm64: dts: imx8mq: Move thermal-zones out of bus node
Date: Fri, 29 Mar 2019 11:10:15 +0800 [thread overview]
Message-ID: <20190329031014.GO12513@dragon> (raw)
In-Reply-To: <20190325151959.31883-1-festevam@gmail.com>
On Mon, Mar 25, 2019 at 12:19:59PM -0300, Fabio Estevam wrote:
> thermal-zones node does not have any register properties and thus
> shouldn't be placed inside the bus.
>
> Move thermal-zones node from soc node to root node in order to fix
> the following build warning with W=1:
>
> arch/arm64/boot/dts/freescale/imx8mq.dtsi:305.18-364.6: Warning (simple_bus_reg): /soc@0/bus@30000000/thermal-zones: missing or empty reg/ranges property
>
> Fixes: e464fd2ba4d4 ("arm64: dts: imx8mq: enable the multi sensor TMU")
My branches could be rebased, so the commit id is not really stable. I
dropped the tag and applied the patch.
Shawn
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 122 +++++++++++-----------
> 1 file changed, 61 insertions(+), 61 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 230f198ad87a..feb195984997 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -167,6 +167,67 @@
> method = "smc";
> };
>
> + thermal-zones {
> + cpu-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <2000>;
> + thermal-sensors = <&tmu 0>;
> +
> + trips {
> + cpu_alert: cpu-alert {
> + temperature = <80000>;
> + hysteresis = <2000>;
> + type = "passive";
> + };
> +
> + cpu-crit {
> + temperature = <90000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> +
> + cooling-maps {
> + map0 {
> + trip = <&cpu_alert>;
> + cooling-device =
> + <&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&A53_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&A53_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> + <&A53_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> + };
> + };
> + };
> +
> + gpu-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <2000>;
> + thermal-sensors = <&tmu 1>;
> +
> + trips {
> + gpu-crit {
> + temperature = <90000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> +
> + vpu-thermal {
> + polling-delay-passive = <250>;
> + polling-delay = <2000>;
> + thermal-sensors = <&tmu 2>;
> +
> + trips {
> + vpu-crit {
> + temperature = <90000>;
> + hysteresis = <2000>;
> + type = "critical";
> + };
> + };
> + };
> + };
> +
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>, /* Physical Secure */
> @@ -302,67 +363,6 @@
> #thermal-sensor-cells = <1>;
> };
>
> - thermal-zones {
> - cpu-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <2000>;
> - thermal-sensors = <&tmu 0>;
> -
> - trips {
> - cpu_alert: cpu-alert {
> - temperature = <80000>;
> - hysteresis = <2000>;
> - type = "passive";
> - };
> -
> - cpu-crit {
> - temperature = <90000>;
> - hysteresis = <2000>;
> - type = "critical";
> - };
> - };
> -
> - cooling-maps {
> - map0 {
> - trip = <&cpu_alert>;
> - cooling-device =
> - <&A53_0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&A53_1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&A53_2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> - <&A53_3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> - };
> - };
> - };
> -
> - gpu-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <2000>;
> - thermal-sensors = <&tmu 1>;
> -
> - trips {
> - gpu-crit {
> - temperature = <90000>;
> - hysteresis = <2000>;
> - type = "critical";
> - };
> - };
> - };
> -
> - vpu-thermal {
> - polling-delay-passive = <250>;
> - polling-delay = <2000>;
> - thermal-sensors = <&tmu 2>;
> -
> - trips {
> - vpu-crit {
> - temperature = <90000>;
> - hysteresis = <2000>;
> - type = "critical";
> - };
> - };
> - };
> - };
> -
> wdog1: watchdog@30280000 {
> compatible = "fsl,imx8mq-wdt", "fsl,imx21-wdt";
> reg = <0x30280000 0x10000>;
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-03-29 3:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 15:19 [PATCH] arm64: dts: imx8mq: Move thermal-zones out of bus node Fabio Estevam
2019-03-29 3:10 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329031014.GO12513@dragon \
--to=shawnguo@kernel.org \
--cc=angus@akkea.ca \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.