From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/6] ARM: davinci: omapl138-hawk: add a fixed regulator for ohci-da8xx From: Bartosz Golaszewski Message-Id: <20190329093334.3885-5-brgl@bgdev.pl> Date: Fri, 29 Mar 2019 10:33:32 +0100 To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bartosz Golaszewski List-ID: RnJvbTogQmFydG9zeiBHb2xhc3pld3NraSA8YmdvbGFzemV3c2tpQGJheWxpYnJlLmNvbT4KCklu c3RlYWQgb2YgZGlyZWN0bHkgdXNpbmcgdGhlIHZidXMgR1BJTyB3ZSBzaG91bGQgbW9kZWwgaXQg YXMgYSBmaXhlZApyZWd1bGF0b3IuIEFkZCBhbGwgbmVjZXNzYXJ5IGZpeC11cHMgZm9yIHRoZSBy ZWd1bGF0b3IgdG8gYmUgcmVnaXN0ZXJlZAphbmQgY29uZmlndXJlIHRoZSB2YnVzIEdQSU8gYXMg aXRzIGVuYWJsZSBwaW4uCgpTaWduZWQtb2ZmLWJ5OiBCYXJ0b3N6IEdvbGFzemV3c2tpIDxiZ29s YXN6ZXdza2lAYmF5bGlicmUuY29tPgotLS0KIGFyY2gvYXJtL21hY2gtZGF2aW5jaS9ib2FyZC1v bWFwbDEzOC1oYXdrLmMgfCA0OSArKysrKysrKysrKysrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2Vk LCA0NiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJt L21hY2gtZGF2aW5jaS9ib2FyZC1vbWFwbDEzOC1oYXdrLmMgYi9hcmNoL2FybS9tYWNoLWRhdmlu Y2kvYm9hcmQtb21hcGwxMzgtaGF3ay5jCmluZGV4IGUyNDRjODY0ODU5NC4uMDAzOWI0ZDRjOTM1 IDEwMDY0NAotLS0gYS9hcmNoL2FybS9tYWNoLWRhdmluY2kvYm9hcmQtb21hcGwxMzgtaGF3ay5j CisrKyBiL2FyY2gvYXJtL21hY2gtZGF2aW5jaS9ib2FyZC1vbWFwbDEzOC1oYXdrLmMKQEAgLTIx LDYgKzIxLDcgQEAKICNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kYXRhL210ZC1kYXZpbmNpLmg+ CiAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGF0YS9tdGQtZGF2aW5jaS1hZW1pZi5oPgogI2lu Y2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RhdGEvdGktYWVtaWYuaD4KKyNpbmNsdWRlIDxsaW51eC9y ZWd1bGF0b3IvZml4ZWQuaD4KICNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvbWFjaGluZS5oPgog CiAjaW5jbHVkZSA8YXNtL21hY2gtdHlwZXMuaD4KQEAgLTI5OCwxNSArMjk5LDUwIEBAIHN0YXRp YyBjb25zdCBzaG9ydCBkYTg1MF9oYXdrX3VzYjExX3BpbnNbXSA9IHsKIAktMQogfTsKIAotc3Rh dGljIHN0cnVjdCBncGlvZF9sb29rdXBfdGFibGUgaGF3a191c2JfZ3Bpb19sb29rdXAgPSB7Citz dGF0aWMgc3RydWN0IHJlZ3VsYXRvcl9jb25zdW1lcl9zdXBwbHkgaGF3a191c2Jfc3VwcGxpZXNb XSA9IHsKKwlSRUdVTEFUT1JfU1VQUExZKCJ2YnVzIiwgTlVMTCksCit9OworCitzdGF0aWMgc3Ry dWN0IHJlZ3VsYXRvcl9pbml0X2RhdGEgaGF3a191c2JfdmJ1c19kYXRhID0geworCS5jb25zdW1l cl9zdXBwbGllcwk9IGhhd2tfdXNiX3N1cHBsaWVzLAorCS5udW1fY29uc3VtZXJfc3VwcGxpZXMJ PSBBUlJBWV9TSVpFKGhhd2tfdXNiX3N1cHBsaWVzKSwKK307CisKK3N0YXRpYyBzdHJ1Y3QgZml4 ZWRfdm9sdGFnZV9jb25maWcgaGF3a191c2JfdmJ1cyA9IHsKKwkuc3VwcGx5X25hbWUJCT0gInZi dXMiLAorCS5taWNyb3ZvbHRzCQk9IDMzMDAwMDAsCisJLmluaXRfZGF0YQkJPSAmaGF3a191c2Jf dmJ1c19kYXRhLAorfTsKKworc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgaGF3a191c2Jf dmJ1c19kZXZpY2UgPSB7CisJLm5hbWUJCT0gInJlZy1maXhlZC12b2x0YWdlIiwKKwkuaWQJCT0g MSwKKwkuZGV2CQk9IHsKKwkJLnBsYXRmb3JtX2RhdGEgPSAmaGF3a191c2JfdmJ1cywKKwl9LAor fTsKKworc3RhdGljIHN0cnVjdCBncGlvZF9sb29rdXBfdGFibGUgaGF3a191c2Jfb2NfZ3Bpb19s b29rdXAgPSB7CiAJLmRldl9pZAkJPSAib2hjaS1kYTh4eCIsCiAJLnRhYmxlID0gewotCQlHUElP X0xPT0tVUCgiZGF2aW5jaV9ncGlvIiwgREE4NTBfVVNCMV9WQlVTX1BJTiwgInZidXMiLCAwKSwK IAkJR1BJT19MT09LVVAoImRhdmluY2lfZ3BpbyIsIERBODUwX1VTQjFfT0NfUElOLCAib2MiLCAw KSwKIAkJeyB9CiAJfSwKIH07CiAKK3N0YXRpYyBzdHJ1Y3QgZ3Bpb2RfbG9va3VwX3RhYmxlIGhh d2tfdXNiX3ZidXNfZ3Bpb19sb29rdXAgPSB7CisJLmRldl9pZAkJPSAicmVnLWZpeGVkLXZvbHRh Z2UuMSIsCisJLnRhYmxlID0geworCQlHUElPX0xPT0tVUCgiZGF2aW5jaV9ncGlvIiwgREE4NTBf VVNCMV9WQlVTX1BJTiwgTlVMTCwgMCksCisJCXsgfQorCX0sCit9OworCitzdGF0aWMgc3RydWN0 IGdwaW9kX2xvb2t1cF90YWJsZSAqaGF3a191c2JfZ3Bpb19sb29rdXBzW10gPSB7CisJJmhhd2tf dXNiX29jX2dwaW9fbG9va3VwLAorCSZoYXdrX3VzYl92YnVzX2dwaW9fbG9va3VwLAorfTsKKwog c3RhdGljIHN0cnVjdCBkYTh4eF9vaGNpX3Jvb3RfaHViIG9tYXBsMTM4X2hhd2tfdXNiMTFfcGRh dGEgPSB7CiAJLyogVFBTMjA4NyBzd2l0Y2ggQCA1ViAqLwogCS5wb3RwZ3QgICAgICAgICA9ICgz ICsgMSkgLyAyLCAgLyogMyBtcyBtYXggKi8KQEAgLTMyNywxMiArMzYzLDE5IEBAIHN0YXRpYyBf X2luaXQgdm9pZCBvbWFwbDEzOF9oYXdrX3VzYl9pbml0KHZvaWQpCiAJCXByX3dhcm4oIiVzOiBV U0IgUEhZIENMSyByZWdpc3RyYXRpb24gZmFpbGVkOiAlZFxuIiwKIAkJCV9fZnVuY19fLCByZXQp OwogCisJZ3Bpb2RfYWRkX2xvb2t1cF90YWJsZXMoaGF3a191c2JfZ3Bpb19sb29rdXBzLAorCQkJ CUFSUkFZX1NJWkUoaGF3a191c2JfZ3Bpb19sb29rdXBzKSk7CisKIAlyZXQgPSBkYTh4eF9yZWdp c3Rlcl91c2JfcGh5KCk7CiAJaWYgKHJldCkKIAkJcHJfd2FybigiJXM6IFVTQiBQSFkgcmVnaXN0 cmF0aW9uIGZhaWxlZDogJWRcbiIsCiAJCQlfX2Z1bmNfXywgcmV0KTsKIAotCWdwaW9kX2FkZF9s b29rdXBfdGFibGUoJmhhd2tfdXNiX2dwaW9fbG9va3VwKTsKKwlyZXQgPSBwbGF0Zm9ybV9kZXZp Y2VfcmVnaXN0ZXIoJmhhd2tfdXNiX3ZidXNfZGV2aWNlKTsKKwlpZiAocmV0KSB7CisJCXByX3dh cm4oIiVzOiBVbmFibGUgdG8gcmVnaXN0ZXIgdGhlIHZidXMgc3VwcGx5XG4iLCBfX2Z1bmNfXyk7 CisJCXJldHVybjsKKwl9CiAKIAlyZXQgPSBkYTh4eF9yZWdpc3Rlcl91c2IxMSgmb21hcGwxMzhf aGF3a191c2IxMV9wZGF0YSk7CiAJaWYgKHJldCkK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3E7C43381 for ; Fri, 29 Mar 2019 09:34:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71CCB20643 for ; Fri, 29 Mar 2019 09:34:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YKHCUO9N"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="D0JHjCon" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71CCB20643 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Pb9UBtZm6fpEQho5hylk7/Unao1o6IcH12DKcsbt90=; b=YKHCUO9NvTPg49 7sIcJE0SLvbOKqMAQtnbpokaPiGX+vk6TExX1Th0S6S1HfqIKTaPc9yk6d0/c+bK2OX3ZBRqOfyOF rAjZNLjX2XK2aY3+LxDCStiLLHoKb+rSlu6BrUtGMmh+1Y16ri+zX5MWrA77j7IOSfglsOiEw13Ro mIscOx6Cng8uRy8W9z+/O8+M8PV1lelgrMKFbaf/ALWPZ7Qrj/Y8S2ftSoXMNOmSLUevPv2f2JqwQ Enjkzapk7Bh+5ZlPENEF9lZ0t3PKIhJbqOzjpRsT0DUuw0npCUzyllPpcNg/zPZwI9adDgxOUEsHf QFFuOZ3t1XFXiNCZkI3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9nuC-0002RD-Az; Fri, 29 Mar 2019 09:34:32 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9ntU-0001V5-3b for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 09:33:50 +0000 Received: by mail-wm1-x343.google.com with SMTP id h18so1976036wml.1 for ; Fri, 29 Mar 2019 02:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JM1IFJaq9Fzy9jb7gkxjcG7uHNdo0C9cZXORwZYID2s=; b=D0JHjConPyyO0cRxQv1PUTZqVI3WTeq57J3FAP2XyHi2rJUUNI5ZC5L7oc/E6tlcJN pKNHgYGDM1aPFyKvAHOx5g33iVr1PTs45fCR7PCDPkoMwaK3YfH7RUk2J3PBNkEA4rBx sYENWcWooDcJodHMYVS5WMlwCz84djynJF+xtLKkE856uw5WapRrfx8t5I/axUlT05el Z28geVAWnsVKjM6IiysviN72ZTQI5oAQAAgMrm8iM9YB/HhM7CiR+4s/ZaZHhKAFbuf/ Gajlg7u54ny33L+HlpaZvMnZhVpGiBVJahmZS8Qsum5UFEK40GnEuuS3GpBfj74Ty3x+ hdng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JM1IFJaq9Fzy9jb7gkxjcG7uHNdo0C9cZXORwZYID2s=; b=DRYpLdhisWUf0GIGCAaRr8tzI9apZJyZ2kQ04Edu9S8PT7G74jym8pisaw3bWfmU42 Ohix53HR4FBbl2g6wHQeBal13ecoU+UPDWqOUxkV6BYbDOv0gGyUcQB62rMmAL1DUmXN 2r2MDeqZcOXUnDQsyAgmZGbsK3GBZ73SpkpH22gwyleDuEg3PdWdDrFsg6KiDv3gyu+f tRpkXiI04++gXDxe85YSqjqZZyfW87xylp5Hecz+Ujs5UOjKZX1vDwL/fzk1c9cS+VK1 B/j2ExOY75Fsju8oweRL25K/z5j1fRjEm7fRG8OpsHdI41HvnQJEbWFupTa9dVWOGboI Kp8g== X-Gm-Message-State: APjAAAVfYcq1znqwz2WJAU0lscEUfGpn8jjws4k+AFrMmMbtXoZS9T2x BpCmVx0XadxkDa6wcQFCUzdkWdq4/Gg= X-Google-Smtp-Source: APXvYqxBhAX2VClwpi4aYDKKs3DFdRs9olKE3HhUScClXiKL60lGO7CW7XC2L6AlxrsLRV/60+rvBw== X-Received: by 2002:a1c:f115:: with SMTP id p21mr3028614wmh.93.1553852026829; Fri, 29 Mar 2019 02:33:46 -0700 (PDT) Received: from localhost.localdomain (aputeaux-684-1-29-77.w90-86.abo.wanadoo.fr. [90.86.254.77]) by smtp.gmail.com with ESMTPSA id s12sm1957125wmj.42.2019.03.29.02.33.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 02:33:46 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Subject: [PATCH v2 4/6] ARM: davinci: omapl138-hawk: add a fixed regulator for ohci-da8xx Date: Fri, 29 Mar 2019 10:33:32 +0100 Message-Id: <20190329093334.3885-5-brgl@bgdev.pl> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190329093334.3885-1-brgl@bgdev.pl> References: <20190329093334.3885-1-brgl@bgdev.pl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190329_023348_322549_FC0FF59E X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Instead of directly using the vbus GPIO we should model it as a fixed regulator. Add all necessary fix-ups for the regulator to be registered and configure the vbus GPIO as its enable pin. Signed-off-by: Bartosz Golaszewski --- arch/arm/mach-davinci/board-omapl138-hawk.c | 49 +++++++++++++++++++-- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c index e244c8648594..0039b4d4c935 100644 --- a/arch/arm/mach-davinci/board-omapl138-hawk.c +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include @@ -298,15 +299,50 @@ static const short da850_hawk_usb11_pins[] = { -1 }; -static struct gpiod_lookup_table hawk_usb_gpio_lookup = { +static struct regulator_consumer_supply hawk_usb_supplies[] = { + REGULATOR_SUPPLY("vbus", NULL), +}; + +static struct regulator_init_data hawk_usb_vbus_data = { + .consumer_supplies = hawk_usb_supplies, + .num_consumer_supplies = ARRAY_SIZE(hawk_usb_supplies), +}; + +static struct fixed_voltage_config hawk_usb_vbus = { + .supply_name = "vbus", + .microvolts = 3300000, + .init_data = &hawk_usb_vbus_data, +}; + +static struct platform_device hawk_usb_vbus_device = { + .name = "reg-fixed-voltage", + .id = 1, + .dev = { + .platform_data = &hawk_usb_vbus, + }, +}; + +static struct gpiod_lookup_table hawk_usb_oc_gpio_lookup = { .dev_id = "ohci-da8xx", .table = { - GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, "vbus", 0), GPIO_LOOKUP("davinci_gpio", DA850_USB1_OC_PIN, "oc", 0), { } }, }; +static struct gpiod_lookup_table hawk_usb_vbus_gpio_lookup = { + .dev_id = "reg-fixed-voltage.1", + .table = { + GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, NULL, 0), + { } + }, +}; + +static struct gpiod_lookup_table *hawk_usb_gpio_lookups[] = { + &hawk_usb_oc_gpio_lookup, + &hawk_usb_vbus_gpio_lookup, +}; + static struct da8xx_ohci_root_hub omapl138_hawk_usb11_pdata = { /* TPS2087 switch @ 5V */ .potpgt = (3 + 1) / 2, /* 3 ms max */ @@ -327,12 +363,19 @@ static __init void omapl138_hawk_usb_init(void) pr_warn("%s: USB PHY CLK registration failed: %d\n", __func__, ret); + gpiod_add_lookup_tables(hawk_usb_gpio_lookups, + ARRAY_SIZE(hawk_usb_gpio_lookups)); + ret = da8xx_register_usb_phy(); if (ret) pr_warn("%s: USB PHY registration failed: %d\n", __func__, ret); - gpiod_add_lookup_table(&hawk_usb_gpio_lookup); + ret = platform_device_register(&hawk_usb_vbus_device); + if (ret) { + pr_warn("%s: Unable to register the vbus supply\n", __func__); + return; + } ret = da8xx_register_usb11(&omapl138_hawk_usb11_pdata); if (ret) -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DED5C43381 for ; Fri, 29 Mar 2019 09:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0611D218AE for ; Fri, 29 Mar 2019 09:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="D0JHjCon" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728896AbfC2JeH (ORCPT ); Fri, 29 Mar 2019 05:34:07 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:55127 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728630AbfC2Jds (ORCPT ); Fri, 29 Mar 2019 05:33:48 -0400 Received: by mail-wm1-f65.google.com with SMTP id c1so609182wml.4 for ; Fri, 29 Mar 2019 02:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JM1IFJaq9Fzy9jb7gkxjcG7uHNdo0C9cZXORwZYID2s=; b=D0JHjConPyyO0cRxQv1PUTZqVI3WTeq57J3FAP2XyHi2rJUUNI5ZC5L7oc/E6tlcJN pKNHgYGDM1aPFyKvAHOx5g33iVr1PTs45fCR7PCDPkoMwaK3YfH7RUk2J3PBNkEA4rBx sYENWcWooDcJodHMYVS5WMlwCz84djynJF+xtLKkE856uw5WapRrfx8t5I/axUlT05el Z28geVAWnsVKjM6IiysviN72ZTQI5oAQAAgMrm8iM9YB/HhM7CiR+4s/ZaZHhKAFbuf/ Gajlg7u54ny33L+HlpaZvMnZhVpGiBVJahmZS8Qsum5UFEK40GnEuuS3GpBfj74Ty3x+ hdng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JM1IFJaq9Fzy9jb7gkxjcG7uHNdo0C9cZXORwZYID2s=; b=o7iWJbOqyoOQgfE4NCQsGttQnp3PQKZCniNByZIq+B2rT0oY3PwpGEBnpwsIuqG64x C9B5p21HHemutavJdcAT/QOp4Zyb4+yoj23kQOQJ/k1eDDGqW8tqATAF8pjX9ORizC9H JPN89fxN7SRcu0tY0YrmJYQFtUPNKAe1qQ85XgjJNTWZQmZ6BaOfJ/lnf/iN6ESxcqer ZjDnyee0cVYKjHhXs2SSqWGP/swCGyOvI2cAonvYnXQpTaNFmTG8BJHV48HoN5uLJnuw 6Jl1v1sZOXYwiyQ+JE0Gsq9vOZdycbBolkVsbc/eRuffWlD5MaQl1USJx2JL7Krx5k4Z USUA== X-Gm-Message-State: APjAAAXMqP/UaYxukX7vAGgAFLLyuePhlYubxQubi2LsJwG9snC/L9ph nQZoTq5gHoVbBJCHZ8KvdWWUcg== X-Google-Smtp-Source: APXvYqxBhAX2VClwpi4aYDKKs3DFdRs9olKE3HhUScClXiKL60lGO7CW7XC2L6AlxrsLRV/60+rvBw== X-Received: by 2002:a1c:f115:: with SMTP id p21mr3028614wmh.93.1553852026829; Fri, 29 Mar 2019 02:33:46 -0700 (PDT) Received: from localhost.localdomain (aputeaux-684-1-29-77.w90-86.abo.wanadoo.fr. [90.86.254.77]) by smtp.gmail.com with ESMTPSA id s12sm1957125wmj.42.2019.03.29.02.33.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 02:33:46 -0700 (PDT) From: Bartosz Golaszewski To: Sekhar Nori , Kevin Hilman , Alan Stern , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 4/6] ARM: davinci: omapl138-hawk: add a fixed regulator for ohci-da8xx Date: Fri, 29 Mar 2019 10:33:32 +0100 Message-Id: <20190329093334.3885-5-brgl@bgdev.pl> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190329093334.3885-1-brgl@bgdev.pl> References: <20190329093334.3885-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski Instead of directly using the vbus GPIO we should model it as a fixed regulator. Add all necessary fix-ups for the regulator to be registered and configure the vbus GPIO as its enable pin. Signed-off-by: Bartosz Golaszewski --- arch/arm/mach-davinci/board-omapl138-hawk.c | 49 +++++++++++++++++++-- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c index e244c8648594..0039b4d4c935 100644 --- a/arch/arm/mach-davinci/board-omapl138-hawk.c +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #include @@ -298,15 +299,50 @@ static const short da850_hawk_usb11_pins[] = { -1 }; -static struct gpiod_lookup_table hawk_usb_gpio_lookup = { +static struct regulator_consumer_supply hawk_usb_supplies[] = { + REGULATOR_SUPPLY("vbus", NULL), +}; + +static struct regulator_init_data hawk_usb_vbus_data = { + .consumer_supplies = hawk_usb_supplies, + .num_consumer_supplies = ARRAY_SIZE(hawk_usb_supplies), +}; + +static struct fixed_voltage_config hawk_usb_vbus = { + .supply_name = "vbus", + .microvolts = 3300000, + .init_data = &hawk_usb_vbus_data, +}; + +static struct platform_device hawk_usb_vbus_device = { + .name = "reg-fixed-voltage", + .id = 1, + .dev = { + .platform_data = &hawk_usb_vbus, + }, +}; + +static struct gpiod_lookup_table hawk_usb_oc_gpio_lookup = { .dev_id = "ohci-da8xx", .table = { - GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, "vbus", 0), GPIO_LOOKUP("davinci_gpio", DA850_USB1_OC_PIN, "oc", 0), { } }, }; +static struct gpiod_lookup_table hawk_usb_vbus_gpio_lookup = { + .dev_id = "reg-fixed-voltage.1", + .table = { + GPIO_LOOKUP("davinci_gpio", DA850_USB1_VBUS_PIN, NULL, 0), + { } + }, +}; + +static struct gpiod_lookup_table *hawk_usb_gpio_lookups[] = { + &hawk_usb_oc_gpio_lookup, + &hawk_usb_vbus_gpio_lookup, +}; + static struct da8xx_ohci_root_hub omapl138_hawk_usb11_pdata = { /* TPS2087 switch @ 5V */ .potpgt = (3 + 1) / 2, /* 3 ms max */ @@ -327,12 +363,19 @@ static __init void omapl138_hawk_usb_init(void) pr_warn("%s: USB PHY CLK registration failed: %d\n", __func__, ret); + gpiod_add_lookup_tables(hawk_usb_gpio_lookups, + ARRAY_SIZE(hawk_usb_gpio_lookups)); + ret = da8xx_register_usb_phy(); if (ret) pr_warn("%s: USB PHY registration failed: %d\n", __func__, ret); - gpiod_add_lookup_table(&hawk_usb_gpio_lookup); + ret = platform_device_register(&hawk_usb_vbus_device); + if (ret) { + pr_warn("%s: Unable to register the vbus supply\n", __func__); + return; + } ret = da8xx_register_usb11(&omapl138_hawk_usb11_pdata); if (ret) -- 2.21.0