Re: [PATCH v2] Staging: media: davinci_vpfe: Convert ceil macro into an inline function

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Mar 27, 2019 at 01:00:52PM -0500, Madhumitha Prabakaran wrote:
> Convert macro into an inline function in order to maintain Linux kernel
> coding style based on which the inline function is preferable over the
> macro.
> 
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> 
> ---
> Changes in v2 -
> 
> - Corrected commit log spelling
> - Made the subject line unique from previous commit
> ---
>  drivers/staging/media/davinci_vpfe/dm365_ipipe.h   | 5 ++++-
>  drivers/staging/media/davinci_vpfe/dm365_resizer.c | 4 ++--
>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.h b/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
> index 174334b53f96..32dce3c95304 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
> @@ -27,7 +27,10 @@
>  #include "davinci_vpfe_user.h"
>  #include "vpfe_video.h"
>  
> -#define CEIL(a, b)	(((a) + (b-1)) / (b))
> +inline unsigned int ceil(unsigned int a, unsigned int b)
> +{
> +	return ((a + (b - 1)) / b);
> +}

Please just convert the caller to use the in-kernel function for this
instead of having a second one in just this driver.

thanks,

greg k-h