From: Ayan Halder <Ayan.Halder@arm.com>
To: "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
"james qian wang (Arm Technology China)"
<james.qian.wang@arm.com>,
"seanpaul@chromium.org" <seanpaul@chromium.org>, nd <nd@arm.com>
Subject: Re: [RFC PATCH] drm/komeda: Creates plane alpha and blend mode properties
Date: Fri, 29 Mar 2019 16:25:46 +0000 [thread overview]
Message-ID: <20190329162545.GA8314@arm.com> (raw)
In-Reply-To: <1553841845-20174-1-git-send-email-lowry.li@arm.com>
On Fri, Mar 29, 2019 at 06:44:45AM +0000, Lowry Li (Arm Technology China) wrote:
> Creates plane alpha and blend mode properties attached to plane.
>
> Signed-off-by: Lowry Li <lowry.li@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index af51f0c..0ebec39 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -212,6 +212,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
>
> drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
>
> + err = drm_plane_create_alpha_property(plane);
> + if (err)
> + goto cleanup;
> +
> + err = drm_plane_create_blend_mode_property(plane,
> + BIT(DRM_MODE_BLEND_PIXEL_NONE) |
> + BIT(DRM_MODE_BLEND_PREMULTI) |
> + BIT(DRM_MODE_BLEND_COVERAGE));
> + if (err)
> + goto cleanup;
> +
> return 0;
> cleanup:
> komeda_plane_destroy(plane);
> --
Please rebase and test your patches on drm-misc-next.
https://drm.pages.freedesktop.org/maintainer-tools/repositories.html
> 1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ayan Halder <Ayan.Halder@arm.com>
To: "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
"james qian wang (Arm Technology China)"
<james.qian.wang@arm.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
"seanpaul@chromium.org" <seanpaul@chromium.org>,
"airlied@linux.ie" <airlied@linux.ie>,
Brian Starkey <Brian.Starkey@arm.com>,
"Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
"Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
nd <nd@arm.com>
Subject: Re: [RFC PATCH] drm/komeda: Creates plane alpha and blend mode properties
Date: Fri, 29 Mar 2019 16:25:46 +0000 [thread overview]
Message-ID: <20190329162545.GA8314@arm.com> (raw)
In-Reply-To: <1553841845-20174-1-git-send-email-lowry.li@arm.com>
On Fri, Mar 29, 2019 at 06:44:45AM +0000, Lowry Li (Arm Technology China) wrote:
> Creates plane alpha and blend mode properties attached to plane.
>
> Signed-off-by: Lowry Li <lowry.li@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> index af51f0c..0ebec39 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -212,6 +212,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
>
> drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
>
> + err = drm_plane_create_alpha_property(plane);
> + if (err)
> + goto cleanup;
> +
> + err = drm_plane_create_blend_mode_property(plane,
> + BIT(DRM_MODE_BLEND_PIXEL_NONE) |
> + BIT(DRM_MODE_BLEND_PREMULTI) |
> + BIT(DRM_MODE_BLEND_COVERAGE));
> + if (err)
> + goto cleanup;
> +
> return 0;
> cleanup:
> komeda_plane_destroy(plane);
> --
Please rebase and test your patches on drm-misc-next.
https://drm.pages.freedesktop.org/maintainer-tools/repositories.html
> 1.9.1
next prev parent reply other threads:[~2019-03-29 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 6:44 [RFC PATCH] drm/komeda: Creates plane alpha and blend mode properties Lowry Li (Arm Technology China)
2019-03-29 6:44 ` Lowry Li (Arm Technology China)
2019-03-29 16:25 ` Ayan Halder [this message]
2019-03-29 16:25 ` Ayan Halder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329162545.GA8314@arm.com \
--to=ayan.halder@arm.com \
--cc=Jonathan.Chai@arm.com \
--cc=Julien.Yin@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lowry.Li@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.qian.wang@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.