From: Matthias Kaehlcke <mka@chromium.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: vctrl: Remove unneeded continue statement
Date: Fri, 29 Mar 2019 11:35:02 -0700 [thread overview]
Message-ID: <20190329183502.GG112750@google.com> (raw)
In-Reply-To: <20190329014631.17999-1-axel.lin@ingics.com>
Hi Axel,
On Fri, Mar 29, 2019 at 09:46:31AM +0800, Axel Lin wrote:
As Mukesh already mentioned, there should be a short description.
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/vctrl-regulator.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/vctrl-regulator.c b/drivers/regulator/vctrl-regulator.c
> index 78de002037c7..259864520a06 100644
> --- a/drivers/regulator/vctrl-regulator.c
> +++ b/drivers/regulator/vctrl-regulator.c
> @@ -334,10 +334,8 @@ static int vctrl_init_vtable(struct platform_device *pdev)
> ctrl_uV = regulator_list_voltage(ctrl_reg, i);
>
> if (ctrl_uV < vrange_ctrl->min_uV ||
> - ctrl_uV > vrange_ctrl->max_uV) {
> + ctrl_uV > vrange_ctrl->max_uV)
> rdesc->n_voltages--;
> - continue;
> - }
indeed, the 'continue' is pointless here. I guess at some stage of
development something else was done in the loop and this is a
leftover.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
prev parent reply other threads:[~2019-03-29 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 1:46 [PATCH] regulator: vctrl: Remove unneeded continue statement Axel Lin
2019-03-29 10:51 ` Mukesh Ojha
2019-03-29 18:35 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190329183502.GG112750@google.com \
--to=mka@chromium.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.