From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v4] drm/i915/icl: Fix clockgating issue when
 using scalers
Date: Fri, 29 Mar 2019 20:39:07 +0200
Message-ID: <20190329183907.GH3888@intel.com>
References: <20190315221838.22444-1-radhakrishna.sripada@intel.com>
 <20190328173519.1856-1-radhakrishna.sripada@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id AA1EC6E40D
 for <intel-gfx@lists.freedesktop.org>; Fri, 29 Mar 2019 18:39:16 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190328173519.1856-1-radhakrishna.sripada@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXIgMjgsIDIwMTkgYXQgMTA6MzU6MTlBTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy
aXBhZGEgd3JvdGU6Cj4gRml4ZXMgdGhlIGNsb2NrLWdhdGluZyBpc3N1ZSB3aGVuIHBpcGUgc2Nh
bGluZyBpcyBlbmFibGVkLgo+IChMaW5lYWdlICMyMDA2NjA0MzEyKQo+IAo+IFYyOiBGaXggdHlw
byBpbiBoZWFkbGluZShDaHJpcykKPiAgICAgSGFuZGxlIHRoZSBub24gZG91YmxlIGJ1ZmZlcmVk
IG5hdHVyZSBvZiB0aGUgcmVnaXN0ZXIoVmlsbGUpCj4gVjM6IEZpeCBjaGVja3BhdGNoIHdhcm5p
bmcuIEJBVCBmYWlsdXJlIGZvciBWMiBvbiBnZW4zIGxvb2tzIHVucmVsYXRlZC4KPiBWNDogU3Bs
aXQgdGhlIGljbCBhbmQgc2tsIHdhJ3MoVmlsbGUpCj4gCj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hy
aXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxh
QGxpbnV4LmludGVsLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwu
Y29tPgo+IENjOiBBZGl0eWEgU3dhcnVwIDxhZGl0eWEuc3dhcnVwQGludGVsLmNvbT4KPiBTaWdu
ZWQtb2ZmLWJ5OiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFrcmlzaG5hLnNyaXBhZGFAaW50
ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0
OCArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNl
cnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz
cGxheS5jCj4gaW5kZXggODU3NmE3Zjc5OWYyLi5jM2NhOWNmZDM2ZmUgMTAwNjQ0Cj4gLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTQ2Niw2ICs0NjYsNyBAQCBzdGF0aWMgY29u
c3Qgc3RydWN0IGludGVsX2xpbWl0IGludGVsX2xpbWl0c19ieHQgPSB7Cj4gIAkucDIgPSB7IC5w
Ml9zbG93ID0gMSwgLnAyX2Zhc3QgPSAyMCB9LAo+ICB9Owo+ICAKPiArLyogV0EgRGlzcGxheSAj
MDgyNzogR2VuOTphbGwgKi8KPiAgc3RhdGljIHZvaWQKPiAgc2tsX3dhX2Nsa2dhdGUoc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBpbnQgcGlwZSwgYm9vbCBlbmFibGUpCj4gIHsK
PiBAQCAtNDc4LDYgKzQ3OSwxNyBAQCBza2xfd2FfY2xrZ2F0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkKPiAgCQkJICAgfihEVVBTMV9H
QVRJTkdfRElTIHwgRFVQUzJfR0FUSU5HX0RJUykpOwo+ICB9Cj4gIAo+ICsvKiBXYV8yMDA2NjA0
MzEyOmljbCAqLwo+ICtzdGF0aWMgdm9pZAo+ICtpY2xfd2FfY2xrZ2F0ZShzdHJ1Y3QgZHJtX2k5
MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCBwaXBlLCBib29sIGVuYWJsZSkKClRoZXNlIGZ1bmN0
aW9ucyBuYW1lcyAoaW5jbHVkaW5nIHRoZSBza2wgb25lKSBhcmUgcmF0aGVyIHRvbyBnZW5lcmlj
CmFuZCBkb24ndCBkZXNjcmliZSB3aGljaCBjbG9jayBnYXRpbmcgd2UncmUgZGlzYWJsaW5nLiBC
dXQgZml4aW5nCnRoYXQgaXMgcHJvYmFibHkgbWF0ZXJpYWwgZm9yIGFub3RoZXIgcGF0Y2guCgo+
ICt7Cj4gKwlpZiAoZW5hYmxlKQo+ICsJCUk5MTVfV1JJVEUoQ0xLR0FURV9ESVNfUFNMKHBpcGUp
LCBEUEZSX0dBVElOR19ESVMpOwo+ICsJZWxzZQo+ICsJCUk5MTVfV1JJVEUoQ0xLR0FURV9ESVNf
UFNMKHBpcGUpLAo+ICsJCQkgICBJOTE1X1JFQUQoQ0xLR0FURV9ESVNfUFNMKHBpcGUpKSAmIH5E
UEZSX0dBVElOR19ESVMpOwoKTm8gUk1XIGZvciBlbmFibGUgYnV0IFJNVyBmb3IgZGlzYWJsZT8g
U2VlbXMgcmF0aGVyIGluY29uc2lzdGVudC4KCj4gK30KPiArCj4gIHN0YXRpYyBib29sCj4gIG5l
ZWRzX21vZGVzZXQoY29uc3Qgc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSkKPiAgewo+IEBA
IC01NDgxLDE0ICs1NDkzLDE4IEBAIHN0YXRpYyBib29sIGhzd19wb3N0X3VwZGF0ZV9lbmFibGVf
aXBzKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zCj4gIAlyZXR1cm4g
IW9sZF9jcnRjX3N0YXRlLT5pcHNfZW5hYmxlZDsKPiAgfQo+ICAKPiAtc3RhdGljIGJvb2wgbmVl
ZHNfbnYxMl93YShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gLQkJCSAgY29u
c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gK3N0YXRpYyBib29sIHNr
bF9uZWVkc19jbGtfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkg
ICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQoKU3RpbGwgbWl4
aW5nIG91ciB3b3JrYXJvdW5kcyBtb3JlIHRoYW4gSSdkIGxpa2UuIEkgc3VnZ2VzdCBrZWVwaW5n
CnRoZSB0d28gZW50aXJlbHkgc2VwYXJhdGUuCgo+ICB7Cj4gLQlpZiAoIWNydGNfc3RhdGUtPm52
MTJfcGxhbmVzKQo+IC0JCXJldHVybiBmYWxzZTsKPiAtCj4gIAkvKiBXQSBEaXNwbGF5ICMwODI3
OiBHZW45OmFsbCAqLwo+IC0JaWYgKElTX0dFTihkZXZfcHJpdiwgOSkgJiYgIUlTX0dFTUlOSUxB
S0UoZGV2X3ByaXYpKQo+ICsJaWYgKCEhY3J0Y19zdGF0ZS0+bnYxMl9wbGFuZXMgJiYgSVNfR0VO
KGRldl9wcml2LCA5KSAmJgo+ICsJICAgICFJU19HRU1JTklMQUtFKGRldl9wcml2KSkKPiArCQly
ZXR1cm4gdHJ1ZTsKPiArCj4gKwkvKgo+ICsJICogV2FfMjAwNjYwNDMxMjppY2wKPiArCSAqLwo+
ICsJaWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpICYmIGNydGNfc3RhdGUtPnBjaF9wZml0LmVuYWJs
ZWQpCj4gIAkJcmV0dXJuIHRydWU7Cj4gIAo+ICAJcmV0dXJuIGZhbHNlOwo+IEBAIC01NTI3LDEw
ICs1NTQzLDEyIEBAIHN0YXRpYyB2b2lkIGludGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBp
bnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSkKPiAgCQkJaW50ZWxfcG9zdF9lbmFibGVf
cHJpbWFyeSgmY3J0Yy0+YmFzZSwgcGlwZV9jb25maWcpOwo+ICAJfQo+ICAKPiAtCS8qIERpc3Bs
YXkgV0EgODI3ICovCj4gLQlpZiAobmVlZHNfbnYxMl93YShkZXZfcHJpdiwgb2xkX2NydGNfc3Rh
dGUpICYmCj4gLQkgICAgIW5lZWRzX252MTJfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkgewo+
IC0JCXNrbF93YV9jbGtnYXRlKGRldl9wcml2LCBjcnRjLT5waXBlLCBmYWxzZSk7Cj4gKwlpZiAo
c2tsX25lZWRzX2Nsa193YShkZXZfcHJpdiwgb2xkX2NydGNfc3RhdGUpICYmCj4gKwkgICAgIXNr
bF9uZWVkc19jbGtfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkgewo+ICsJCWlmIChJU19JQ0VM
QUtFKGRldl9wcml2KSkKPiArCQkJaWNsX3dhX2Nsa2dhdGUoZGV2X3ByaXYsIGNydGMtPnBpcGUs
IGZhbHNlKTsKPiArCQllbHNlCj4gKwkJCXNrbF93YV9jbGtnYXRlKGRldl9wcml2LCBjcnRjLT5w
aXBlLCBmYWxzZSk7Cj4gIAl9Cj4gIH0KPiAgCj4gQEAgLTU1NjYsMTAgKzU1ODQsMTIgQEAgc3Rh
dGljIHZvaWQgaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq
b2xkX2NydGNfc3RhdGUsCj4gIAkJCWludGVsX3NldF9jcHVfZmlmb191bmRlcnJ1bl9yZXBvcnRp
bmcoZGV2X3ByaXYsIGNydGMtPnBpcGUsIGZhbHNlKTsKPiAgCX0KPiAgCj4gLQkvKiBEaXNwbGF5
IFdBIDgyNyAqLwo+IC0JaWYgKCFuZWVkc19udjEyX3dhKGRldl9wcml2LCBvbGRfY3J0Y19zdGF0
ZSkgJiYKPiAtCSAgICBuZWVkc19udjEyX3dhKGRldl9wcml2LCBwaXBlX2NvbmZpZykpIHsKPiAt
CQlza2xfd2FfY2xrZ2F0ZShkZXZfcHJpdiwgY3J0Yy0+cGlwZSwgdHJ1ZSk7Cj4gKwlpZiAoIXNr
bF9uZWVkc19jbGtfd2EoZGV2X3ByaXYsIG9sZF9jcnRjX3N0YXRlKSAmJgo+ICsJICAgIHNrbF9u
ZWVkc19jbGtfd2EoZGV2X3ByaXYsIHBpcGVfY29uZmlnKSkgewo+ICsJCWlmIChJU19JQ0VMQUtF
KGRldl9wcml2KSkKPiArCQkJaWNsX3dhX2Nsa2dhdGUoZGV2X3ByaXYsIGNydGMtPnBpcGUsIHRy
dWUpOwo+ICsJCWVsc2UKPiArCQkJc2tsX3dhX2Nsa2dhdGUoZGV2X3ByaXYsIGNydGMtPnBpcGUs
IHRydWUpOwo+ICAJfQo+ICAKPiAgCS8qCj4gLS0gCj4gMi4yMC4wLnJjMi43Lmc5NjU3OThkMWYy
OTkKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz
dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v
bGlzdGluZm8vaW50ZWwtZ2Z4