All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: Neeraj Upadhyay <neeraju@codeaurora.org>,
	josh@joshtriplett.org, rostedt@goodmis.org,
	mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
	joel@joelfernandes.org, rcu@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks
Date: Fri, 29 Mar 2019 14:27:02 -0700	[thread overview]
Message-ID: <20190329212702.GA4102@linux.ibm.com> (raw)
In-Reply-To: <35a95581-138d-b047-b809-aff803287a23@codeaurora.org>

On Fri, Mar 29, 2019 at 03:42:44PM +0530, Mukesh Ojha wrote:
> 
> On 3/29/2019 3:25 PM, Neeraj Upadhyay wrote:
> >dump_blkd_tasks() uses 10 as the max number of blocked
> >tasks, which are printed. However, it has an argument
> >which provides that number. So, use the argument value
> >instead. As all callers currently pass 10 as the number,
> >there isn't any impact.
> >
> >Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
> 
> Looks good to me.
> 
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Applied, thank you both!

							Thanx, Paul

> Cheers,
> -Mukesh
> 
> >---
> >  kernel/rcu/tree_plugin.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> >index 3960294..08bcd87 100644
> >--- a/kernel/rcu/tree_plugin.h
> >+++ b/kernel/rcu/tree_plugin.h
> >@@ -740,7 +740,7 @@ void exit_rcu(void)
> >  	i = 0;
> >  	list_for_each(lhp, &rnp->blkd_tasks) {
> >  		pr_cont(" %p", lhp);
> >-		if (++i >= 10)
> >+		if (++i >= ncheck)
> >  			break;
> >  	}
> >  	pr_cont("\n");
> 


      reply	other threads:[~2019-03-29 21:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-29  9:55 [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks Neeraj Upadhyay
2019-03-29 10:12 ` Mukesh Ojha
2019-03-29 21:27   ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190329212702.GA4102@linux.ibm.com \
    --to=paulmck@linux.ibm.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mojha@codeaurora.org \
    --cc=neeraju@codeaurora.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.