From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4609C10F05 for ; Sat, 30 Mar 2019 00:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B469217F5 for ; Sat, 30 Mar 2019 00:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553907588; bh=x3EtDR0sDMXQxk3PzdNEji9N54zBVR1bl0DXXytkpSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JmmcAQ/MRAOg3Y4X7W/JO8F9iLLrCeBVuI9j+avI+FRW+6wQFxfBvN+hw+bmYSwOx ArW6xhE6lcs23cQbODWpDO3NK+Z9/CemAHOLafpj/NFoPhZkpKwpphrY/hehsfU1mn MCap1bY3jMlRS5UcMOe7fvj2oOGUvBuSCU32Y2Rw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732046AbfC3A5D (ORCPT ); Fri, 29 Mar 2019 20:57:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:36876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732032AbfC3A46 (ORCPT ); Fri, 29 Mar 2019 20:56:58 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90764206DD; Sat, 30 Mar 2019 00:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553907418; bh=x3EtDR0sDMXQxk3PzdNEji9N54zBVR1bl0DXXytkpSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XDSEOXMt2tkkWMS/E0wJlUC/C5B/UTm7iH8fJDjHMbjgfOtVMd39gAO8xOtHHZqOL ufrPs/Skty0b805mULtgvIrPgrDhHUVyn3j/Mwcy3Qnq3j30JlVvn1iB3XiZikeqwa kOO3ib5wCO+Fb9F8gynspJco8PvQCGMrfJxdzMUE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kangjie Lu , Takashi Iwai , Sasha Levin Subject: [PATCH AUTOSEL 4.4 05/21] ALSA: sb8: add a check for request_region Date: Fri, 29 Mar 2019 20:56:33 -0400 Message-Id: <20190330005649.28475-5-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190330005649.28475-1-sashal@kernel.org> References: <20190330005649.28475-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu [ Upstream commit dcd0feac9bab901d5739de51b3f69840851f8919 ] In case request_region fails, the fix returns an error code to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/isa/sb/sb8.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c index b8e2391c33ff..0c7fe1418447 100644 --- a/sound/isa/sb/sb8.c +++ b/sound/isa/sb/sb8.c @@ -111,6 +111,10 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev) /* block the 0x388 port to avoid PnP conflicts */ acard->fm_res = request_region(0x388, 4, "SoundBlaster FM"); + if (!acard->fm_res) { + err = -EBUSY; + goto _err; + } if (port[dev] != SNDRV_AUTO_PORT) { if ((err = snd_sbdsp_create(card, port[dev], irq[dev], -- 2.19.1