From: Brian Masney <masneyb@onstation.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: 'reg: property has invalid length' with new JSON-schema bindings
Date: Sun, 31 Mar 2019 06:39:00 -0400 [thread overview]
Message-ID: <20190331103900.GA10428@basecamp> (raw)
In-Reply-To: <20190331022653.GA8727@basecamp>
On Sat, Mar 30, 2019 at 10:26:53PM -0400, Brian Masney wrote:
> I'm finishing up a patch series that adds device tree support for a
> backlight driver and I made the bindings use the new JSON schema. I'm
> running into a problem with the reg property in the examples and I can
> reproduce the issue by adding an example to the trivial bindings:
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> b/Documentation/devicetree/bindings/trivial-devices.yaml
> index d79fb22bde39..bdab6a015db4 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -341,4 +341,10 @@ required:
> - compatible
> - reg
>
> +examples:
> + - |
> + isl29028@38 {
> + compatible = "isil,isl29028";
> + reg = <0x38>;
> + };
> ...
>
> 'make dt_binding_check' fails with the following error:
>
> Documentation/devicetree/bindings/trivial-devices.example.dts:11.5-18:
> Warning (reg_format): /isl29028@38:reg: property has invalid length
> (4 bytes) (#address-cells == 1, #size-cells == 1)
> ...
> Documentation/devicetree/bindings/trivial-devices.example.dtb:
> Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
I make the check happy by including an i2c node in my example.
examples:
- |
i2c {
#address-cells = <1>;
#size-cells = <0>;
isl29028@38 {
compatible = "isil,isl29028";
reg = <0x38>;
};
};
Sorry about the noise.
Brian
prev parent reply other threads:[~2019-03-31 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 2:26 'reg: property has invalid length' with new JSON-schema bindings Brian Masney
2019-03-31 10:39 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190331103900.GA10428@basecamp \
--to=masneyb@onstation.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.