All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] system/skeleton: remove password expiration from shadow
Date: Sun, 31 Mar 2019 15:17:01 +0200	[thread overview]
Message-ID: <20190331151701.4de2bc12@windsurf> (raw)
In-Reply-To: <20190320220327.47BF2814A6@busybox.osuosl.org>

Hello Arnout,

On Wed, 20 Mar 2019 23:06:29 +0100
Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> wrote:

> commit: https://git.buildroot.net/buildroot/commit/?id=be8d11c7e55d8dfe395774c04a7a35b949aa6d97
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> The fields in /etc/shadow were set as follows:
> 
> root::10933:0:99999:7:::
> 
> This sets the date of last password change to Jan 1, 2000, the minimum
> password age to 0 days, the maximum password age to near-infinity, and a
> warning period of 7 days. In practice, this means the password never
> expires. So all of this is quite useless.
> 
> On the other hand, mkusers creates lines without all of these options.
> It just sets ::::: which disables password expiration completely.
> 
> To make things consistent, do the same for the skeleton entries.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

It seems like you applied your own patch here, but without replying to
your original e-mail to say it was applied, and the patch state in
patchwork was also not set to Accepted. Seems like you perhaps pushed
it by mistake.

Anyway, no big deal, I was about to apply it, and that's what made me
discover that it was already applied :)

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-03-31 13:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 22:06 [Buildroot] [git commit] system/skeleton: remove password expiration from shadow Arnout Vandecappelle
2019-03-31 13:17 ` Thomas Petazzoni [this message]
2019-04-01 11:13   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190331151701.4de2bc12@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.