From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=zFUY=SC=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7E60EC43381
	for <netdev@archiver.kernel.org>; Sun, 31 Mar 2019 15:33:47 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 3E09A20882
	for <netdev@archiver.kernel.org>; Sun, 31 Mar 2019 15:33:47 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="UWmosBUX"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731228AbfCaPdq (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sun, 31 Mar 2019 11:33:46 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:44612 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731118AbfCaPdq (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sun, 31 Mar 2019 11:33:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=a4afLyeMANW2oa/32VwAfquI1pGHC0jjsJX9201ar2I=; b=UWmosBUXzujJF0OGTCRI22xiAn
        xy1Mj/4RdjYUAEDthFKhSQauihDEUKA09qZpwC9ztPbQaTi5Mh9o3+s747FMrF0vRJmDGtaKP2oX9
        6/0JJgMoXBnBS7/YENEVHWGJmmh2kmG0IQ/LGZg+OEMKvQy6b6po4bJpHIH/VwO1h2xM=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1hAcSs-0006AV-5C; Sun, 31 Mar 2019 17:33:42 +0200
Date:   Sun, 31 Mar 2019 17:33:42 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status
Message-ID: <20190331153342.GF20636@lunn.ch>
References: <36da82de-6dad-939e-7604-d3c0b93f54c8@gmail.com>
 <20190331145241.GC20636@lunn.ch>
 <c9289f2c-5546-41f8-dd49-464b0e45bfb4@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c9289f2c-5546-41f8-dd49-464b0e45bfb4@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sun, Mar 31, 2019 at 04:59:13PM +0200, Heiner Kallweit wrote:
> On 31.03.2019 16:52, Andrew Lunn wrote:
> >> -	if (AUTONEG_ENABLE == phydev->autoneg) {
> >> +	if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) {
> > 
> > Hi Heiner
> > 
> > I don't necessary agree with placing the constant first in the
> > comparison, but it is best practice not to change it when making
> > additions. It makes it a little bit harder to see what the actual
> > change was.
> > 
> I understand the point. However a patch to only change the order
> of the operands most likely would also be rejected as not being
> worth it.

As i said, i don't necessarily agree with the ordering, but i don't
object to it. There are reasonable arguments which it is better. So i
would just leave it alone.

       Andrew